[prev in list] [next in list] [prev in thread] [next in thread]
List: webkit-changes
Subject: [webkit-changes] [181954] releases/WebKitGTK/webkit-2.8
From: carlosgc () webkit ! org
Date: 2015-03-25 12:48:35
Message-ID: 20150325124835.C5F9A307F09 () svn ! webkit ! org
[Download RAW message or body]
[Attachment #2 (text/html)]
<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[181954] releases/WebKitGTK/webkit-2.8</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: \
verdana,arial,helvetica,sans-serif; font-size: 10pt; } #msg dl a { font-weight: \
bold} #msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: \
bold; } #msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: \
6px; } #logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em \
0; } #logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg \
h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; } \
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; \
} #logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: \
-1.5em; padding-left: 1.5em; } #logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em \
1em 0 1em; background: white;} #logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid \
#fa0; border-bottom: 1px solid #fa0; background: #fff; } #logmsg table th { \
text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted \
#fa0; } #logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: \
0.2em 0.5em; } #logmsg table thead th { text-align: center; border-bottom: 1px solid \
#fa0; } #logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: \
6px; } #patch { width: 100%; }
#patch h4 {font-family: \
verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, \
#patch .copfile {border:1px solid #ccc;margin:10px 0;} #patch ins \
{background:#dfd;text-decoration:none;display:block;padding:0 10px;} #patch del \
{background:#fdd;text-decoration:none;display:block;padding:0 10px;} #patch .lines, \
.info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a \
href="http://trac.webkit.org/projects/webkit/changeset/181954">181954</a></dd> \
<dt>Author</dt> <dd>carlosgc@webkit.org</dd> <dt>Date</dt> <dd>2015-03-25 05:48:35 \
-0700 (Wed, 25 Mar 2015)</dd> </dl>
<h3>Log Message</h3>
<pre>Merge <a href="http://trac.webkit.org/projects/webkit/changeset/181897">r181897</a> \
- Stop image from displaying when src attribute is removed or emptied \
https://bugs.webkit.org/show_bug.cgi?id=142677
Reviewed by Chris Dumez.
Source/WebCore:
Previously, we ignored empty attribute as failed URL, and didn't update the
renderer when an image was removed. This patch fixes that.
Tests: fast/dom/HTMLImageElement/image-empty-src.html
fast/dom/HTMLImageElement/image-remove-src.html
* loader/ImageLoader.cpp:
(WebCore::ImageLoader::updateFromElement):
LayoutTests:
* fast/dom/HTMLImageElement/image-empty-src-expected.html: Added.
* fast/dom/HTMLImageElement/image-empty-src.html: Added.
* fast/dom/HTMLImageElement/image-remove-src-expected.html: Added.
* fast/dom/HTMLImageElement/image-remove-src.html: Added.
* fast/dom/HTMLImageElement/image-empty-srcset-expected.html: Added.
* fast/dom/HTMLImageElement/image-empty-srcset.html: Added.
* fast/dom/HTMLImageElement/image-remove-srcset-expected.html: Added.
* fast/dom/HTMLImageElement/image-remove-srcset.html: Added.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#releasesWebKitGTKwebkit28LayoutTestsChangeLog">releases/WebKitGTK/webkit-2.8/LayoutTests/ChangeLog</a></li>
<li><a href="#releasesWebKitGTKwebkit28LayoutTestscanvasphiliptests2ddrawImageimagein \
completeomittedexpectedtxt">releases/WebKitGTK/webkit-2.8/LayoutTests/canvas/philip/tests/2d.drawImage.image.incomplete.omitted-expected.txt</a></li>
<li><a href="#releasesWebKitGTKwebkit28SourceWebCoreChangeLog">releases/WebKitGTK/webkit-2.8/Source/WebCore/ChangeLog</a></li>
<li><a href="#releasesWebKitGTKwebkit28SourceWebCoreloaderImageLoadercpp">releases/WebKitGTK/webkit-2.8/Source/WebCore/loader/ImageLoader.cpp</a></li>
</ul>
<h3>Added Paths</h3>
<ul>
<li><a href="#releasesWebKitGTKwebkit28LayoutTestsfastdomHTMLImageElementimageemptysrc \
expectedhtml">releases/WebKitGTK/webkit-2.8/LayoutTests/fast/dom/HTMLImageElement/image-empty-src-expected.html</a></li>
<li><a href="#releasesWebKitGTKwebkit28LayoutTestsfastdomHTMLImageElementimageemptysr \
chtml">releases/WebKitGTK/webkit-2.8/LayoutTests/fast/dom/HTMLImageElement/image-empty-src.html</a></li>
<li><a href="#releasesWebKitGTKwebkit28LayoutTestsfastdomHTMLImageElementimageemptysr \
csetexpectedhtml">releases/WebKitGTK/webkit-2.8/LayoutTests/fast/dom/HTMLImageElement/image-empty-srcset-expected.html</a></li>
<li><a href="#releasesWebKitGTKwebkit28LayoutTestsfastdomHTMLImageElementimageemptysr \
csethtml">releases/WebKitGTK/webkit-2.8/LayoutTests/fast/dom/HTMLImageElement/image-empty-srcset.html</a></li>
<li><a href="#releasesWebKitGTKwebkit28LayoutTestsfastdomHTMLImageElementimageremoves \
rcexpectedhtml">releases/WebKitGTK/webkit-2.8/LayoutTests/fast/dom/HTMLImageElement/image-remove-src-expected.html</a></li>
<li><a href="#releasesWebKitGTKwebkit28LayoutTestsfastdomHTMLImageElementimageremoves \
rchtml">releases/WebKitGTK/webkit-2.8/LayoutTests/fast/dom/HTMLImageElement/image-remove-src.html</a></li>
<li><a href="#releasesWebKitGTKwebkit28LayoutTestsfastdomHTMLImageElementimageremoves \
rcsetexpectedhtml">releases/WebKitGTK/webkit-2.8/LayoutTests/fast/dom/HTMLImageElement/image-remove-srcset-expected.html</a></li>
<li><a href="#releasesWebKitGTKwebkit28LayoutTestsfastdomHTMLImageElementimageremoves \
rcsethtml">releases/WebKitGTK/webkit-2.8/LayoutTests/fast/dom/HTMLImageElement/image-remove-srcset.html</a></li>
</ul>
<h3>Removed Paths</h3>
<ul>
<li><a href="#releasesWebKitGTKwebkit28LayoutTestsplatformmaccanvasphiliptests2ddrawIm \
ageimageincompleteomittedexpectedtxt">releases/WebKitGTK/webkit-2.8/LayoutTests/platfo \
rm/mac/canvas/philip/tests/2d.drawImage.image.incomplete.omitted-expected.txt</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="releasesWebKitGTKwebkit28LayoutTestsChangeLog"></a>
<div class="modfile"><h4>Modified: \
releases/WebKitGTK/webkit-2.8/LayoutTests/ChangeLog (181953 => 181954)</h4> <pre \
class="diff"><span> <span class="info">--- \
releases/WebKitGTK/webkit-2.8/LayoutTests/ChangeLog 2015-03-25 11:53:21 UTC (rev \
181953)
+++ releases/WebKitGTK/webkit-2.8/LayoutTests/ChangeLog 2015-03-25 12:48:35 UTC (rev \
181954) </span><span class="lines">@@ -1,3 +1,19 @@
</span><ins>+2015-03-24 Yoav Weiss <yoav@yoav.ws>
+
+ Stop image from displaying when src attribute is removed or emptied
+ https://bugs.webkit.org/show_bug.cgi?id=142677
+
+ Reviewed by Chris Dumez.
+
+ * fast/dom/HTMLImageElement/image-empty-src-expected.html: Added.
+ * fast/dom/HTMLImageElement/image-empty-src.html: Added.
+ * fast/dom/HTMLImageElement/image-remove-src-expected.html: Added.
+ * fast/dom/HTMLImageElement/image-remove-src.html: Added.
+ * fast/dom/HTMLImageElement/image-empty-srcset-expected.html: Added.
+ * fast/dom/HTMLImageElement/image-empty-srcset.html: Added.
+ * fast/dom/HTMLImageElement/image-remove-srcset-expected.html: Added.
+ * fast/dom/HTMLImageElement/image-remove-srcset.html: Added.
+
</ins><span class="cx"> 2015-03-23 Yoav Weiss <yoav@yoav.ws>
</span><span class="cx">
</span><span class="cx"> Update empty image canvas tests and fix a related \
bug </span></span></pre></div>
<a id="releasesWebKitGTKwebkit28LayoutTestscanvasphiliptests2ddrawImageimageincompleteomittedexpectedtxt"></a>
<div class="modfile"><h4>Modified: \
releases/WebKitGTK/webkit-2.8/LayoutTests/canvas/philip/tests/2d.drawImage.image.incomplete.omitted-expected.txt \
(181953 => 181954)</h4> <pre class="diff"><span>
<span class="info">--- \
releases/WebKitGTK/webkit-2.8/LayoutTests/canvas/philip/tests/2d.drawImage.image.incomplete.omitted-expected.txt 2015-03-25 \
11:53:21 UTC (rev 181953)
+++ releases/WebKitGTK/webkit-2.8/LayoutTests/canvas/philip/tests/2d.drawImage.image.incomplete.omitted-expected.txt 2015-03-25 \
12:48:35 UTC (rev 181954) </span><span class="lines">@@ -1 +1,2 @@
</span><span class="cx"> Passed
</span><ins>+
</ins></span></pre></div>
<a id="releasesWebKitGTKwebkit28LayoutTestsfastdomHTMLImageElementimageemptysrcexpectedhtml"></a>
<div class="addfile"><h4>Added: \
releases/WebKitGTK/webkit-2.8/LayoutTests/fast/dom/HTMLImageElement/image-empty-src-expected.html \
(0 => 181954)</h4> <pre class="diff"><span>
<span class="info">--- \
releases/WebKitGTK/webkit-2.8/LayoutTests/fast/dom/HTMLImageElement/image-empty-src-expected.html \
(rev 0)
+++ releases/WebKitGTK/webkit-2.8/LayoutTests/fast/dom/HTMLImageElement/image-empty-src-expected.html 2015-03-25 \
12:48:35 UTC (rev 181954) </span><span class="lines">@@ -0,0 +1,2 @@
</span><ins>+<!DOCTYPE html>
+<img id=image alt="We should see alt" width="75" \
height="25"> </ins></span></pre></div>
<a id="releasesWebKitGTKwebkit28LayoutTestsfastdomHTMLImageElementimageemptysrchtml"></a>
<div class="addfile"><h4>Added: \
releases/WebKitGTK/webkit-2.8/LayoutTests/fast/dom/HTMLImageElement/image-empty-src.html \
(0 => 181954)</h4> <pre class="diff"><span>
<span class="info">--- \
releases/WebKitGTK/webkit-2.8/LayoutTests/fast/dom/HTMLImageElement/image-empty-src.html \
(rev 0)
+++ releases/WebKitGTK/webkit-2.8/LayoutTests/fast/dom/HTMLImageElement/image-empty-src.html 2015-03-25 \
12:48:35 UTC (rev 181954) </span><span class="lines">@@ -0,0 +1,10 @@
</span><ins>+<!DOCTYPE html>
+<img id=image src="resources/blue_rect.jpg" alt="We should see \
alt"> +<script>
+ window.onload = function() {
+ var img = document.querySelector("#image");
+ img.src = "";
+ }
+</script>
+
+
</ins></span></pre></div>
<a id="releasesWebKitGTKwebkit28LayoutTestsfastdomHTMLImageElementimageemptysrcsetexpectedhtml"></a>
<div class="addfile"><h4>Added: \
releases/WebKitGTK/webkit-2.8/LayoutTests/fast/dom/HTMLImageElement/image-empty-srcset-expected.html \
(0 => 181954)</h4> <pre class="diff"><span>
<span class="info">--- \
releases/WebKitGTK/webkit-2.8/LayoutTests/fast/dom/HTMLImageElement/image-empty-srcset-expected.html \
(rev 0)
+++ releases/WebKitGTK/webkit-2.8/LayoutTests/fast/dom/HTMLImageElement/image-empty-srcset-expected.html 2015-03-25 \
12:48:35 UTC (rev 181954) </span><span class="lines">@@ -0,0 +1,2 @@
</span><ins>+<!DOCTYPE html>
+<img id=image alt="We should see alt" width="75" \
height="25"> </ins></span></pre></div>
<a id="releasesWebKitGTKwebkit28LayoutTestsfastdomHTMLImageElementimageemptysrcsethtml"></a>
<div class="addfile"><h4>Added: \
releases/WebKitGTK/webkit-2.8/LayoutTests/fast/dom/HTMLImageElement/image-empty-srcset.html \
(0 => 181954)</h4> <pre class="diff"><span>
<span class="info">--- \
releases/WebKitGTK/webkit-2.8/LayoutTests/fast/dom/HTMLImageElement/image-empty-srcset.html \
(rev 0)
+++ releases/WebKitGTK/webkit-2.8/LayoutTests/fast/dom/HTMLImageElement/image-empty-srcset.html 2015-03-25 \
12:48:35 UTC (rev 181954) </span><span class="lines">@@ -0,0 +1,10 @@
</span><ins>+<!DOCTYPE html>
+<img id=image srcset="resources/blue_rect.jpg" alt="We should see \
alt"> +<script>
+ window.onload = function() {
+ var img = document.querySelector("#image");
+ img.srcset = "";
+ }
+</script>
+
+
</ins></span></pre></div>
<a id="releasesWebKitGTKwebkit28LayoutTestsfastdomHTMLImageElementimageremovesrcexpectedhtml"></a>
<div class="addfile"><h4>Added: \
releases/WebKitGTK/webkit-2.8/LayoutTests/fast/dom/HTMLImageElement/image-remove-src-expected.html \
(0 => 181954)</h4> <pre class="diff"><span>
<span class="info">--- \
releases/WebKitGTK/webkit-2.8/LayoutTests/fast/dom/HTMLImageElement/image-remove-src-expected.html \
(rev 0)
+++ releases/WebKitGTK/webkit-2.8/LayoutTests/fast/dom/HTMLImageElement/image-remove-src-expected.html 2015-03-25 \
12:48:35 UTC (rev 181954) </span><span class="lines">@@ -0,0 +1,2 @@
</span><ins>+<!DOCTYPE html>
+<img id=image alt="We should see alt" width="75" \
height="25"> </ins></span></pre></div>
<a id="releasesWebKitGTKwebkit28LayoutTestsfastdomHTMLImageElementimageremovesrchtml"></a>
<div class="addfile"><h4>Added: \
releases/WebKitGTK/webkit-2.8/LayoutTests/fast/dom/HTMLImageElement/image-remove-src.html \
(0 => 181954)</h4> <pre class="diff"><span>
<span class="info">--- \
releases/WebKitGTK/webkit-2.8/LayoutTests/fast/dom/HTMLImageElement/image-remove-src.html \
(rev 0)
+++ releases/WebKitGTK/webkit-2.8/LayoutTests/fast/dom/HTMLImageElement/image-remove-src.html 2015-03-25 \
12:48:35 UTC (rev 181954) </span><span class="lines">@@ -0,0 +1,10 @@
</span><ins>+<!DOCTYPE html>
+<img id=image src="resources/blue_rect.jpg" alt="We should see \
alt"> +<script>
+ window.onload = function() {
+ var img = document.querySelector("#image");
+ img.removeAttribute("src");
+ }
+</script>
+
+
</ins></span></pre></div>
<a id="releasesWebKitGTKwebkit28LayoutTestsfastdomHTMLImageElementimageremovesrcsetexpectedhtml"></a>
<div class="addfile"><h4>Added: \
releases/WebKitGTK/webkit-2.8/LayoutTests/fast/dom/HTMLImageElement/image-remove-srcset-expected.html \
(0 => 181954)</h4> <pre class="diff"><span>
<span class="info">--- \
releases/WebKitGTK/webkit-2.8/LayoutTests/fast/dom/HTMLImageElement/image-remove-srcset-expected.html \
(rev 0)
+++ releases/WebKitGTK/webkit-2.8/LayoutTests/fast/dom/HTMLImageElement/image-remove-srcset-expected.html 2015-03-25 \
12:48:35 UTC (rev 181954) </span><span class="lines">@@ -0,0 +1,2 @@
</span><ins>+<!DOCTYPE html>
+<img id=image alt="We should see alt" width="75" \
height="25"> </ins></span></pre></div>
<a id="releasesWebKitGTKwebkit28LayoutTestsfastdomHTMLImageElementimageremovesrcsethtml"></a>
<div class="addfile"><h4>Added: \
releases/WebKitGTK/webkit-2.8/LayoutTests/fast/dom/HTMLImageElement/image-remove-srcset.html \
(0 => 181954)</h4> <pre class="diff"><span>
<span class="info">--- \
releases/WebKitGTK/webkit-2.8/LayoutTests/fast/dom/HTMLImageElement/image-remove-srcset.html \
(rev 0)
+++ releases/WebKitGTK/webkit-2.8/LayoutTests/fast/dom/HTMLImageElement/image-remove-srcset.html 2015-03-25 \
12:48:35 UTC (rev 181954) </span><span class="lines">@@ -0,0 +1,10 @@
</span><ins>+<!DOCTYPE html>
+<img id=image srcset="resources/blue_rect.jpg" alt="We should see \
alt"> +<script>
+ window.onload = function() {
+ var img = document.querySelector("#image");
+ img.removeAttribute("srcset");
+ }
+</script>
+
+
</ins></span></pre></div>
<a id="releasesWebKitGTKwebkit28LayoutTestsplatformmaccanvasphiliptests2ddrawImageimageincompleteomittedexpectedtxt"></a>
<div class="delfile"><h4>Deleted: \
releases/WebKitGTK/webkit-2.8/LayoutTests/platform/mac/canvas/philip/tests/2d.drawImage.image.incomplete.omitted-expected.txt \
(181953 => 181954)</h4> <pre class="diff"><span>
<span class="info">--- \
releases/WebKitGTK/webkit-2.8/LayoutTests/platform/mac/canvas/philip/tests/2d.drawImage.image.incomplete.omitted-expected.txt 2015-03-25 \
11:53:21 UTC (rev 181953)
+++ releases/WebKitGTK/webkit-2.8/LayoutTests/platform/mac/canvas/philip/tests/2d.drawImage.image.incomplete.omitted-expected.txt 2015-03-25 \
12:48:35 UTC (rev 181954) </span><span class="lines">@@ -1,2 +0,0 @@
</span><del>-Failed assertion: got pixel [255,0,0,255] at (50,25), expected \
[0,255,0,255] +/- 2
-
</del></span></pre></div>
<a id="releasesWebKitGTKwebkit28SourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: \
releases/WebKitGTK/webkit-2.8/Source/WebCore/ChangeLog (181953 => 181954)</h4> <pre \
class="diff"><span> <span class="info">--- \
releases/WebKitGTK/webkit-2.8/Source/WebCore/ChangeLog 2015-03-25 11:53:21 UTC (rev \
181953)
+++ releases/WebKitGTK/webkit-2.8/Source/WebCore/ChangeLog 2015-03-25 12:48:35 UTC \
(rev 181954) </span><span class="lines">@@ -1,3 +1,19 @@
</span><ins>+2015-03-24 Yoav Weiss <yoav@yoav.ws>
+
+ Stop image from displaying when src attribute is removed or emptied
+ https://bugs.webkit.org/show_bug.cgi?id=142677
+
+ Reviewed by Chris Dumez.
+
+ Previously, we ignored empty attribute as failed URL, and didn't update the
+ renderer when an image was removed. This patch fixes that.
+
+ Tests: fast/dom/HTMLImageElement/image-empty-src.html
+ fast/dom/HTMLImageElement/image-remove-src.html
+
+ * loader/ImageLoader.cpp:
+ (WebCore::ImageLoader::updateFromElement):
+
</ins><span class="cx"> 2015-03-23 Yoav Weiss <yoav@yoav.ws>
</span><span class="cx">
</span><span class="cx"> Update empty image canvas tests and fix a related \
bug </span></span></pre></div>
<a id="releasesWebKitGTKwebkit28SourceWebCoreloaderImageLoadercpp"></a>
<div class="modfile"><h4>Modified: \
releases/WebKitGTK/webkit-2.8/Source/WebCore/loader/ImageLoader.cpp (181953 => \
181954)</h4> <pre class="diff"><span>
<span class="info">--- \
releases/WebKitGTK/webkit-2.8/Source/WebCore/loader/ImageLoader.cpp 2015-03-25 \
11:53:21 UTC (rev 181953)
+++ releases/WebKitGTK/webkit-2.8/Source/WebCore/loader/ImageLoader.cpp 2015-03-25 \
12:48:35 UTC (rev 181954) </span><span class="lines">@@ -171,7 +171,8 @@
</span><span class="cx">
</span><span class="cx"> AtomicString attr = element().imageSourceURL();
</span><span class="cx">
</span><del>- if (attr == m_failedLoadURL)
</del><ins>+ // Avoid loading a URL we already failed to load.
+ if (!m_failedLoadURL.isEmpty() && attr == m_failedLoadURL)
</ins><span class="cx"> return;
</span><span class="cx">
</span><span class="cx"> // Do not load any image if the 'src' attribute is \
missing or if it is </span><span class="lines">@@ -254,8 +255,10 @@
</span><span class="cx"> // dispatched.
</span><span class="cx"> newImage->addClient(this);
</span><span class="cx"> }
</span><del>- if (oldImage)
</del><ins>+ if (oldImage) {
</ins><span class="cx"> oldImage->removeClient(this);
</span><ins>+ updateRenderer();
+ }
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> if (RenderImageResource* imageResource = \
renderImageResource()) </span></span></pre>
</div>
</div>
</body>
</html>
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic