[prev in list] [next in list] [prev in thread] [next in thread]
List: webkit-changes
Subject: [webkit-changes] [123688] trunk/Source/WebKit/win
From: commit-queue () webkit ! org
Date: 2012-07-26 1:01:24
Message-ID: 20120726010124.76AF6777C10A () lists ! macosforge ! org
[Download RAW message or body]
[Attachment #2 (text/html)]
<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[123688] trunk/Source/WebKit/win</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: \
verdana,arial,helvetica,sans-serif; font-size: 10pt; } #msg dl a { font-weight: \
bold} #msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: \
bold; } #msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: \
6px; } #logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em \
0; } #logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg \
h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; } \
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; \
} #logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: \
-1.5em; padding-left: 1.5em; } #logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em \
1em 0 1em; background: white;} #logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid \
#fa0; border-bottom: 1px solid #fa0; background: #fff; } #logmsg table th { \
text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted \
#fa0; } #logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: \
0.2em 0.5em; } #logmsg table thead th { text-align: center; border-bottom: 1px solid \
#fa0; } #logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: \
6px; } #patch { width: 100%; }
#patch h4 {font-family: \
verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, \
#patch .copfile {border:1px solid #ccc;margin:10px 0;} #patch ins \
{background:#dfd;text-decoration:none;display:block;padding:0 10px;} #patch del \
{background:#fdd;text-decoration:none;display:block;padding:0 10px;} #patch .lines, \
.info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a \
href="http://trac.webkit.org/projects/webkit/changeset/123688">123688</a></dd> \
<dt>Author</dt> <dd>commit-queue@webkit.org</dd> <dt>Date</dt> <dd>2012-07-25 \
18:01:24 -0700 (Wed, 25 Jul 2012)</dd> </dl>
<h3>Log Message</h3>
<pre>Changes to the WebFrame API cause dependent apps to crash.
https://bugs.webkit.org/show_bug.cgi?id=91656
<rdar://problem/11904605>
Patch by Roger Fong <roger_fong@apple.com> on 2012-07-25
Reviewed by Jon Honeycutt.
Changes to the WebFrame API cause certain apps to crash because of inconsistencies in \
the COM interface. The resumeAnimations and suspendAnimations are removed, which are \
still needed. The counterValueByElementId method was also removed, although is not \
needed there. However, for all of these methods, no method stubs were added where \
appropriate after removal.
* Interfaces/IWebFramePrivate.idl:
Added resumeAnimations() and suspendAnimations() methods back in. Added unused method \
stub for counterValueByElementId method.
* WebFrame.cpp:
(WebFrame::resumeAnimations):
Added this method back in.
(WebFrame::suspendAnimations):
Added this method back in.
* WebFrame.h:
(Re)added methods and unused method stubs.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkSourceWebKitwinChangeLog">trunk/Source/WebKit/win/ChangeLog</a></li>
<li><a href="#trunkSourceWebKitwinInterfacesIWebFramePrivateidl">trunk/Source/WebKit/win/Interfaces/IWebFramePrivate.idl</a></li>
<li><a href="#trunkSourceWebKitwinWebFramecpp">trunk/Source/WebKit/win/WebFrame.cpp</a></li>
<li><a href="#trunkSourceWebKitwinWebFrameh">trunk/Source/WebKit/win/WebFrame.h</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkSourceWebKitwinChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit/win/ChangeLog (123687 => \
123688)</h4> <pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit/win/ChangeLog 2012-07-26 01:01:08 UTC (rev \
123687)
+++ trunk/Source/WebKit/win/ChangeLog 2012-07-26 01:01:24 UTC (rev 123688)
</span><span class="lines">@@ -1,3 +1,28 @@
</span><ins>+2012-07-25 Roger Fong <roger_fong@apple.com>
+
+ Changes to the WebFrame API cause dependent apps to crash.
+ https://bugs.webkit.org/show_bug.cgi?id=91656
+ <rdar://problem/11904605>
+
+ Reviewed by Jon Honeycutt.
+
+ Changes to the WebFrame API cause certain apps to crash because of \
inconsistencies in the COM interface. + The resumeAnimations and \
suspendAnimations are removed, which are still needed. + The \
counterValueByElementId method was also removed, although is not needed there. + \
However, for all of these methods, no method stubs were added where appropriate after \
removal. +
+ * Interfaces/IWebFramePrivate.idl:
+ Added resumeAnimations() and suspendAnimations() methods back in. Added \
unused method stub for counterValueByElementId method. +
+ * WebFrame.cpp:
+ (WebFrame::resumeAnimations):
+ Added this method back in.
+ (WebFrame::suspendAnimations):
+ Added this method back in.
+
+ * WebFrame.h:
+ (Re)added methods and unused method stubs.
+
</ins><span class="cx"> 2012-07-23 Patrick Gansterer <paroga@webkit.org>
</span><span class="cx">
</span><span class="cx"> Build fix if NOMINMAX is defined by the build \
system. </span></span></pre></div>
<a id="trunkSourceWebKitwinInterfacesIWebFramePrivateidl"></a>
<div class="modfile"><h4>Modified: \
trunk/Source/WebKit/win/Interfaces/IWebFramePrivate.idl (123687 => 123688)</h4> <pre \
class="diff"><span> <span class="info">--- \
trunk/Source/WebKit/win/Interfaces/IWebFramePrivate.idl 2012-07-26 01:01:08 UTC (rev \
123687)
+++ trunk/Source/WebKit/win/Interfaces/IWebFramePrivate.idl 2012-07-26 01:01:24 UTC \
(rev 123688) </span><span class="lines">@@ -96,6 +96,8 @@
</span><span class="cx">
</span><span class="cx"> [local] JSGlobalContextRef \
globalContextForScriptWorld([in] IWebScriptWorld*); </span><span class="cx">
</span><ins>+ HRESULT unused3([in] BSTR, [out, retval] BSTR*);
+
</ins><span class="cx"> HRESULT visibleContentRect([out, retval] RECT*);
</span><span class="cx">
</span><span class="cx"> HRESULT pageNumberForElementById([in] BSTR id, [in] \
float pageWidthInPixels, [in] float pageHeightInPixels, [out, retval] int* \
pageNumber); </span><span class="lines">@@ -108,9 +110,13 @@
</span><span class="cx">
</span><span class="cx"> HRESULT renderTreeAsExternalRepresentation([in] BOOL \
forPrinting, [out, retval] BSTR* result); </span><span class="cx">
</span><ins>+ HRESULT suspendAnimations();
+ HRESULT resumeAnimations();
+
</ins><span class="cx"> HRESULT loadPlainTextString([in] BSTR string, [in] BSTR \
url); </span><span class="cx">
</span><span class="cx"> HRESULT clearOpener();
</span><span class="cx">
</span><span class="cx"> HRESULT setTextDirection([in] BSTR direction);
</span><ins>+
</ins><span class="cx"> }
</span></span></pre></div>
<a id="trunkSourceWebKitwinWebFramecpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit/win/WebFrame.cpp (123687 => \
123688)</h4> <pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit/win/WebFrame.cpp 2012-07-26 01:01:08 UTC \
(rev 123687)
+++ trunk/Source/WebKit/win/WebFrame.cpp 2012-07-26 01:01:24 UTC (rev 123688)
</span><span class="lines">@@ -1198,6 +1198,26 @@
</span><span class="cx"> return S_OK;
</span><span class="cx"> }
</span><span class="cx">
</span><ins>+HRESULT STDMETHODCALLTYPE WebFrame::resumeAnimations()
+{
+ Frame* frame = core(this);
+ if (!frame)
+ return E_FAIL;
+
+ frame->animation()->resumeAnimations();
+ return S_OK;
+}
+
+HRESULT STDMETHODCALLTYPE WebFrame::suspendAnimations()
+{
+ Frame* frame = core(this);
+ if (!frame)
+ return E_FAIL;
+
+ frame->animation()->suspendAnimations();
+ return S_OK;
+}
+
</ins><span class="cx"> HRESULT WebFrame::pauseAnimation(BSTR animationName, \
IDOMNode* node, double secondsFromNow, BOOL* animationWasRunning) </span><span \
class="cx"> { </span><span class="cx"> if (!node || !animationWasRunning)
</span></span></pre></div>
<a id="trunkSourceWebKitwinWebFrameh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit/win/WebFrame.h (123687 => \
123688)</h4> <pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit/win/WebFrame.h 2012-07-26 01:01:08 UTC \
(rev 123687)
+++ trunk/Source/WebKit/win/WebFrame.h 2012-07-26 01:01:24 UTC (rev 123688)
</span><span class="lines">@@ -280,6 +280,12 @@
</span><span class="cx">
</span><span class="cx"> virtual HRESULT STDMETHODCALLTYPE \
setTextDirection(BSTR); </span><span class="cx">
</span><ins>+ virtual HRESULT STDMETHODCALLTYPE unused3(BSTR, BSTR*) { return \
E_NOTIMPL; } +
+ virtual HRESULT STDMETHODCALLTYPE resumeAnimations();
+
+ virtual HRESULT STDMETHODCALLTYPE suspendAnimations();
+
</ins><span class="cx"> // IWebDocumentText
</span><span class="cx"> virtual HRESULT STDMETHODCALLTYPE supportsTextEncoding(
</span><span class="cx"> /* [retval][out] */ BOOL* result);
</span></span></pre>
</div>
</div>
</body>
</html>
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic