[prev in list] [next in list] [prev in thread] [next in thread]
List: webkit-changes
Subject: [webkit-changes] [112597] branches/chromium/1025/Source/WebCore/bindings/scripts/ CodeGeneratorV8.pm
From: cevans () google ! com
Date: 2012-03-29 23:09:33
Message-ID: 20120329230933.ADE205E4E8CC () lists ! macosforge ! org
[Download RAW message or body]
[Attachment #2 (text/html)]
<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[112597] branches/chromium/1025/Source/WebCore/bindings/scripts/CodeGeneratorV8.pm</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: \
verdana,arial,helvetica,sans-serif; font-size: 10pt; } #msg dl a { font-weight: \
bold} #msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: \
bold; } #msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: \
6px; } #logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em \
0; } #logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg \
h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; } \
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; \
} #logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: \
-1.5em; padding-left: 1.5em; } #logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em \
1em 0 1em; background: white;} #logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid \
#fa0; border-bottom: 1px solid #fa0; background: #fff; } #logmsg table th { \
text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted \
#fa0; } #logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: \
0.2em 0.5em; } #logmsg table thead th { text-align: center; border-bottom: 1px solid \
#fa0; } #logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: \
6px; } #patch { width: 100%; }
#patch h4 {font-family: \
verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, \
#patch .copfile {border:1px solid #ccc;margin:10px 0;} #patch ins \
{background:#dfd;text-decoration:none;display:block;padding:0 10px;} #patch del \
{background:#fdd;text-decoration:none;display:block;padding:0 10px;} #patch .lines, \
.info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a \
href="http://trac.webkit.org/projects/webkit/changeset/112597">112597</a></dd> \
<dt>Author</dt> <dd>cevans@google.com</dd> <dt>Date</dt> <dd>2012-03-29 16:09:33 \
-0700 (Thu, 29 Mar 2012)</dd> </dl>
<h3>Log Message</h3>
<pre>Merge 111813
BUG=118185
Review URL: https://chromiumcodereview.appspot.com/9939001</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#brancheschromium1025SourceWebCorebindingsscriptsCodeGeneratorV8pm">branches/chromium/1025/Source/WebCore/bindings/scripts/CodeGeneratorV8.pm</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="brancheschromium1025SourceWebCorebindingsscriptsCodeGeneratorV8pm"></a>
<div class="modfile"><h4>Modified: \
branches/chromium/1025/Source/WebCore/bindings/scripts/CodeGeneratorV8.pm (112596 => \
112597)</h4> <pre class="diff"><span>
<span class="info">--- \
branches/chromium/1025/Source/WebCore/bindings/scripts/CodeGeneratorV8.pm 2012-03-29 \
23:03:58 UTC (rev 112596)
+++ branches/chromium/1025/Source/WebCore/bindings/scripts/CodeGeneratorV8.pm 2012-03-29 \
23:09:33 UTC (rev 112597) </span><span class="lines">@@ -434,11 +434,12 @@
</span><span class="cx"> END
</span><span class="cx"> }
</span><span class="cx">
</span><ins>+ my $wrapSlowArgumentType = GetPassRefPtrType($nativeType);
</ins><span class="cx"> push(@headerContent, <<END);
</span><span class="cx"> static v8::Handle<v8::Object> \
existingWrapper(${nativeType}*); </span><span class="cx">
</span><span class="cx"> private:
</span><del>- static v8::Handle<v8::Object> wrapSlow(${nativeType}*);
</del><ins>+ static v8::Handle<v8::Object> \
wrapSlow(${wrapSlowArgumentType}); </ins><span class="cx"> };
</span><span class="cx">
</span><span class="cx"> END
</span><span class="lines">@@ -3041,10 +3042,11 @@
</span><span class="cx"> my $domMapFunction = GetDomMapFunction($dataNode, \
$interfaceName); </span><span class="cx"> my $forceNewObjectInput = \
IsDOMNodeType($interfaceName) ? ", bool forceNewObject" : ""; \
</span><span class="cx"> my $forceNewObjectCall = IsDOMNodeType($interfaceName) ? \
", forceNewObject" : ""; </span><ins>+ my \
$wrapSlowArgumentType = GetPassRefPtrType($nativeType); </ins><span class="cx">
</span><span class="cx"> push(@implContent, <<END);
</span><span class="cx">
</span><del>-v8::Handle<v8::Object> ${className}::wrapSlow(${nativeType}* impl)
</del><ins>+v8::Handle<v8::Object> \
${className}::wrapSlow(${wrapSlowArgumentType} impl) </ins><span class="cx"> {
</span><span class="cx"> v8::Handle<v8::Object> wrapper;
</span><span class="cx"> V8Proxy* proxy = 0;
</span><span class="lines">@@ -3054,10 +3056,10 @@
</span><span class="cx"> push(@implContent, <<END);
</span><span class="cx"> if (impl->document()) {
</span><span class="cx"> proxy = \
V8Proxy::retrieve(impl->document()->frame()); </span><del>- if (proxy \
&& static_cast<Node*>(impl->document()) == \
static_cast<Node*>(impl)) { </del><ins>+ if (proxy && \
static_cast<Node*>(impl->document()) == \
static_cast<Node*>(impl.get())) { </ins><span class="cx"> if \
(proxy->windowShell()->context().IsEmpty() && \
proxy->windowShell()->initContextIfNeeded()) { </span><span class="cx"> \
// initContextIfNeeded may have created a wrapper for the object, retry from the \
start. </span><del>- return ${className}::wrap(impl);
</del><ins>+ return ${className}::wrap(impl.get());
</ins><span class="cx"> }
</span><span class="cx"> }
</span><span class="cx"> }
</span><span class="lines">@@ -3092,7 +3094,7 @@
</span><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> push(@implContent, <<END);
</span><del>- wrapper = V8DOMWrapper::instantiateV8Object(proxy, &info, impl);
</del><ins>+ wrapper = V8DOMWrapper::instantiateV8Object(proxy, &info, \
impl.get()); </ins><span class="cx"> END
</span><span class="cx"> if (IsNodeSubType($dataNode) || \
IsVisibleAcrossOrigins($dataNode)) { </span><span class="cx"> \
push(@implContent, <<END); </span><span class="lines">@@ -3106,8 +3108,6 @@
</span><span class="cx"> if (wrapper.IsEmpty())
</span><span class="cx"> return wrapper;
</span><span class="cx"> END
</span><del>- push(@implContent, "\n impl->ref();\n") if \
IsRefPtrType($interfaceName);
-
</del><span class="cx"> if ($serializedAttribute) {
</span><span class="cx"> GenerateEagerDeserialization($serializedAttribute);
</span><span class="cx"> }
</span><span class="lines">@@ -3122,12 +3122,9 @@
</span><span class="cx"> push(@implContent, <<END);
</span><span class="cx"> wrapperHandle.SetWrapperClassId(v8DOMSubtreeClassId);
</span><span class="cx"> END
</span><del>- }
</del><ins>+ }
</ins><span class="cx"> push(@implContent, <<END);
</span><del>- ${domMapFunction}.set(impl, wrapperHandle);
-END
-
- push(@implContent, <<END);
</del><ins>+ ${domMapFunction}.set(impl.leakRef(), wrapperHandle);
</ins><span class="cx"> return wrapper;
</span><span class="cx"> }
</span><span class="cx"> END
</span><span class="lines">@@ -3898,6 +3895,14 @@
</span><span class="cx"> return "RuntimeEnabledFeatures::" . \
$codeGenerator->WK_lcfirst($signature->name) . "Enabled"; \
</span><span class="cx"> } </span><span class="cx">
</span><ins>+sub GetPassRefPtrType
+{
+ my $className = shift;
+
+ my $angleBracketSpace = $className =~ />$/ ? " " : "";
+ return "PassRefPtr<${className}${angleBracketSpace}>";
+}
+
</ins><span class="cx"> sub DebugPrint
</span><span class="cx"> {
</span><span class="cx"> my $output = shift;
</span></span></pre>
</div>
</div>
</body>
</html>
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic