[prev in list] [next in list] [prev in thread] [next in thread]
List: webkit-changes
Subject: [webkit-changes] [109268] trunk/Source/JavaScriptCore
From: fpizlo () apple ! com
Date: 2012-02-29 22:47:31
Message-ID: 20120229224732.6A0F157D96D3 () lists ! macosforge ! org
[Download RAW message or body]
[Attachment #2 (text/html)]
<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[109268] trunk/Source/JavaScriptCore</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: \
verdana,arial,helvetica,sans-serif; font-size: 10pt; } #msg dl a { font-weight: \
bold} #msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: \
bold; } #msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: \
6px; } #logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em \
0; } #logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg \
h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; } \
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; \
} #logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: \
-1.5em; padding-left: 1.5em; } #logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em \
1em 0 1em; background: white;} #logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid \
#fa0; border-bottom: 1px solid #fa0; background: #fff; } #logmsg table th { \
text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted \
#fa0; } #logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: \
0.2em 0.5em; } #logmsg table thead th { text-align: center; border-bottom: 1px solid \
#fa0; } #logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: \
6px; } #patch { width: 100%; }
#patch h4 {font-family: \
verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, \
#patch .copfile {border:1px solid #ccc;margin:10px 0;} #patch ins \
{background:#dfd;text-decoration:none;display:block;padding:0 10px;} #patch del \
{background:#fdd;text-decoration:none;display:block;padding:0 10px;} #patch .lines, \
.info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a \
href="http://trac.webkit.org/projects/webkit/changeset/109268">109268</a></dd> \
<dt>Author</dt> <dd>fpizlo@apple.com</dd> <dt>Date</dt> <dd>2012-02-29 14:47:31 -0800 \
(Wed, 29 Feb 2012)</dd> </dl>
<h3>Log Message</h3>
<pre>RefCounted::deprecatedTurnOffVerifier() should not be deprecated
https://bugs.webkit.org/show_bug.cgi?id=79864
Reviewed by Oliver Hunt.
Removed the word "deprecated" from the name of this method, since this \
method should not be deprecated. It works just fine as it is, and there is simply no
alternative to calling this method for many interesting JSC classes.
* parser/SourceProvider.h:
(JSC::SourceProvider::SourceProvider):
* runtime/SymbolTable.h:
(JSC::SharedSymbolTable::SharedSymbolTable):
* wtf/MetaAllocator.cpp:
(WTF::MetaAllocatorHandle::MetaAllocatorHandle):
(WTF::MetaAllocator::allocate):
* wtf/RefCounted.h:
(RefCountedBase):
(WTF::RefCountedBase::turnOffVerifier):</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkSourceJavaScriptCoreChangeLog">trunk/Source/JavaScriptCore/ChangeLog</a></li>
<li><a href="#trunkSourceJavaScriptCoreparserSourceProviderh">trunk/Source/JavaScriptCore/parser/SourceProvider.h</a></li>
<li><a href="#trunkSourceJavaScriptCoreruntimeSymbolTableh">trunk/Source/JavaScriptCore/runtime/SymbolTable.h</a></li>
<li><a href="#trunkSourceJavaScriptCorewtfMetaAllocatorcpp">trunk/Source/JavaScriptCore/wtf/MetaAllocator.cpp</a></li>
<li><a href="#trunkSourceJavaScriptCorewtfRefCountedh">trunk/Source/JavaScriptCore/wtf/RefCounted.h</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkSourceJavaScriptCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/JavaScriptCore/ChangeLog (109267 => \
109268)</h4> <pre class="diff"><span>
<span class="info">--- trunk/Source/JavaScriptCore/ChangeLog 2012-02-29 22:44:33 UTC \
(rev 109267)
+++ trunk/Source/JavaScriptCore/ChangeLog 2012-02-29 22:47:31 UTC (rev 109268)
</span><span class="lines">@@ -1,3 +1,25 @@
</span><ins>+2012-02-28 Filip Pizlo <fpizlo@apple.com>
+
+ RefCounted::deprecatedTurnOffVerifier() should not be deprecated
+ https://bugs.webkit.org/show_bug.cgi?id=79864
+
+ Reviewed by Oliver Hunt.
+
+ Removed the word "deprecated" from the name of this method, since \
this method + should not be deprecated. It works just fine as it is, and there \
is simply no + alternative to calling this method for many interesting JSC \
classes. +
+ * parser/SourceProvider.h:
+ (JSC::SourceProvider::SourceProvider):
+ * runtime/SymbolTable.h:
+ (JSC::SharedSymbolTable::SharedSymbolTable):
+ * wtf/MetaAllocator.cpp:
+ (WTF::MetaAllocatorHandle::MetaAllocatorHandle):
+ (WTF::MetaAllocator::allocate):
+ * wtf/RefCounted.h:
+ (RefCountedBase):
+ (WTF::RefCountedBase::turnOffVerifier):
+
</ins><span class="cx"> 2012-02-29 Gavin Barraclough <barraclough@apple.com>
</span><span class="cx">
</span><span class="cx"> Writable attribute not set correctly when redefining \
an accessor to a data descriptor </span></span></pre></div>
<a id="trunkSourceJavaScriptCoreparserSourceProviderh"></a>
<div class="modfile"><h4>Modified: \
trunk/Source/JavaScriptCore/parser/SourceProvider.h (109267 => 109268)</h4> <pre \
class="diff"><span> <span class="info">--- \
trunk/Source/JavaScriptCore/parser/SourceProvider.h 2012-02-29 22:44:33 UTC (rev \
109267)
+++ trunk/Source/JavaScriptCore/parser/SourceProvider.h 2012-02-29 22:47:31 UTC (rev \
109268) </span><span class="lines">@@ -47,7 +47,7 @@
</span><span class="cx"> , m_cache(cache ? cache : new \
SourceProviderCache) </span><span class="cx"> , m_cacheOwned(!cache)
</span><span class="cx"> {
</span><del>- deprecatedTurnOffVerifier();
</del><ins>+ turnOffVerifier();
</ins><span class="cx"> }
</span><span class="cx"> virtual ~SourceProvider()
</span><span class="cx"> {
</span></span></pre></div>
<a id="trunkSourceJavaScriptCoreruntimeSymbolTableh"></a>
<div class="modfile"><h4>Modified: trunk/Source/JavaScriptCore/runtime/SymbolTable.h \
(109267 => 109268)</h4> <pre class="diff"><span>
<span class="info">--- trunk/Source/JavaScriptCore/runtime/SymbolTable.h 2012-02-29 \
22:44:33 UTC (rev 109267)
+++ trunk/Source/JavaScriptCore/runtime/SymbolTable.h 2012-02-29 22:47:31 UTC (rev \
109268) </span><span class="lines">@@ -125,7 +125,7 @@
</span><span class="cx"> public:
</span><span class="cx"> static PassRefPtr<SharedSymbolTable> create() \
{ return adoptRef(new SharedSymbolTable); } </span><span class="cx"> private:
</span><del>- SharedSymbolTable() { deprecatedTurnOffVerifier(); }
</del><ins>+ SharedSymbolTable() { turnOffVerifier(); }
</ins><span class="cx"> };
</span><span class="cx">
</span><span class="cx"> } // namespace JSC
</span></span></pre></div>
<a id="trunkSourceJavaScriptCorewtfMetaAllocatorcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/JavaScriptCore/wtf/MetaAllocator.cpp \
(109267 => 109268)</h4> <pre class="diff"><span>
<span class="info">--- trunk/Source/JavaScriptCore/wtf/MetaAllocator.cpp 2012-02-29 \
22:44:33 UTC (rev 109267)
+++ trunk/Source/JavaScriptCore/wtf/MetaAllocator.cpp 2012-02-29 22:47:31 UTC (rev \
109268) </span><span class="lines">@@ -64,6 +64,7 @@
</span><span class="cx"> ASSERT(allocator);
</span><span class="cx"> ASSERT(start);
</span><span class="cx"> ASSERT(sizeInBytes);
</span><ins>+ turnOffVerifier();
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> MetaAllocatorHandle::~MetaAllocatorHandle()
</span><span class="lines">@@ -169,8 +170,6 @@
</span><span class="cx"> #endif
</span><span class="cx">
</span><span class="cx"> MetaAllocatorHandle* handle = new \
MetaAllocatorHandle(this, start, sizeInBytes, ownerUID); </span><del>- // FIXME: \
Implement a verifier scheme that groks MetaAllocatorHandles
- handle->deprecatedTurnOffVerifier();
</del><span class="cx">
</span><span class="cx"> if (UNLIKELY(!!m_tracker))
</span><span class="cx"> m_tracker->notify(handle);
</span></span></pre></div>
<a id="trunkSourceJavaScriptCorewtfRefCountedh"></a>
<div class="modfile"><h4>Modified: trunk/Source/JavaScriptCore/wtf/RefCounted.h \
(109267 => 109268)</h4> <pre class="diff"><span>
<span class="info">--- trunk/Source/JavaScriptCore/wtf/RefCounted.h 2012-02-29 \
22:44:33 UTC (rev 109267)
+++ trunk/Source/JavaScriptCore/wtf/RefCounted.h 2012-02-29 22:47:31 UTC (rev 109268)
</span><span class="lines">@@ -77,8 +77,15 @@
</span><span class="cx">
</span><span class="cx"> // Turns off verification. Use of this method is \
discouraged (instead extend </span><span class="cx"> // ThreadRestrictionVerifier \
to verify your case). </span><del>- // FIXME: remove this method.
- void deprecatedTurnOffVerifier()
</del><ins>+ // NB. It is necessary to call this in the constructor of many \
objects in + // JavaScriptCore, because JavaScriptCore objects may be used from \
multiple + // threads even if the reference counting is done in a racy manner. \
This is + // because a JSC instance may be used from multiple threads so long as \
all + // accesses into that instance are protected by a per-instance lock. It \
would + // be absolutely wrong to prohibit this pattern, and it would be a \
disastrous + // regression to require that the objects within that instance use a \
thread- + // safe version of reference counting.
+ void turnOffVerifier()
</ins><span class="cx"> {
</span><span class="cx"> #ifndef NDEBUG
</span><span class="cx"> m_verifier.turnOffVerification();
</span></span></pre>
</div>
</div>
</body>
</html>
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic