[prev in list] [next in list] [prev in thread] [next in thread]
List: webkit-changes
Subject: [webkit-changes] [98907] trunk/Source/WebKit2
From: andersca () apple ! com
Date: 2011-10-31 23:38:27
Message-ID: 20111031233828.55415447DFBD () lists ! macosforge ! org
[Download RAW message or body]
[Attachment #2 (text/html)]
<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[98907] trunk/Source/WebKit2</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: \
verdana,arial,helvetica,sans-serif; font-size: 10pt; } #msg dl a { font-weight: \
bold} #msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: \
bold; } #msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: \
6px; } #logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em \
0; } #logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg \
h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; } \
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; \
} #logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: \
-1.5em; padding-left: 1.5em; } #logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em \
1em 0 1em; background: white;} #logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid \
#fa0; border-bottom: 1px solid #fa0; background: #fff; } #logmsg table th { \
text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted \
#fa0; } #logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: \
0.2em 0.5em; } #logmsg table thead th { text-align: center; border-bottom: 1px solid \
#fa0; } #logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: \
6px; } #patch { width: 100%; }
#patch h4 {font-family: \
verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, \
#patch .copfile {border:1px solid #ccc;margin:10px 0;} #patch ins \
{background:#dfd;text-decoration:none;display:block;padding:0 10px;} #patch del \
{background:#fdd;text-decoration:none;display:block;padding:0 10px;} #patch .lines, \
.info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a \
href="http://trac.webkit.org/projects/webkit/changeset/98907">98907</a></dd> \
<dt>Author</dt> <dd>andersca@apple.com</dd> <dt>Date</dt> <dd>2011-10-31 16:38:27 \
-0700 (Mon, 31 Oct 2011)</dd> </dl>
<h3>Log Message</h3>
<pre>Remove some uses of m_frameRectInWindowCoordinates from PluginProxy
https://bugs.webkit.org/show_bug.cgi?id=71252
Reviewed by Darin Adler.
* WebProcess/Plugins/PluginProxy.cpp:
(WebKit::PluginProxy::paint):
(WebKit::PluginProxy::geometryDidChange):
(WebKit::PluginProxy::updateBackingStore):
(WebKit::PluginProxy::pluginBounds):
* WebProcess/Plugins/PluginProxy.h:</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkSourceWebKit2ChangeLog">trunk/Source/WebKit2/ChangeLog</a></li>
<li><a href="#trunkSourceWebKit2WebProcessPluginsPluginProxycpp">trunk/Source/WebKit2/WebProcess/Plugins/PluginProxy.cpp</a></li>
<li><a href="#trunkSourceWebKit2WebProcessPluginsPluginProxyh">trunk/Source/WebKit2/WebProcess/Plugins/PluginProxy.h</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkSourceWebKit2ChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/ChangeLog (98906 => \
98907)</h4> <pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/ChangeLog 2011-10-31 23:34:02 UTC (rev \
98906)
+++ trunk/Source/WebKit2/ChangeLog 2011-10-31 23:38:27 UTC (rev 98907)
</span><span class="lines">@@ -1,5 +1,19 @@
</span><span class="cx"> 2011-10-31 Anders Carlsson <andersca@apple.com>
</span><span class="cx">
</span><ins>+ Remove some uses of m_frameRectInWindowCoordinates from \
PluginProxy + https://bugs.webkit.org/show_bug.cgi?id=71252
+
+ Reviewed by Darin Adler.
+
+ * WebProcess/Plugins/PluginProxy.cpp:
+ (WebKit::PluginProxy::paint):
+ (WebKit::PluginProxy::geometryDidChange):
+ (WebKit::PluginProxy::updateBackingStore):
+ (WebKit::PluginProxy::pluginBounds):
+ * WebProcess/Plugins/PluginProxy.h:
+
+2011-10-31 Anders Carlsson <andersca@apple.com>
+
</ins><span class="cx"> Implement PluginProxy::geometryDidChange
</span><span class="cx"> https://bugs.webkit.org/show_bug.cgi?id=71251
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebKit2WebProcessPluginsPluginProxycpp"></a>
<div class="modfile"><h4>Modified: \
trunk/Source/WebKit2/WebProcess/Plugins/PluginProxy.cpp (98906 => 98907)</h4> <pre \
class="diff"><span> <span class="info">--- \
trunk/Source/WebKit2/WebProcess/Plugins/PluginProxy.cpp 2011-10-31 23:34:02 UTC (rev \
98906)
+++ trunk/Source/WebKit2/WebProcess/Plugins/PluginProxy.cpp 2011-10-31 23:38:27 UTC \
(rev 98907) </span><span class="lines">@@ -143,7 +143,7 @@
</span><span class="cx"> \
graphicsContext->applyDeviceScaleFactor(contentsScaleFactor()); </span><span \
class="cx"> graphicsContext->setCompositeOperation(CompositeCopy); \
</span><span class="cx"> </span><del>- \
m_pluginBackingStore->paint(*graphicsContext, contentsScaleFactor(), IntPoint(), \
IntRect(0, 0, m_frameRectInWindowCoordinates.width(), \
m_frameRectInWindowCoordinates.height())); </del><ins>+ \
m_pluginBackingStore->paint(*graphicsContext, contentsScaleFactor(), IntPoint(), \
pluginBounds()); </ins><span class="cx">
</span><span class="cx"> m_pluginBackingStoreContainsValidData = true;
</span><span class="cx"> }
</span><span class="lines">@@ -180,7 +180,7 @@
</span><span class="cx"> {
</span><span class="cx"> ASSERT(m_isStarted);
</span><span class="cx">
</span><del>- if (m_frameRectInWindowCoordinates.isEmpty() || \
!needsBackingStore()) { </del><ins>+ if (m_pluginSize.isEmpty() || \
!needsBackingStore()) { </ins><span class="cx"> ShareableBitmap::Handle \
pluginBackingStoreHandle; </span><span class="cx"> \
m_connection->connection()->send(Messages::PluginControllerProxy::GeometryDidChange(m_frameRectInWindowCoordinates, \
m_clipRectInWindowCoordinates, contentsScaleFactor(), pluginBackingStoreHandle), \
m_pluginInstanceID, CoreIPC::DispatchMessageEvenWhenWaitingForSyncReply); \
</span><span class="cx"> return; </span><span class="lines">@@ -462,7 +462,7 \
@@ </span><span class="cx">
</span><span class="cx"> bool PluginProxy::updateBackingStore()
</span><span class="cx"> {
</span><del>- IntSize backingStoreSize = m_frameRectInWindowCoordinates.size();
</del><ins>+ IntSize backingStoreSize = m_pluginSize;
</ins><span class="cx"> backingStoreSize.scale(contentsScaleFactor());
</span><span class="cx">
</span><span class="cx"> if (!m_backingStore) {
</span><span class="lines">@@ -490,6 +490,11 @@
</span><span class="cx"> return windowNPObjectID;
</span><span class="cx"> }
</span><span class="cx">
</span><ins>+IntRect PluginProxy::pluginBounds()
+{
+ return IntRect(IntPoint(), m_pluginSize);
+}
+
</ins><span class="cx"> void PluginProxy::getPluginElementNPObject(uint64_t& \
pluginElementNPObjectID) </span><span class="cx"> {
</span><span class="cx"> NPObject* pluginElementNPObject = \
controller()->pluginElementNPObject(); </span></span></pre></div>
<a id="trunkSourceWebKit2WebProcessPluginsPluginProxyh"></a>
<div class="modfile"><h4>Modified: \
trunk/Source/WebKit2/WebProcess/Plugins/PluginProxy.h (98906 => 98907)</h4> <pre \
class="diff"><span> <span class="info">--- \
trunk/Source/WebKit2/WebProcess/Plugins/PluginProxy.h 2011-10-31 23:34:02 UTC (rev \
98906)
+++ trunk/Source/WebKit2/WebProcess/Plugins/PluginProxy.h 2011-10-31 23:38:27 UTC \
(rev 98907) </span><span class="lines">@@ -115,6 +115,7 @@
</span><span class="cx"> bool needsBackingStore() const;
</span><span class="cx"> bool updateBackingStore();
</span><span class="cx"> uint64_t windowNPObjectID();
</span><ins>+ WebCore::IntRect pluginBounds();
</ins><span class="cx">
</span><span class="cx"> void geometryDidChange();
</span><span class="cx">
</span></span></pre>
</div>
</div>
</body>
</html>
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic