[prev in list] [next in list] [prev in thread] [next in thread]
List: webkit-changes
Subject: [webkit-changes] [98900] trunk/Source/WebKit/chromium
From: commit-queue () webkit ! org
Date: 2011-10-31 23:09:39
Message-ID: 20111031230939.E3E64447CC6A () lists ! macosforge ! org
[Download RAW message or body]
[Attachment #2 (text/html)]
<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[98900] trunk/Source/WebKit/chromium</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: \
verdana,arial,helvetica,sans-serif; font-size: 10pt; } #msg dl a { font-weight: \
bold} #msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: \
bold; } #msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: \
6px; } #logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em \
0; } #logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg \
h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; } \
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; \
} #logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: \
-1.5em; padding-left: 1.5em; } #logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em \
1em 0 1em; background: white;} #logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid \
#fa0; border-bottom: 1px solid #fa0; background: #fff; } #logmsg table th { \
text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted \
#fa0; } #logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: \
0.2em 0.5em; } #logmsg table thead th { text-align: center; border-bottom: 1px solid \
#fa0; } #logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: \
6px; } #patch { width: 100%; }
#patch h4 {font-family: \
verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, \
#patch .copfile {border:1px solid #ccc;margin:10px 0;} #patch ins \
{background:#dfd;text-decoration:none;display:block;padding:0 10px;} #patch del \
{background:#fdd;text-decoration:none;display:block;padding:0 10px;} #patch .lines, \
.info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a \
href="http://trac.webkit.org/projects/webkit/changeset/98900">98900</a></dd> \
<dt>Author</dt> <dd>commit-queue@webkit.org</dd> <dt>Date</dt> <dd>2011-10-31 \
16:09:39 -0700 (Mon, 31 Oct 2011)</dd> </dl>
<h3>Log Message</h3>
<pre>IndexedDB: Remove null key support (part 2)
https://bugs.webkit.org/show_bug.cgi?id=71132
Patch by Joshua Bell <jsbell@chromium.org> on 2011-10-31
Reviewed by Darin Fisher.
* public/WebIDBKey.h:
* src/AssertMatchingEnums.cpp:
* src/WebIDBKey.cpp:</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkSourceWebKitchromiumChangeLog">trunk/Source/WebKit/chromium/ChangeLog</a></li>
<li><a href="#trunkSourceWebKitchromiumpublicWebIDBKeyh">trunk/Source/WebKit/chromium/public/WebIDBKey.h</a></li>
<li><a href="#trunkSourceWebKitchromiumsrcAssertMatchingEnumscpp">trunk/Source/WebKit/chromium/src/AssertMatchingEnums.cpp</a></li>
<li><a href="#trunkSourceWebKitchromiumsrcWebIDBKeycpp">trunk/Source/WebKit/chromium/src/WebIDBKey.cpp</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkSourceWebKitchromiumChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit/chromium/ChangeLog (98899 => \
98900)</h4> <pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit/chromium/ChangeLog 2011-10-31 23:09:12 UTC \
(rev 98899)
+++ trunk/Source/WebKit/chromium/ChangeLog 2011-10-31 23:09:39 UTC (rev 98900)
</span><span class="lines">@@ -1,3 +1,14 @@
</span><ins>+2011-10-31 Joshua Bell <jsbell@chromium.org>
+
+ IndexedDB: Remove null key support (part 2)
+ https://bugs.webkit.org/show_bug.cgi?id=71132
+
+ Reviewed by Darin Fisher.
+
+ * public/WebIDBKey.h:
+ * src/AssertMatchingEnums.cpp:
+ * src/WebIDBKey.cpp:
+
</ins><span class="cx"> 2011-10-31 Pavel Feldman <pfeldman@google.com>
</span><span class="cx">
</span><span class="cx"> Web Inspector: move localization support into \
UIUtil.js, reduce externs. </span></span></pre></div>
<a id="trunkSourceWebKitchromiumpublicWebIDBKeyh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit/chromium/public/WebIDBKey.h \
(98899 => 98900)</h4> <pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit/chromium/public/WebIDBKey.h 2011-10-31 \
23:09:12 UTC (rev 98899)
+++ trunk/Source/WebKit/chromium/public/WebIDBKey.h 2011-10-31 23:09:39 UTC (rev \
98900) </span><span class="lines">@@ -43,7 +43,6 @@
</span><span class="cx"> WebIDBKey() { }
</span><span class="cx"> ~WebIDBKey() { reset(); }
</span><span class="cx">
</span><del>- WEBKIT_EXPORT static WebIDBKey createNull();
</del><span class="cx"> WEBKIT_EXPORT static WebIDBKey createString(const \
WebString&); </span><span class="cx"> WEBKIT_EXPORT static WebIDBKey \
createDate(double); </span><span class="cx"> WEBKIT_EXPORT static WebIDBKey \
createNumber(double); </span><span class="lines">@@ -59,7 +58,6 @@
</span><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> WEBKIT_EXPORT void assign(const WebIDBKey&);
</span><del>- WEBKIT_EXPORT void assignNull();
</del><span class="cx"> WEBKIT_EXPORT void assignString(const WebString&);
</span><span class="cx"> WEBKIT_EXPORT void assignDate(double);
</span><span class="cx"> WEBKIT_EXPORT void assignNumber(double);
</span><span class="lines">@@ -67,12 +65,10 @@
</span><span class="cx"> WEBKIT_EXPORT void reset();
</span><span class="cx">
</span><span class="cx"> enum Type {
</span><del>- NullType = 0,
</del><ins>+ InvalidType = 0,
</ins><span class="cx"> StringType,
</span><span class="cx"> DateType,
</span><del>- NumberType,
- // Types not in WebCore::IDBKey:
- InvalidType
</del><ins>+ NumberType
</ins><span class="cx"> };
</span><span class="cx">
</span><span class="cx"> WEBKIT_EXPORT Type type() const;
</span></span></pre></div>
<a id="trunkSourceWebKitchromiumsrcAssertMatchingEnumscpp"></a>
<div class="modfile"><h4>Modified: \
trunk/Source/WebKit/chromium/src/AssertMatchingEnums.cpp (98899 => 98900)</h4> <pre \
class="diff"><span> <span class="info">--- \
trunk/Source/WebKit/chromium/src/AssertMatchingEnums.cpp 2011-10-31 23:09:12 UTC (rev \
98899)
+++ trunk/Source/WebKit/chromium/src/AssertMatchingEnums.cpp 2011-10-31 23:09:39 UTC \
(rev 98900) </span><span class="lines">@@ -396,9 +396,7 @@
</span><span class="cx"> \
COMPILE_ASSERT_MATCHING_ENUM(WebView::UserStyleInjectInExistingDocuments, \
InjectInExistingDocuments); </span><span class="cx"> \
COMPILE_ASSERT_MATCHING_ENUM(WebView::UserStyleInjectInSubsequentDocuments, \
InjectInSubsequentDocuments); </span><span class="cx">
</span><del>-// FIXME: Temporary; WebIDBKey::NullType will be removed in a subsequent \
patch.
-// https://bugs.webkit.org/show_bug.cgi?id=70065
-COMPILE_ASSERT_MATCHING_ENUM(WebIDBKey::NullType, IDBKey::InvalidType);
</del><ins>+COMPILE_ASSERT_MATCHING_ENUM(WebIDBKey::InvalidType, \
IDBKey::InvalidType); </ins><span class="cx"> \
COMPILE_ASSERT_MATCHING_ENUM(WebIDBKey::StringType, IDBKey::StringType); </span><span \
class="cx"> COMPILE_ASSERT_MATCHING_ENUM(WebIDBKey::DateType, IDBKey::DateType); \
</span><span class="cx"> COMPILE_ASSERT_MATCHING_ENUM(WebIDBKey::NumberType, \
IDBKey::NumberType); </span></span></pre></div>
<a id="trunkSourceWebKitchromiumsrcWebIDBKeycpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit/chromium/src/WebIDBKey.cpp \
(98899 => 98900)</h4> <pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit/chromium/src/WebIDBKey.cpp 2011-10-31 \
23:09:12 UTC (rev 98899)
+++ trunk/Source/WebKit/chromium/src/WebIDBKey.cpp 2011-10-31 23:09:39 UTC (rev \
98900) </span><span class="lines">@@ -41,13 +41,6 @@
</span><span class="cx">
</span><span class="cx"> namespace WebKit {
</span><span class="cx">
</span><del>-WebIDBKey WebIDBKey::createNull()
-{
- WebIDBKey key;
- key.assignNull();
- return key;
-}
-
</del><span class="cx"> WebIDBKey WebIDBKey::createString(const WebString& \
string) </span><span class="cx"> {
</span><span class="cx"> WebIDBKey key;
</span><span class="lines">@@ -93,11 +86,6 @@
</span><span class="cx"> m_private = value.m_private;
</span><span class="cx"> }
</span><span class="cx">
</span><del>-void WebIDBKey::assignNull()
-{
- m_private = 0;
-}
-
</del><span class="cx"> void WebIDBKey::assignString(const WebString& string)
</span><span class="cx"> {
</span><span class="cx"> m_private = IDBKey::createString(string);
</span></span></pre>
</div>
</div>
</body>
</html>
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic