[prev in list] [next in list] [prev in thread] [next in thread] 

List:       webkit-changes
Subject:    [webkit-changes] [98890] trunk/Source/WebKit/efl
From:       commit-queue () webkit ! org
Date:       2011-10-31 22:31:18
Message-ID: 20111031223118.9A360447B2B9 () lists ! macosforge ! org
[Download RAW message or body]

[Attachment #2 (text/html)]

<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[98890] trunk/Source/WebKit/efl</title>
</head>
<body>

<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: \
verdana,arial,helvetica,sans-serif; font-size: 10pt;  } #msg dl a { font-weight: \
bold} #msg dl a:link    { color:#fc3; }
#msg dl a:active  { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: \
bold; } #msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: \
6px; } #logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em \
0; } #logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg \
h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; } \
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; \
} #logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: \
-1.5em; padding-left: 1.5em; } #logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em \
1em 0 1em; background: white;} #logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid \
#fa0; border-bottom: 1px solid #fa0; background: #fff; } #logmsg table th { \
text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted \
#fa0; } #logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: \
0.2em 0.5em; } #logmsg table thead th { text-align: center; border-bottom: 1px solid \
#fa0; } #logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: \
6px; } #patch { width: 100%; }
#patch h4 {font-family: \
verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
 #patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff  {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, \
#patch .copfile {border:1px solid #ccc;margin:10px 0;} #patch ins \
{background:#dfd;text-decoration:none;display:block;padding:0 10px;} #patch del \
{background:#fdd;text-decoration:none;display:block;padding:0 10px;} #patch .lines, \
                .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a \
href="http://trac.webkit.org/projects/webkit/changeset/98890">98890</a></dd> \
<dt>Author</dt> <dd>commit-queue@webkit.org</dd> <dt>Date</dt> <dd>2011-10-31 \
15:31:16 -0700 (Mon, 31 Oct 2011)</dd> </dl>

<h3>Log Message</h3>
<pre>[EFL] Make cache flush when max size of cache has been changed
https://bugs.webkit.org/show_bug.cgi?id=70805

Patch by Tomasz Morawski &lt;t.morawski@samsung.com&gt; on 2011-10-31
Reviewed by Ryosuke Niwa.

Calls the ewk_tile_unused_cache_auto_flush function after changing max
size of cache when ewk_tile_unused_cache_max_set is called. Without
this change when new value is lower than the old one the cache may use
more memory than max value set. This situation is not expected by the
user.

* ewk/ewk_tiled_model.cpp:
(ewk_tile_unused_cache_max_set):</pre>

<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkSourceWebKiteflChangeLog">trunk/Source/WebKit/efl/ChangeLog</a></li>
 <li><a href="#trunkSourceWebKiteflewkewk_tiled_modelcpp">trunk/Source/WebKit/efl/ewk/ewk_tiled_model.cpp</a></li>
 </ul>

</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkSourceWebKiteflChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit/efl/ChangeLog (98889 => \
98890)</h4> <pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit/efl/ChangeLog	2011-10-31 22:24:20 UTC (rev \
                98889)
+++ trunk/Source/WebKit/efl/ChangeLog	2011-10-31 22:31:16 UTC (rev 98890)
</span><span class="lines">@@ -1,3 +1,19 @@
</span><ins>+2011-10-31  Tomasz Morawski  &lt;t.morawski@samsung.com&gt;
+
+        [EFL] Make cache flush when max size of cache has been changed
+        https://bugs.webkit.org/show_bug.cgi?id=70805
+
+        Reviewed by Ryosuke Niwa.
+
+        Calls the ewk_tile_unused_cache_auto_flush function after changing max
+        size of cache when ewk_tile_unused_cache_max_set is called. Without
+        this change when new value is lower than the old one the cache may use
+        more memory than max value set. This situation is not expected by the
+        user.
+
+        * ewk/ewk_tiled_model.cpp:
+        (ewk_tile_unused_cache_max_set):
+
</ins><span class="cx"> 2011-10-28  Jochen Eisinger  &lt;jochen@chromium.org&gt;
</span><span class="cx"> 
</span><span class="cx">         Rename a number of methods mentioning JavaScript to \
just Script instead </span></span></pre></div>
<a id="trunkSourceWebKiteflewkewk_tiled_modelcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit/efl/ewk/ewk_tiled_model.cpp \
(98889 => 98890)</h4> <pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit/efl/ewk/ewk_tiled_model.cpp	2011-10-31 \
                22:24:20 UTC (rev 98889)
+++ trunk/Source/WebKit/efl/ewk/ewk_tiled_model.cpp	2011-10-31 22:31:16 UTC (rev \
98890) </span><span class="lines">@@ -633,7 +633,11 @@
</span><span class="cx"> void ewk_tile_unused_cache_max_set(Ewk_Tile_Unused_Cache* \
tileUnusedCache, size_t max) </span><span class="cx"> {
</span><span class="cx">     EINA_SAFETY_ON_NULL_RETURN(tileUnusedCache);
</span><ins>+    size_t oldMax = tileUnusedCache-&gt;memory.max;
</ins><span class="cx">     tileUnusedCache-&gt;memory.max = max;
</span><ins>+    /* Cache flush when new max is lower then old one */
+    if (oldMax &gt; max)
+        ewk_tile_unused_cache_auto_flush(tileUnusedCache);
</ins><span class="cx"> }
</span><span class="cx"> 
</span><span class="cx"> size_t ewk_tile_unused_cache_max_get(const \
Ewk_Tile_Unused_Cache* tileUnusedCache) </span></span></pre>
</div>
</div>

</body>
</html>



_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes


[prev in list] [next in list] [prev in thread] [next in thread] 

Configure | About | News | Add a list | Sponsored by KoreLogic