[prev in list] [next in list] [prev in thread] [next in thread]
List: webkit-changes
Subject: [webkit-changes] [75249] trunk/WebCore
From: zmo () google ! com
Date: 2011-01-07 17:32:08
Message-ID: 20110107173209.325FB62638AF () beta ! macosforge ! org
[Download RAW message or body]
[Attachment #2 (text/html)]
<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[75249] trunk/WebCore</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: \
verdana,arial,helvetica,sans-serif; font-size: 10pt; } #msg dl a { font-weight: \
bold} #msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: \
bold; } #msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: \
6px; } #logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em \
0; } #logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg \
h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; } \
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; \
} #logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: \
-1.5em; padding-left: 1.5em; } #logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em \
1em 0 1em; background: white;} #logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid \
#fa0; border-bottom: 1px solid #fa0; background: #fff; } #logmsg table th { \
text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted \
#fa0; } #logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: \
0.2em 0.5em; } #logmsg table thead th { text-align: center; border-bottom: 1px solid \
#fa0; } #logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: \
6px; } #patch { width: 100%; }
#patch h4 {font-family: \
verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, \
#patch .copfile {border:1px solid #ccc;margin:10px 0;} #patch ins \
{background:#dfd;text-decoration:none;display:block;padding:0 10px;} #patch del \
{background:#fdd;text-decoration:none;display:block;padding:0 10px;} #patch .lines, \
.info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a \
href="http://trac.webkit.org/projects/webkit/changeset/75249">75249</a></dd> \
<dt>Author</dt> <dd>zmo@google.com</dd> <dt>Date</dt> <dd>2011-01-07 09:32:02 -0800 \
(Fri, 07 Jan 2011)</dd> </dl>
<h3>Log Message</h3>
<pre>2011-01-07 Zhenyao Mo <zmo@google.com>
Unreviewed, Mac 32-bit build fix.
Use float instead of double in GL function arguments to avoid implicit type \
down casting.
* html/canvas/WebGLRenderingContext.cpp:
(WebCore::WebGLRenderingContext::blendColor):
(WebCore::WebGLRenderingContext::clearColor):
(WebCore::WebGLRenderingContext::clearDepth):
(WebCore::WebGLRenderingContext::depthRange):
(WebCore::WebGLRenderingContext::lineWidth):
(WebCore::WebGLRenderingContext::polygonOffset):
(WebCore::WebGLRenderingContext::sampleCoverage):
* html/canvas/WebGLRenderingContext.h:
* html/canvas/WebGLRenderingContext.idl:</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkWebCoreChangeLog">trunk/WebCore/ChangeLog</a></li>
<li><a href="#trunkWebCorehtmlcanvasWebGLRenderingContextcpp">trunk/WebCore/html/canvas/WebGLRenderingContext.cpp</a></li>
<li><a href="#trunkWebCorehtmlcanvasWebGLRenderingContexth">trunk/WebCore/html/canvas/WebGLRenderingContext.h</a></li>
<li><a href="#trunkWebCorehtmlcanvasWebGLRenderingContextidl">trunk/WebCore/html/canvas/WebGLRenderingContext.idl</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/WebCore/ChangeLog (75248 => 75249)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/WebCore/ChangeLog 2011-01-07 17:26:16 UTC (rev 75248)
+++ trunk/WebCore/ChangeLog 2011-01-07 17:32:02 UTC (rev 75249)
</span><span class="lines">@@ -1,3 +1,19 @@
</span><ins>+2011-01-07 Zhenyao Mo <zmo@google.com>
+
+ Unreviewed, Mac 32-bit build fix.
+ Use float instead of double in GL function arguments to avoid implicit type \
down casting. +
+ * html/canvas/WebGLRenderingContext.cpp:
+ (WebCore::WebGLRenderingContext::blendColor):
+ (WebCore::WebGLRenderingContext::clearColor):
+ (WebCore::WebGLRenderingContext::clearDepth):
+ (WebCore::WebGLRenderingContext::depthRange):
+ (WebCore::WebGLRenderingContext::lineWidth):
+ (WebCore::WebGLRenderingContext::polygonOffset):
+ (WebCore::WebGLRenderingContext::sampleCoverage):
+ * html/canvas/WebGLRenderingContext.h:
+ * html/canvas/WebGLRenderingContext.idl:
+
</ins><span class="cx"> 2011-01-07 Carlos Garcia Campos <cgarcia@igalia.com> \
and Martin Robinson <mrobinson@igalia.com> </span><span class="cx">
</span><span class="cx"> Reviewed by Xan Lopez.
</span></span></pre></div>
<a id="trunkWebCorehtmlcanvasWebGLRenderingContextcpp"></a>
<div class="modfile"><h4>Modified: \
trunk/WebCore/html/canvas/WebGLRenderingContext.cpp (75248 => 75249)</h4> <pre \
class="diff"><span> <span class="info">--- \
trunk/WebCore/html/canvas/WebGLRenderingContext.cpp 2011-01-07 17:26:16 UTC (rev \
75248)
+++ trunk/WebCore/html/canvas/WebGLRenderingContext.cpp 2011-01-07 17:32:02 UTC (rev \
75249) </span><span class="lines">@@ -438,7 +438,7 @@
</span><span class="cx"> cleanupAfterGraphicsCall(false);
</span><span class="cx"> }
</span><span class="cx">
</span><del>-void WebGLRenderingContext::blendColor(double red, double green, double \
blue, double alpha) </del><ins>+void WebGLRenderingContext::blendColor(float red, \
float green, float blue, float alpha) </ins><span class="cx"> {
</span><span class="cx"> if (isContextLost())
</span><span class="cx"> return;
</span><span class="lines">@@ -618,7 +618,7 @@
</span><span class="cx"> cleanupAfterGraphicsCall(true);
</span><span class="cx"> }
</span><span class="cx">
</span><del>-void WebGLRenderingContext::clearColor(double r, double g, double b, \
double a) </del><ins>+void WebGLRenderingContext::clearColor(float r, float g, float \
b, float a) </ins><span class="cx"> {
</span><span class="cx"> if (isContextLost())
</span><span class="cx"> return;
</span><span class="lines">@@ -634,7 +634,7 @@
</span><span class="cx"> cleanupAfterGraphicsCall(false);
</span><span class="cx"> }
</span><span class="cx">
</span><del>-void WebGLRenderingContext::clearDepth(double depth)
</del><ins>+void WebGLRenderingContext::clearDepth(float depth)
</ins><span class="cx"> {
</span><span class="cx"> if (isContextLost())
</span><span class="cx"> return;
</span><span class="lines">@@ -890,7 +890,7 @@
</span><span class="cx"> cleanupAfterGraphicsCall(false);
</span><span class="cx"> }
</span><span class="cx">
</span><del>-void WebGLRenderingContext::depthRange(double zNear, double zFar)
</del><ins>+void WebGLRenderingContext::depthRange(float zNear, float zFar)
</ins><span class="cx"> {
</span><span class="cx"> if (isContextLost())
</span><span class="cx"> return;
</span><span class="lines">@@ -2264,7 +2264,7 @@
</span><span class="cx"> return m_context->isTexture(texture->object());
</span><span class="cx"> }
</span><span class="cx">
</span><del>-void WebGLRenderingContext::lineWidth(double width)
</del><ins>+void WebGLRenderingContext::lineWidth(float width)
</ins><span class="cx"> {
</span><span class="cx"> if (isContextLost())
</span><span class="cx"> return;
</span><span class="lines">@@ -2334,7 +2334,7 @@
</span><span class="cx"> }
</span><span class="cx"> }
</span><span class="cx">
</span><del>-void WebGLRenderingContext::polygonOffset(double factor, double units)
</del><ins>+void WebGLRenderingContext::polygonOffset(float factor, float units)
</ins><span class="cx"> {
</span><span class="cx"> if (isContextLost())
</span><span class="cx"> return;
</span><span class="lines">@@ -2467,7 +2467,7 @@
</span><span class="cx"> }
</span><span class="cx"> }
</span><span class="cx">
</span><del>-void WebGLRenderingContext::sampleCoverage(double value, bool invert)
</del><ins>+void WebGLRenderingContext::sampleCoverage(float value, bool invert)
</ins><span class="cx"> {
</span><span class="cx"> if (isContextLost())
</span><span class="cx"> return;
</span></span></pre></div>
<a id="trunkWebCorehtmlcanvasWebGLRenderingContexth"></a>
<div class="modfile"><h4>Modified: trunk/WebCore/html/canvas/WebGLRenderingContext.h \
(75248 => 75249)</h4> <pre class="diff"><span>
<span class="info">--- trunk/WebCore/html/canvas/WebGLRenderingContext.h 2011-01-07 \
17:26:16 UTC (rev 75248)
+++ trunk/WebCore/html/canvas/WebGLRenderingContext.h 2011-01-07 17:32:02 UTC (rev \
75249) </span><span class="lines">@@ -74,7 +74,7 @@
</span><span class="cx"> void bindFramebuffer(unsigned long target, \
WebGLFramebuffer*, ExceptionCode& ec); </span><span class="cx"> void \
bindRenderbuffer(unsigned long target, WebGLRenderbuffer*, ExceptionCode& ec); \
</span><span class="cx"> void bindTexture(unsigned long target, WebGLTexture*, \
ExceptionCode& ec); </span><del>- void blendColor(double red, double green, \
double blue, double alpha); </del><ins>+ void blendColor(float red, float green, \
float blue, float alpha); </ins><span class="cx"> void blendEquation(unsigned \
long mode); </span><span class="cx"> void blendEquationSeparate(unsigned long \
modeRGB, unsigned long modeAlpha); </span><span class="cx"> void \
blendFunc(unsigned long sfactor, unsigned long dfactor); </span><span \
class="lines">@@ -88,8 +88,8 @@ </span><span class="cx">
</span><span class="cx"> unsigned long checkFramebufferStatus(unsigned long \
target); </span><span class="cx"> void clear(unsigned long mask);
</span><del>- void clearColor(double red, double green, double blue, double \
alpha);
- void clearDepth(double);
</del><ins>+ void clearColor(float red, float green, float blue, float alpha);
+ void clearDepth(float);
</ins><span class="cx"> void clearStencil(long);
</span><span class="cx"> void colorMask(bool red, bool green, bool blue, bool \
alpha); </span><span class="cx"> void compileShader(WebGLShader*, \
ExceptionCode& ec); </span><span class="lines">@@ -118,7 +118,7 @@
</span><span class="cx">
</span><span class="cx"> void depthFunc(unsigned long);
</span><span class="cx"> void depthMask(bool);
</span><del>- void depthRange(double zNear, double zFar);
</del><ins>+ void depthRange(float zNear, float zFar);
</ins><span class="cx"> void detachShader(WebGLProgram*, WebGLShader*, \
ExceptionCode&); </span><span class="cx"> void disable(unsigned long cap);
</span><span class="cx"> void disableVertexAttribArray(unsigned long index, \
ExceptionCode&); </span><span class="lines">@@ -189,14 +189,14 @@
</span><span class="cx"> bool isRenderbuffer(WebGLRenderbuffer*);
</span><span class="cx"> bool isShader(WebGLShader*);
</span><span class="cx"> bool isTexture(WebGLTexture*);
</span><del>- void lineWidth(double);
</del><ins>+ void lineWidth(float);
</ins><span class="cx"> void linkProgram(WebGLProgram*, ExceptionCode&);
</span><span class="cx"> void pixelStorei(unsigned long pname, long param);
</span><del>- void polygonOffset(double factor, double units);
</del><ins>+ void polygonOffset(float factor, float units);
</ins><span class="cx"> void readPixels(long x, long y, long width, long height, \
unsigned long format, unsigned long type, ArrayBufferView* pixels, \
ExceptionCode&); </span><span class="cx"> void releaseShaderCompiler();
</span><span class="cx"> void renderbufferStorage(unsigned long target, unsigned \
long internalformat, long width, long height); </span><del>- void \
sampleCoverage(double value, bool invert); </del><ins>+ void sampleCoverage(float \
value, bool invert); </ins><span class="cx"> void scissor(long x, long y, long \
width, long height); </span><span class="cx"> void shaderSource(WebGLShader*, \
const String&, ExceptionCode&); </span><span class="cx"> void \
stencilFunc(unsigned long func, long ref, unsigned long mask); \
</span></span></pre></div> <a \
id="trunkWebCorehtmlcanvasWebGLRenderingContextidl"></a> <div \
class="modfile"><h4>Modified: trunk/WebCore/html/canvas/WebGLRenderingContext.idl \
(75248 => 75249)</h4> <pre class="diff"><span>
<span class="info">--- trunk/WebCore/html/canvas/WebGLRenderingContext.idl 2011-01-07 \
17:26:16 UTC (rev 75248)
+++ trunk/WebCore/html/canvas/WebGLRenderingContext.idl 2011-01-07 17:32:02 UTC (rev \
75249) </span><span class="lines">@@ -461,7 +461,7 @@
</span><span class="cx"> [StrictTypeChecking] void bindFramebuffer(in \
unsigned long target, in WebGLFramebuffer framebuffer) raises(DOMException); \
</span><span class="cx"> [StrictTypeChecking] void \
bindRenderbuffer(in unsigned long target, in WebGLRenderbuffer renderbuffer) \
raises(DOMException); </span><span class="cx"> [StrictTypeChecking] void \
bindTexture(in unsigned long target, in WebGLTexture texture) raises(DOMException); \
</span><del>- [StrictTypeChecking] void blendColor(in double red, in \
double green, in double blue, in double alpha); </del><ins>+ \
[StrictTypeChecking] void blendColor(in float red, in float green, in float \
blue, in float alpha); </ins><span class="cx"> [StrictTypeChecking] void \
blendEquation( in unsigned long mode ); </span><span class="cx"> \
[StrictTypeChecking] void blendEquationSeparate(in unsigned long modeRGB, in \
unsigned long modeAlpha); </span><span class="cx"> [StrictTypeChecking] void \
blendFunc(in unsigned long sfactor, in unsigned long dfactor); </span><span \
class="lines">@@ -474,8 +474,8 @@ </span><span class="cx">
</span><span class="cx"> [StrictTypeChecking] unsigned long \
checkFramebufferStatus(in unsigned long target); </span><span class="cx"> \
[StrictTypeChecking] void clear(in unsigned long mask); </span><del>- \
[StrictTypeChecking] void clearColor(in double red, in double green, in \
double blue, in double alpha);
- [StrictTypeChecking] void clearDepth(in double depth);
</del><ins>+ [StrictTypeChecking] void clearColor(in float red, in \
float green, in float blue, in float alpha); + [StrictTypeChecking] void \
clearDepth(in float depth); </ins><span class="cx"> [StrictTypeChecking] void \
clearStencil(in long s); </span><span class="cx"> [StrictTypeChecking] void \
colorMask(in boolean red, in boolean green, in boolean blue, in boolean alpha); \
</span><span class="cx"> [StrictTypeChecking] void compileShader(in \
WebGLShader shader) raises(DOMException); </span><span class="lines">@@ -505,7 +505,7 \
@@ </span><span class="cx"> [StrictTypeChecking] void depthFunc(in \
unsigned long func); </span><span class="cx"> [StrictTypeChecking] void \
depthMask(in boolean flag); </span><span class="cx"> // FIXME: this differs \
from the current WebGL spec (depthRangef) </span><del>- [StrictTypeChecking] \
void depthRange(in double zNear, in double zFar); </del><ins>+ \
[StrictTypeChecking] void depthRange(in float zNear, in float zFar); \
</ins><span class="cx"> [StrictTypeChecking] void detachShader(in \
WebGLProgram program, in WebGLShader shader) raises(DOMException); </span><span \
class="cx"> [StrictTypeChecking] void disable(in unsigned long cap); \
</span><span class="cx"> [StrictTypeChecking] void \
disableVertexAttribArray(in unsigned long index) raises(DOMException); </span><span \
class="lines">@@ -582,16 +582,16 @@ </span><span class="cx"> \
[StrictTypeChecking] boolean isRenderbuffer(in WebGLRenderbuffer renderbuffer); \
</span><span class="cx"> [StrictTypeChecking] boolean isShader(in \
WebGLShader shader); </span><span class="cx"> [StrictTypeChecking] boolean \
isTexture(in WebGLTexture texture); </span><del>- [StrictTypeChecking] void \
lineWidth(in double width); </del><ins>+ [StrictTypeChecking] void \
lineWidth(in float width); </ins><span class="cx"> [StrictTypeChecking] void \
linkProgram(in WebGLProgram program) raises(DOMException); </span><span class="cx"> \
[StrictTypeChecking] void pixelStorei(in unsigned long pname, in long param); \
</span><del>- [StrictTypeChecking] void polygonOffset(in double \
factor, in double units); </del><ins>+ [StrictTypeChecking] void \
polygonOffset(in float factor, in float units); </ins><span class="cx">
</span><span class="cx"> [StrictTypeChecking] void readPixels(in long \
x, in long y, in long width, in long height, in unsigned long format, in unsigned \
long type, in ArrayBufferView pixels) raises(DOMException); </span><span class="cx"> \
</span><span class="cx"> [StrictTypeChecking] void \
releaseShaderCompiler(); </span><span class="cx"> [StrictTypeChecking] void \
renderbufferStorage(in unsigned long target, in unsigned long internalformat, in long \
width, in long height); </span><del>- [StrictTypeChecking] void \
sampleCoverage(in double value, in boolean invert); </del><ins>+ \
[StrictTypeChecking] void sampleCoverage(in float value, in boolean invert); \
</ins><span class="cx"> [StrictTypeChecking] void scissor(in long x, \
in long y, in long width, in long height); </span><span class="cx"> \
[StrictTypeChecking] void shaderSource(in WebGLShader shader, in DOMString \
string) raises(DOMException); </span><span class="cx"> [StrictTypeChecking] \
void stencilFunc(in unsigned long func, in long ref, in unsigned long mask); \
</span></span></pre> </div>
</div>
</body>
</html>
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic