[prev in list] [next in list] [prev in thread] [next in thread] 

List:       webkit-changes
Subject:    [webkit-changes] [75182] trunk/WebCore
From:       aroben () apple ! com
Date:       2011-01-06 20:46:54
Message-ID: 20110106204655.293C06252BC3 () beta ! macosforge ! org
[Download RAW message or body]

[Attachment #2 (text/html)]

<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[75182] trunk/WebCore</title>
</head>
<body>

<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: \
verdana,arial,helvetica,sans-serif; font-size: 10pt;  } #msg dl a { font-weight: \
bold} #msg dl a:link    { color:#fc3; }
#msg dl a:active  { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: \
bold; } #msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: \
6px; } #logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em \
0; } #logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg \
h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; } \
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; \
} #logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: \
-1.5em; padding-left: 1.5em; } #logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em \
1em 0 1em; background: white;} #logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid \
#fa0; border-bottom: 1px solid #fa0; background: #fff; } #logmsg table th { \
text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted \
#fa0; } #logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: \
0.2em 0.5em; } #logmsg table thead th { text-align: center; border-bottom: 1px solid \
#fa0; } #logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: \
6px; } #patch { width: 100%; }
#patch h4 {font-family: \
verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
 #patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff  {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, \
#patch .copfile {border:1px solid #ccc;margin:10px 0;} #patch ins \
{background:#dfd;text-decoration:none;display:block;padding:0 10px;} #patch del \
{background:#fdd;text-decoration:none;display:block;padding:0 10px;} #patch .lines, \
                .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a \
href="http://trac.webkit.org/projects/webkit/changeset/75182">75182</a></dd> \
<dt>Author</dt> <dd>aroben@apple.com</dd> <dt>Date</dt> <dd>2011-01-06 12:46:49 -0800 \
(Thu, 06 Jan 2011)</dd> </dl>

<h3>Log Message</h3>
<pre>Remove some dead code from WKCACFLayerRenderer

Fixes &lt;http://webkit.org/b/51954&gt; WKCACFLayerRenderer has dead and
redundant code for reacting to changes to the layer tree

Reviewed by Sam Weinig.

* platform/graphics/win/WKCACFLayerRenderer.cpp:
* platform/graphics/win/WKCACFLayerRenderer.h:
Removed didFlushContext and the HashMap it depended on. We react to
changes to the layer tree in layerTreeDidChange instead.</pre>

<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkWebCoreChangeLog">trunk/WebCore/ChangeLog</a></li>
<li><a href="#trunkWebCoreplatformgraphicswinWKCACFLayerRenderercpp">trunk/WebCore/platform/graphics/win/WKCACFLayerRenderer.cpp</a></li>
 <li><a href="#trunkWebCoreplatformgraphicswinWKCACFLayerRendererh">trunk/WebCore/platform/graphics/win/WKCACFLayerRenderer.h</a></li>
 </ul>

</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/WebCore/ChangeLog (75181 => 75182)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/WebCore/ChangeLog	2011-01-06 20:44:24 UTC (rev 75181)
+++ trunk/WebCore/ChangeLog	2011-01-06 20:46:49 UTC (rev 75182)
</span><span class="lines">@@ -1,3 +1,17 @@
</span><ins>+2011-01-05  Adam Roben  &lt;aroben@apple.com&gt;
+
+        Remove some dead code from WKCACFLayerRenderer
+
+        Fixes &lt;http://webkit.org/b/51954&gt; WKCACFLayerRenderer has dead and
+        redundant code for reacting to changes to the layer tree
+
+        Reviewed by Sam Weinig.
+
+        * platform/graphics/win/WKCACFLayerRenderer.cpp:
+        * platform/graphics/win/WKCACFLayerRenderer.h:
+        Removed didFlushContext and the HashMap it depended on. We react to
+        changes to the layer tree in layerTreeDidChange instead.
+
</ins><span class="cx"> 2011-01-06  Chris Fleizach  &lt;cfleizach@apple.com&gt;
</span><span class="cx"> 
</span><span class="cx">         Reviewed by Beth Dakin.
</span></span></pre></div>
<a id="trunkWebCoreplatformgraphicswinWKCACFLayerRenderercpp"></a>
<div class="modfile"><h4>Modified: \
trunk/WebCore/platform/graphics/win/WKCACFLayerRenderer.cpp (75181 => 75182)</h4> \
<pre class="diff"><span> <span class="info">--- \
trunk/WebCore/platform/graphics/win/WKCACFLayerRenderer.cpp	2011-01-06 20:44:24 UTC \
                (rev 75181)
+++ trunk/WebCore/platform/graphics/win/WKCACFLayerRenderer.cpp	2011-01-06 20:46:49 \
UTC (rev 75182) </span><span class="lines">@@ -106,14 +106,6 @@
</span><span class="cx">     WKCACFLayerRenderer* m_renderer;
</span><span class="cx"> };
</span><span class="cx"> 
</span><del>-typedef HashMap&lt;WKCACFContext*, WKCACFLayerRenderer*&gt; \
                ContextToWindowMap;
-
-static ContextToWindowMap&amp; windowsForContexts()
-{
-    DEFINE_STATIC_LOCAL(ContextToWindowMap, map, ());
-    return map;
-}
-
</del><span class="cx"> static D3DPRESENT_PARAMETERS initialPresentationParameters()
</span><span class="cx"> {
</span><span class="cx">     D3DPRESENT_PARAMETERS parameters = {0};
</span><span class="lines">@@ -204,15 +196,6 @@
</span><span class="cx">     return available;
</span><span class="cx"> }
</span><span class="cx"> 
</span><del>-void WKCACFLayerRenderer::didFlushContext(WKCACFContext* context)
-{
-    WKCACFLayerRenderer* window = windowsForContexts().get(context);
-    if (!window)
-        return;
-
-    window-&gt;renderSoon();
-}
-
</del><span class="cx"> PassOwnPtr&lt;WKCACFLayerRenderer&gt; \
WKCACFLayerRenderer::create(WKCACFLayerRendererClient* client) </span><span \
class="cx"> { </span><span class="cx">     if (!acceleratedCompositingAvailable())
</span><span class="lines">@@ -230,8 +213,6 @@
</span><span class="cx">     , m_backingStoreDirty(false)
</span><span class="cx">     , m_mustResetLostDeviceBeforeRendering(false)
</span><span class="cx"> {
</span><del>-    windowsForContexts().set(m_context, this);
-
</del><span class="cx">     // Under the root layer, we have a clipping layer to clip \
the content, </span><span class="cx">     // that contains a scroll layer that we use \
for scrolling the content. </span><span class="cx">     // The root layer is the size \
of the client area of the window. </span><span class="lines">@@ -380,10 +361,8 @@
</span><span class="cx"> 
</span><span class="cx"> void WKCACFLayerRenderer::destroyRenderer()
</span><span class="cx"> {
</span><del>-    if (m_context) {
-        windowsForContexts().remove(m_context);
</del><ins>+    if (m_context)
</ins><span class="cx">         \
WKCACFContextFlusher::shared().removeContext(m_context); </span><del>-    }
</del><span class="cx"> 
</span><span class="cx">     m_d3dDevice = 0;
</span><span class="cx">     if (s_d3d)
</span></span></pre></div>
<a id="trunkWebCoreplatformgraphicswinWKCACFLayerRendererh"></a>
<div class="modfile"><h4>Modified: \
trunk/WebCore/platform/graphics/win/WKCACFLayerRenderer.h (75181 => 75182)</h4> <pre \
class="diff"><span> <span class="info">--- \
trunk/WebCore/platform/graphics/win/WKCACFLayerRenderer.h	2011-01-06 20:44:24 UTC \
                (rev 75181)
+++ trunk/WebCore/platform/graphics/win/WKCACFLayerRenderer.h	2011-01-06 20:46:49 UTC \
(rev 75182) </span><span class="lines">@@ -62,7 +62,6 @@
</span><span class="cx">     ~WKCACFLayerRenderer();
</span><span class="cx"> 
</span><span class="cx">     static bool acceleratedCompositingAvailable();
</span><del>-    static void didFlushContext(WKCACFContext*);
</del><span class="cx"> 
</span><span class="cx">     void setRootContents(CGImageRef);
</span><span class="cx">     void setRootContentsAndDisplay(CGImageRef);
</span></span></pre>
</div>
</div>

</body>
</html>



_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes


[prev in list] [next in list] [prev in thread] [next in thread]

Configure | About | News | Add a list | Sponsored by KoreLogic