[prev in list] [next in list] [prev in thread] [next in thread]
List: webkit-changes
Subject: [webkit-changes] [74684] trunk/WebKit/efl
From: commit-queue () webkit ! org
Date: 2010-12-27 17:10:50
Message-ID: 20101227171051.48D876138182 () beta ! macosforge ! org
[Download RAW message or body]
[Attachment #2 (text/html)]
<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[74684] trunk/WebKit/efl</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: \
verdana,arial,helvetica,sans-serif; font-size: 10pt; } #msg dl a { font-weight: \
bold} #msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: \
bold; } #msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: \
6px; } #logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em \
0; } #logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg \
h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; } \
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; \
} #logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: \
-1.5em; padding-left: 1.5em; } #logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em \
1em 0 1em; background: white;} #logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid \
#fa0; border-bottom: 1px solid #fa0; background: #fff; } #logmsg table th { \
text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted \
#fa0; } #logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: \
0.2em 0.5em; } #logmsg table thead th { text-align: center; border-bottom: 1px solid \
#fa0; } #logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: \
6px; } #patch { width: 100%; }
#patch h4 {font-family: \
verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, \
#patch .copfile {border:1px solid #ccc;margin:10px 0;} #patch ins \
{background:#dfd;text-decoration:none;display:block;padding:0 10px;} #patch del \
{background:#fdd;text-decoration:none;display:block;padding:0 10px;} #patch .lines, \
.info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a \
href="http://trac.webkit.org/projects/webkit/changeset/74684">74684</a></dd> \
<dt>Author</dt> <dd>commit-queue@webkit.org</dd> <dt>Date</dt> <dd>2010-12-27 \
09:10:42 -0800 (Mon, 27 Dec 2010)</dd> </dl>
<h3>Log Message</h3>
<pre>2010-12-27 Rafael Antognolli <antognolli@profusion.mobi>
Reviewed by Kenneth Rohde Christiansen.
[EFL] Set the frame smart object base clipper to non-static.
https://bugs.webkit.org/show_bug.cgi?id=51552
The base clipper of the clipped smart object, which is the parent
class of the ewk_frame class is a static clipper. It's normally only
used for showing/hiding the object, but in the case of the ewk_frame,
it needs to clip the object to its dimension, in order to clip
scrollbars of inner frames.
Setting it to non-static makes the clipper to be automatically moved
by the parent class, thus staying on the correct position when the
frame is moved.
This change needed to be done after the adoption of the static clipper
on the clipped smart base class.
* ewk/ewk_frame.cpp:
(_ewk_frame_smart_add):</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkWebKiteflChangeLog">trunk/WebKit/efl/ChangeLog</a></li>
<li><a href="#trunkWebKiteflewkewk_framecpp">trunk/WebKit/efl/ewk/ewk_frame.cpp</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkWebKiteflChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/WebKit/efl/ChangeLog (74683 => 74684)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/WebKit/efl/ChangeLog 2010-12-27 14:51:09 UTC (rev 74683)
+++ trunk/WebKit/efl/ChangeLog 2010-12-27 17:10:42 UTC (rev 74684)
</span><span class="lines">@@ -1,3 +1,26 @@
</span><ins>+2010-12-27 Rafael Antognolli <antognolli@profusion.mobi>
+
+ Reviewed by Kenneth Rohde Christiansen.
+
+ [EFL] Set the frame smart object base clipper to non-static.
+ https://bugs.webkit.org/show_bug.cgi?id=51552
+
+ The base clipper of the clipped smart object, which is the parent
+ class of the ewk_frame class is a static clipper. It's normally only
+ used for showing/hiding the object, but in the case of the ewk_frame,
+ it needs to clip the object to its dimension, in order to clip
+ scrollbars of inner frames.
+
+ Setting it to non-static makes the clipper to be automatically moved
+ by the parent class, thus staying on the correct position when the
+ frame is moved.
+
+ This change needed to be done after the adoption of the static clipper
+ on the clipped smart base class.
+
+ * ewk/ewk_frame.cpp:
+ (_ewk_frame_smart_add):
+
</ins><span class="cx"> 2010-12-24 Ryuan Choi <ryuan.choi@samsung.com>
</span><span class="cx">
</span><span class="cx"> Reviewed by Kenneth Rohde Christiansen.
</span></span></pre></div>
<a id="trunkWebKiteflewkewk_framecpp"></a>
<div class="modfile"><h4>Modified: trunk/WebKit/efl/ewk/ewk_frame.cpp (74683 => \
74684)</h4> <pre class="diff"><span>
<span class="info">--- trunk/WebKit/efl/ewk/ewk_frame.cpp 2010-12-27 14:51:09 UTC \
(rev 74683)
+++ trunk/WebKit/efl/ewk/ewk_frame.cpp 2010-12-27 17:10:42 UTC (rev 74684)
</span><span class="lines">@@ -192,6 +192,7 @@
</span><span class="cx"> sd->self = o;
</span><span class="cx">
</span><span class="cx"> _parent_sc.add(o);
</span><ins>+ evas_object_static_clip_set(sd->base.clipper, EINA_FALSE);
</ins><span class="cx"> evas_object_move(sd->base.clipper, 0, 0);
</span><span class="cx"> evas_object_resize(sd->base.clipper, 0, 0);
</span><span class="cx">
</span></span></pre>
</div>
</div>
</body>
</html>
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic