[prev in list] [next in list] [prev in thread] [next in thread]
List: webkit-changes
Subject: [webkit-changes] [74192] trunk/JavaScriptCore
From: ariya () webkit ! org
Date: 2010-12-16 16:32:19
Message-ID: 20101216163220.2F85A5FF216E () beta ! macosforge ! org
[Download RAW message or body]
[Attachment #2 (text/html)]
<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[74192] trunk/JavaScriptCore</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: \
verdana,arial,helvetica,sans-serif; font-size: 10pt; } #msg dl a { font-weight: \
bold} #msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: \
bold; } #msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: \
6px; } #logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em \
0; } #logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg \
h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; } \
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; \
} #logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: \
-1.5em; padding-left: 1.5em; } #logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em \
1em 0 1em; background: white;} #logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid \
#fa0; border-bottom: 1px solid #fa0; background: #fff; } #logmsg table th { \
text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted \
#fa0; } #logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: \
0.2em 0.5em; } #logmsg table thead th { text-align: center; border-bottom: 1px solid \
#fa0; } #logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: \
6px; } #patch { width: 100%; }
#patch h4 {font-family: \
verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, \
#patch .copfile {border:1px solid #ccc;margin:10px 0;} #patch ins \
{background:#dfd;text-decoration:none;display:block;padding:0 10px;} #patch del \
{background:#fdd;text-decoration:none;display:block;padding:0 10px;} #patch .lines, \
.info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a \
href="http://trac.webkit.org/projects/webkit/changeset/74192">74192</a></dd> \
<dt>Author</dt> <dd>ariya@webkit.org</dd> <dt>Date</dt> <dd>2010-12-16 08:32:14 -0800 \
(Thu, 16 Dec 2010)</dd> </dl>
<h3>Log Message</h3>
<pre>2010-12-16 Ariya Hidayat <ariya@sencha.com>
Reviewed by Andreas Kling.
[JSC] Const correctness in ASTBuilder and SyntaxChecker
https://bugs.webkit.org/show_bug.cgi?id=51141
* parser/ASTBuilder.h:
(JSC::ASTBuilder::getName):
(JSC::ASTBuilder::getType):
(JSC::ASTBuilder::isResolve):
* parser/SyntaxChecker.h:
(JSC::SyntaxChecker::operatorStackPop):</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkJavaScriptCoreChangeLog">trunk/JavaScriptCore/ChangeLog</a></li>
<li><a href="#trunkJavaScriptCoreparserASTBuilderh">trunk/JavaScriptCore/parser/ASTBuilder.h</a></li>
<li><a href="#trunkJavaScriptCoreparserSyntaxCheckerh">trunk/JavaScriptCore/parser/SyntaxChecker.h</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkJavaScriptCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/JavaScriptCore/ChangeLog (74191 => \
74192)</h4> <pre class="diff"><span>
<span class="info">--- trunk/JavaScriptCore/ChangeLog 2010-12-16 15:57:47 UTC (rev \
74191)
+++ trunk/JavaScriptCore/ChangeLog 2010-12-16 16:32:14 UTC (rev 74192)
</span><span class="lines">@@ -1,3 +1,17 @@
</span><ins>+2010-12-16 Ariya Hidayat <ariya@sencha.com>
+
+ Reviewed by Andreas Kling.
+
+ [JSC] Const correctness in ASTBuilder and SyntaxChecker
+ https://bugs.webkit.org/show_bug.cgi?id=51141
+
+ * parser/ASTBuilder.h:
+ (JSC::ASTBuilder::getName):
+ (JSC::ASTBuilder::getType):
+ (JSC::ASTBuilder::isResolve):
+ * parser/SyntaxChecker.h:
+ (JSC::SyntaxChecker::operatorStackPop):
+
</ins><span class="cx"> 2010-12-15 Kenneth Russell <kbr@google.com>
</span><span class="cx">
</span><span class="cx"> Reviewed by James Robinson.
</span></span></pre></div>
<a id="trunkJavaScriptCoreparserASTBuilderh"></a>
<div class="modfile"><h4>Modified: trunk/JavaScriptCore/parser/ASTBuilder.h (74191 => \
74192)</h4> <pre class="diff"><span>
<span class="info">--- trunk/JavaScriptCore/parser/ASTBuilder.h 2010-12-16 15:57:47 \
UTC (rev 74191)
+++ trunk/JavaScriptCore/parser/ASTBuilder.h 2010-12-16 16:32:14 UTC (rev 74192)
</span><span class="lines">@@ -576,10 +576,10 @@
</span><span class="cx"> return result;
</span><span class="cx"> }
</span><span class="cx">
</span><del>- const Identifier& getName(Property property) { return \
property->name(); }
- PropertyNode::Type getType(Property property) { return property->type(); }
</del><ins>+ const Identifier& getName(Property property) const { return \
property->name(); } + PropertyNode::Type getType(Property property) const { \
return property->type(); } </ins><span class="cx">
</span><del>- bool isResolve(ExpressionNode* expr) { return \
expr->isResolveNode(); } </del><ins>+ bool isResolve(ExpressionNode* expr) \
const { return expr->isResolveNode(); } </ins><span class="cx">
</span><span class="cx"> private:
</span><span class="cx"> struct Scope {
</span></span></pre></div>
<a id="trunkJavaScriptCoreparserSyntaxCheckerh"></a>
<div class="modfile"><h4>Modified: trunk/JavaScriptCore/parser/SyntaxChecker.h (74191 \
=> 74192)</h4> <pre class="diff"><span>
<span class="info">--- trunk/JavaScriptCore/parser/SyntaxChecker.h 2010-12-16 \
15:57:47 UTC (rev 74191)
+++ trunk/JavaScriptCore/parser/SyntaxChecker.h 2010-12-16 16:32:14 UTC (rev 74192)
</span><span class="lines">@@ -203,9 +203,9 @@
</span><span class="cx">
</span><span class="cx"> void assignmentStackAppend(int, int, int, int, int, \
Operator) { } </span><span class="cx"> int createAssignment(int, int, int, int, \
int) { ASSERT_NOT_REACHED(); return 1; } </span><del>- const Identifier& \
getName(const Property& property) { ASSERT(property.name); return *property.name; \
}
- PropertyNode::Type getType(const Property& property) { return property.type; \
}
- bool isResolve(ExpressionType expr) { return expr == ResolveExpr || expr == \
ResolveEvalExpr; } </del><ins>+ const Identifier& getName(const Property& \
property) const { ASSERT(property.name); return *property.name; } + \
PropertyNode::Type getType(const Property& property) const { return \
property.type; } + bool isResolve(ExpressionType expr) const { return expr == \
ResolveExpr || expr == ResolveEvalExpr; } </ins><span class="cx">
</span><span class="cx"> private:
</span><span class="cx"> int m_topBinaryExpr;
</span></span></pre>
</div>
</div>
</body>
</html>
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic