[prev in list] [next in list] [prev in thread] [next in thread]
List: webkit-changes
Subject: [webkit-changes] [54466] trunk
From: dglazkov () chromium ! org
Date: 2010-02-06 20:18:55
Message-ID: 20100206201856.59A3D3E8F380 () beta ! macosforge ! org
[Download RAW message or body]
[Attachment #2 (text/html)]
<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[54466] trunk</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: \
verdana,arial,helvetica,sans-serif; font-size: 10pt; } #msg dl a { font-weight: \
bold} #msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: \
bold; } #msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: \
6px; } #logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em \
0; } #logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg \
h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; } \
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; \
} #logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: \
-1.5em; padding-left: 1.5em; } #logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em \
1em 0 1em; background: white;} #logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid \
#fa0; border-bottom: 1px solid #fa0; background: #fff; } #logmsg table th { \
text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted \
#fa0; } #logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: \
0.2em 0.5em; } #logmsg table thead th { text-align: center; border-bottom: 1px solid \
#fa0; } #logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: \
6px; } #patch { width: 100%; }
#patch h4 {font-family: \
verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, \
#patch .copfile {border:1px solid #ccc;margin:10px 0;} #patch ins \
{background:#dfd;text-decoration:none;display:block;padding:0 10px;} #patch del \
{background:#fdd;text-decoration:none;display:block;padding:0 10px;} #patch .lines, \
.info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a \
href="http://trac.webkit.org/projects/webkit/changeset/54466">54466</a></dd> \
<dt>Author</dt> <dd>dglazkov@chromium.org</dd> <dt>Date</dt> <dd>2010-02-06 12:18:51 \
-0800 (Sat, 06 Feb 2010)</dd> </dl>
<h3>Log Message</h3>
<pre>2010-02-06 Dimitri Glazkov <dglazkov@chromium.org>
No review, rolling out <a \
href="http://trac.webkit.org/projects/webkit/changeset/54364">r54364</a>. \
http://trac.webkit.org/changeset/54364 https://bugs.webkit.org/show_bug.cgi?id=34464
Introduced asserts in layout tests, needs more testing
locally.
* accessibility/chromium/AXObjectCacheChromium.cpp:
(WebCore::AXObjectCache::postPlatformNotification):
* page/chromium/ChromeClientChromium.h:
2010-02-06 Dimitri Glazkov <dglazkov@chromium.org>
No review, rolling out <a \
href="http://trac.webkit.org/projects/webkit/changeset/54364">r54364</a>. \
http://trac.webkit.org/changeset/54364 https://bugs.webkit.org/show_bug.cgi?id=34464
Introduced asserts in layout tests, needs more testing
locally.
* public/WebViewClient.h:
* src/ChromeClientImpl.cpp:
* src/ChromeClientImpl.h:</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkWebCoreChangeLog">trunk/WebCore/ChangeLog</a></li>
<li><a href="#trunkWebCoreaccessibilitychromiumAXObjectCacheChromiumcpp">trunk/WebCore/accessibility/chromium/AXObjectCacheChromium.cpp</a></li>
<li><a href="#trunkWebCorepagechromiumChromeClientChromiumh">trunk/WebCore/page/chromium/ChromeClientChromium.h</a></li>
<li><a href="#trunkWebKitchromiumChangeLog">trunk/WebKit/chromium/ChangeLog</a></li>
<li><a href="#trunkWebKitchromiumpublicWebViewClienth">trunk/WebKit/chromium/public/WebViewClient.h</a></li>
<li><a href="#trunkWebKitchromiumsrcChromeClientImplcpp">trunk/WebKit/chromium/src/ChromeClientImpl.cpp</a></li>
<li><a href="#trunkWebKitchromiumsrcChromeClientImplh">trunk/WebKit/chromium/src/ChromeClientImpl.h</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/WebCore/ChangeLog (54465 => 54466)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/WebCore/ChangeLog 2010-02-06 19:02:34 UTC (rev 54465)
+++ trunk/WebCore/ChangeLog 2010-02-06 20:18:51 UTC (rev 54466)
</span><span class="lines">@@ -1,5 +1,18 @@
</span><span class="cx"> 2010-02-06 Dimitri Glazkov <dglazkov@chromium.org>
</span><span class="cx">
</span><ins>+ No review, rolling out r54364.
+ http://trac.webkit.org/changeset/54364
+ https://bugs.webkit.org/show_bug.cgi?id=34464
+
+ Introduced asserts in layout tests, needs more testing
+ locally.
+
+ * accessibility/chromium/AXObjectCacheChromium.cpp:
+ (WebCore::AXObjectCache::postPlatformNotification):
+ * page/chromium/ChromeClientChromium.h:
+
+2010-02-06 Dimitri Glazkov <dglazkov@chromium.org>
+
</ins><span class="cx"> Reviewed by Adam Barth.
</span><span class="cx">
</span><span class="cx"> Using inlines and function-level statics don't mix, \
according to gcc. </span></span></pre></div>
<a id="trunkWebCoreaccessibilitychromiumAXObjectCacheChromiumcpp"></a>
<div class="modfile"><h4>Modified: \
trunk/WebCore/accessibility/chromium/AXObjectCacheChromium.cpp (54465 => 54466)</h4> \
<pre class="diff"><span> <span class="info">--- \
trunk/WebCore/accessibility/chromium/AXObjectCacheChromium.cpp 2010-02-06 19:02:34 \
UTC (rev 54465)
+++ trunk/WebCore/accessibility/chromium/AXObjectCacheChromium.cpp 2010-02-06 \
20:18:51 UTC (rev 54466) </span><span class="lines">@@ -26,22 +26,11 @@
</span><span class="cx">
</span><span class="cx"> #include "config.h"
</span><span class="cx"> #include "AXObjectCache.h"
</span><ins>+
</ins><span class="cx"> #include "AccessibilityObject.h"
</span><del>-#include "Chrome.h"
-#include "ChromeClientChromium.h"
-#include "FrameView.h"
</del><span class="cx">
</span><span class="cx"> namespace WebCore {
</span><span class="cx">
</span><del>-static ChromeClientChromium* toChromeClientChromium(FrameView* view)
-{
- Page* page = view->frame() ? view->frame()->page() : 0;
- if (!page)
- return 0;
-
- return static_cast<ChromeClientChromium*>(page->chrome()->client());
-}
-
</del><span class="cx"> void AXObjectCache::detachWrapper(AccessibilityObject* obj)
</span><span class="cx"> {
</span><span class="cx"> // In Chromium, AccessibilityObjects are wrapped lazily.
</span><span class="lines">@@ -54,14 +43,8 @@
</span><span class="cx"> // In Chromium, AccessibilityObjects are wrapped lazily.
</span><span class="cx"> }
</span><span class="cx">
</span><del>-void AXObjectCache::postPlatformNotification(AccessibilityObject* obj, \
AXNotification notification) </del><ins>+void \
AXObjectCache::postPlatformNotification(AccessibilityObject*, AXNotification) \
</ins><span class="cx"> { </span><del>- if (!obj || !obj->documentFrameView() \
|| notification != AXCheckedStateChanged)
- return;
-
- ChromeClientChromium* client = \
toChromeClientChromium(obj->documentFrameView());
- if (client)
- client->didChangeAccessibilityObjectState(obj);
</del><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> void \
AXObjectCache::handleFocusedUIElementChanged(RenderObject*, RenderObject*) \
</span></span></pre></div> <a id="trunkWebCorepagechromiumChromeClientChromiumh"></a>
<div class="modfile"><h4>Modified: trunk/WebCore/page/chromium/ChromeClientChromium.h \
(54465 => 54466)</h4> <pre class="diff"><span>
<span class="info">--- trunk/WebCore/page/chromium/ChromeClientChromium.h 2010-02-06 \
19:02:34 UTC (rev 54465)
+++ trunk/WebCore/page/chromium/ChromeClientChromium.h 2010-02-06 20:18:51 UTC (rev \
54466) </span><span class="lines">@@ -35,26 +35,21 @@
</span><span class="cx"> #include <wtf/Forward.h>
</span><span class="cx">
</span><span class="cx"> namespace WebCore {
</span><ins>+ class IntRect;
+ class PopupContainer;
</ins><span class="cx">
</span><del>-class AccessibilityObject;
-class IntRect;
-class PopupContainer;
</del><ins>+ // Contains Chromium-specific extensions to the ChromeClient. Only \
put + // things here that don't make sense for other ports.
+ class ChromeClientChromium : public ChromeClient {
+ public:
+ // Notifies the client of a new popup widget. The client should place
+ // and size the widget with the given bounds, relative to the screen.
+ // If handleExternal is true, then drawing and input handling for the
+ // popup will be handled by the external embedder.
+ virtual void popupOpened(PopupContainer* popupContainer, const IntRect& \
bounds, + bool focusOnShow, bool handleExternal) = 0;
+ };
</ins><span class="cx">
</span><del>-// Contains Chromium-specific extensions to the ChromeClient. Only put
-// things here that don't make sense for other ports.
-class ChromeClientChromium : public ChromeClient {
-public:
- // Notifies the client of a new popup widget. The client should place
- // and size the widget with the given bounds, relative to the screen.
- // If handleExternal is true, then drawing and input handling for the
- // popup will be handled by the external embedder.
- virtual void popupOpened(PopupContainer* popupContainer, const IntRect& \
bounds,
- bool focusOnShow, bool handleExternal) = 0;
-
- // Notifies embedder that the state of an accessibility object has changed.
- virtual void didChangeAccessibilityObjectState(AccessibilityObject*) = 0;
-};
-
</del><span class="cx"> } // namespace WebCore
</span><span class="cx">
</span><span class="cx"> #endif
</span></span></pre></div>
<a id="trunkWebKitchromiumChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/WebKit/chromium/ChangeLog (54465 => \
54466)</h4> <pre class="diff"><span>
<span class="info">--- trunk/WebKit/chromium/ChangeLog 2010-02-06 19:02:34 UTC (rev \
54465)
+++ trunk/WebKit/chromium/ChangeLog 2010-02-06 20:18:51 UTC (rev 54466)
</span><span class="lines">@@ -1,3 +1,16 @@
</span><ins>+2010-02-06 Dimitri Glazkov <dglazkov@chromium.org>
+
+ No review, rolling out r54364.
+ http://trac.webkit.org/changeset/54364
+ https://bugs.webkit.org/show_bug.cgi?id=34464
+
+ Introduced asserts in layout tests, needs more testing
+ locally.
+
+ * public/WebViewClient.h:
+ * src/ChromeClientImpl.cpp:
+ * src/ChromeClientImpl.h:
+
</ins><span class="cx"> 2010-02-05 James Hawkins <jhawkins@chromium.org>
</span><span class="cx">
</span><span class="cx"> Reviewed by David Levin.
</span></span></pre></div>
<a id="trunkWebKitchromiumpublicWebViewClienth"></a>
<div class="modfile"><h4>Modified: trunk/WebKit/chromium/public/WebViewClient.h \
(54465 => 54466)</h4> <pre class="diff"><span>
<span class="info">--- trunk/WebKit/chromium/public/WebViewClient.h 2010-02-06 \
19:02:34 UTC (rev 54465)
+++ trunk/WebKit/chromium/public/WebViewClient.h 2010-02-06 20:18:51 UTC (rev 54466)
</span><span class="lines">@@ -252,10 +252,7 @@
</span><span class="cx"> // accessibility object.
</span><span class="cx"> virtual void focusAccessibilityObject(const \
WebAccessibilityObject&) { } </span><span class="cx">
</span><del>- // Notifies embedder that the state of an accessibility object has \
changed.
- virtual void didChangeAccessibilityObjectState(const \
WebAccessibilityObject&) { } </del><span class="cx">
</span><del>-
</del><span class="cx"> // Developer tools \
----------------------------------------------------- </span><span class="cx">
</span><span class="cx"> // Called to notify the client that the inspector's \
settings were </span></span></pre></div>
<a id="trunkWebKitchromiumsrcChromeClientImplcpp"></a>
<div class="modfile"><h4>Modified: trunk/WebKit/chromium/src/ChromeClientImpl.cpp \
(54465 => 54466)</h4> <pre class="diff"><span>
<span class="info">--- trunk/WebKit/chromium/src/ChromeClientImpl.cpp 2010-02-06 \
19:02:34 UTC (rev 54465)
+++ trunk/WebKit/chromium/src/ChromeClientImpl.cpp 2010-02-06 20:18:51 UTC (rev \
54466) </span><span class="lines">@@ -659,13 +659,6 @@
</span><span class="cx"> info->items.swap(outputItems);
</span><span class="cx"> }
</span><span class="cx">
</span><del>-void ChromeClientImpl::didChangeAccessibilityObjectState(AccessibilityObject* \
obj)
-{
- // Alert assistive technology about the accessibility object state change
- if (obj)
- m_webView->client()->didChangeAccessibilityObjectState(WebAccessibilityObject(obj));
-}
-
</del><span class="cx"> #if ENABLE(NOTIFICATIONS)
</span><span class="cx"> NotificationPresenter* \
ChromeClientImpl::notificationPresenter() const </span><span class="cx"> {
</span></span></pre></div>
<a id="trunkWebKitchromiumsrcChromeClientImplh"></a>
<div class="modfile"><h4>Modified: trunk/WebKit/chromium/src/ChromeClientImpl.h \
(54465 => 54466)</h4> <pre class="diff"><span>
<span class="info">--- trunk/WebKit/chromium/src/ChromeClientImpl.h 2010-02-06 \
19:02:34 UTC (rev 54465)
+++ trunk/WebKit/chromium/src/ChromeClientImpl.h 2010-02-06 20:18:51 UTC (rev 54466)
</span><span class="lines">@@ -34,7 +34,6 @@
</span><span class="cx"> #include "ChromeClientChromium.h"
</span><span class="cx">
</span><span class="cx"> namespace WebCore {
</span><del>-class AccessibilityObject;
</del><span class="cx"> class HTMLParserQuirks;
</span><span class="cx"> class PopupContainer;
</span><span class="cx"> class SecurityOrigin;
</span><span class="lines">@@ -133,7 +132,6 @@
</span><span class="cx"> const WebCore::IntRect& \
bounds, </span><span class="cx"> bool activatable,
</span><span class="cx"> bool handleExternally);
</span><del>- virtual void \
didChangeAccessibilityObjectState(WebCore::AccessibilityObject*); </del><span \
class="cx"> </span><span class="cx"> // ChromeClientImpl:
</span><span class="cx"> void setCursor(const WebCursorInfo& cursor);
</span></span></pre>
</div>
</div>
</body>
</html>
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic