[prev in list] [next in list] [prev in thread] [next in thread] 

List:       webkit-changes
Subject:    [webkit-changes] [44298] trunk
From:       weinig () apple ! com
Date:       2009-05-31 22:24:27
Message-ID: 20090531222431.541B21CCC37C () beta ! macosforge ! org
[Download RAW message or body]

[Attachment #2 (text/html)]

<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[44298] trunk</title>
</head>
<body>

<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: \
verdana,arial,helvetica,sans-serif; font-size: 10pt;  } #msg dl a { font-weight: \
bold} #msg dl a:link    { color:#fc3; }
#msg dl a:active  { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: \
bold; } #msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: \
6px; } #logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em \
0; } #logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg \
h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; } \
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; \
} #logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: \
-1.5em; padding-left: 1.5em; } #logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em \
1em 0 1em; background: white;} #logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid \
#fa0; border-bottom: 1px solid #fa0; background: #fff; } #logmsg table th { \
text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted \
#fa0; } #logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: \
0.2em 0.5em; } #logmsg table thead th { text-align: center; border-bottom: 1px solid \
#fa0; } #logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: \
6px; } #patch { width: 100%; }
#patch h4 {font-family: \
verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
 #patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff  {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, \
#patch .copfile {border:1px solid #ccc;margin:10px 0;} #patch ins \
{background:#dfd;text-decoration:none;display:block;padding:0 10px;} #patch del \
{background:#fdd;text-decoration:none;display:block;padding:0 10px;} #patch .lines, \
                .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a \
href="http://trac.webkit.org/projects/webkit/changeset/44298">44298</a></dd> \
<dt>Author</dt> <dd>weinig@apple.com</dd> <dt>Date</dt> <dd>2009-05-31 15:24:27 -0700 \
(Sun, 31 May 2009)</dd> </dl>

<h3>Log Message</h3>
<pre>WebCore:

2009-05-30  Sam Weinig  &lt;sam@webkit.org&gt;

        Reviewed by Mark Rowe.

        Fix for https://bugs.webkit.org/show_bug.cgi?id=26110
        Update online/offline events to match the current spec.
        - Also adds window.ononline and window.onoffline event handler
          properties.

        * page/DOMWindow.cpp:
        (WebCore::DOMWindow::onoffline):
        (WebCore::DOMWindow::setOnoffline):
        (WebCore::DOMWindow::ononline):
        (WebCore::DOMWindow::setOnonline):
        * page/DOMWindow.h:
        * page/DOMWindow.idl:
        * page/Page.cpp:
        (WebCore::networkStateChanged):

LayoutTests:

2009-05-30  Sam Weinig  &lt;sam@webkit.org&gt;

        Reviewed by Mark Rowe.

        Fix for https://bugs.webkit.org/show_bug.cgi?id=26110
        Update online/offline events to match the current spec.
        - Also adds window.ononline and window.onoffline event handler
          properties.

        * fast/dom/Window/window-properties-expected.txt:
        * platform/mac-leopard/fast/dom/Window/window-properties-expected.txt:</pre>

<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsChangeLog">trunk/LayoutTests/ChangeLog</a></li>
<li><a href="#trunkLayoutTestsfastdomWindowwindowpropertiesexpectedtxt">trunk/LayoutTests/fast/dom/Window/window-properties-expected.txt</a></li>
 <li><a href="#trunkLayoutTestsplatformmacleopardfastdomWindowwindowpropertiesexpected \
txt">trunk/LayoutTests/platform/mac-leopard/fast/dom/Window/window-properties-expected.txt</a></li>
 <li><a href="#trunkWebCoreChangeLog">trunk/WebCore/ChangeLog</a></li>
<li><a href="#trunkWebCorepageDOMWindowcpp">trunk/WebCore/page/DOMWindow.cpp</a></li>
<li><a href="#trunkWebCorepageDOMWindowh">trunk/WebCore/page/DOMWindow.h</a></li>
<li><a href="#trunkWebCorepageDOMWindowidl">trunk/WebCore/page/DOMWindow.idl</a></li>
<li><a href="#trunkWebCorepagePagecpp">trunk/WebCore/page/Page.cpp</a></li>
</ul>

</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkLayoutTestsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/ChangeLog (44297 => 44298)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/ChangeLog	2009-05-31 18:22:20 UTC (rev \
                44297)
+++ trunk/LayoutTests/ChangeLog	2009-05-31 22:24:27 UTC (rev 44298)
</span><span class="lines">@@ -1,3 +1,15 @@
</span><ins>+2009-05-30  Sam Weinig  &lt;sam@webkit.org&gt;
+
+        Reviewed by Mark Rowe.
+
+        Fix for https://bugs.webkit.org/show_bug.cgi?id=26110
+        Update online/offline events to match the current spec.
+        - Also adds window.ononline and window.onoffline event handler
+          properties.
+
+        * fast/dom/Window/window-properties-expected.txt:
+        * platform/mac-leopard/fast/dom/Window/window-properties-expected.txt:
+
</ins><span class="cx"> 2009-05-29  Sam Weinig  &lt;sam@webkit.org&gt;
</span><span class="cx"> 
</span><span class="cx">         Reviewed by Anders Carlsson.
</span></span></pre></div>
<a id="trunkLayoutTestsfastdomWindowwindowpropertiesexpectedtxt"></a>
<div class="modfile"><h4>Modified: \
trunk/LayoutTests/fast/dom/Window/window-properties-expected.txt (44297 => \
44298)</h4> <pre class="diff"><span>
<span class="info">--- \
trunk/LayoutTests/fast/dom/Window/window-properties-expected.txt	2009-05-31 18:22:20 \
                UTC (rev 44297)
+++ trunk/LayoutTests/fast/dom/Window/window-properties-expected.txt	2009-05-31 \
22:24:27 UTC (rev 44298) </span><span class="lines">@@ -1702,6 +1702,8 @@
</span><span class="cx"> window.onmouseover [null]
</span><span class="cx"> window.onmouseup [null]
</span><span class="cx"> window.onmousewheel [null]
</span><ins>+window.onoffline [null]
+window.ononline [null]
</ins><span class="cx"> window.onreset [null]
</span><span class="cx"> window.onresize [null]
</span><span class="cx"> window.onscroll [null]
</span></span></pre></div>
<a id="trunkLayoutTestsplatformmacleopardfastdomWindowwindowpropertiesexpectedtxt"></a>
 <div class="modfile"><h4>Modified: \
trunk/LayoutTests/platform/mac-leopard/fast/dom/Window/window-properties-expected.txt \
(44297 => 44298)</h4> <pre class="diff"><span>
<span class="info">--- \
trunk/LayoutTests/platform/mac-leopard/fast/dom/Window/window-properties-expected.txt	2009-05-31 \
                18:22:20 UTC (rev 44297)
+++ trunk/LayoutTests/platform/mac-leopard/fast/dom/Window/window-properties-expected.txt	2009-05-31 \
22:24:27 UTC (rev 44298) </span><span class="lines">@@ -1702,6 +1702,8 @@
</span><span class="cx"> window.onmouseover [null]
</span><span class="cx"> window.onmouseup [null]
</span><span class="cx"> window.onmousewheel [null]
</span><ins>+window.onoffline [null]
+window.ononline [null]
</ins><span class="cx"> window.onreset [null]
</span><span class="cx"> window.onresize [null]
</span><span class="cx"> window.onscroll [null]
</span></span></pre></div>
<a id="trunkWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/WebCore/ChangeLog (44297 => 44298)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/WebCore/ChangeLog	2009-05-31 18:22:20 UTC (rev 44297)
+++ trunk/WebCore/ChangeLog	2009-05-31 22:24:27 UTC (rev 44298)
</span><span class="lines">@@ -1,3 +1,22 @@
</span><ins>+2009-05-30  Sam Weinig  &lt;sam@webkit.org&gt;
+
+        Reviewed by Mark Rowe.
+
+        Fix for https://bugs.webkit.org/show_bug.cgi?id=26110
+        Update online/offline events to match the current spec.
+        - Also adds window.ononline and window.onoffline event handler
+          properties.
+
+        * page/DOMWindow.cpp:
+        (WebCore::DOMWindow::onoffline):
+        (WebCore::DOMWindow::setOnoffline):
+        (WebCore::DOMWindow::ononline):
+        (WebCore::DOMWindow::setOnonline):
+        * page/DOMWindow.h:
+        * page/DOMWindow.idl:
+        * page/Page.cpp:
+        (WebCore::networkStateChanged):
+
</ins><span class="cx"> 2009-05-31  Dirk Schulze  &lt;krit@webkit.org&gt;
</span><span class="cx"> 
</span><span class="cx">         Reviewed by Nikolas Zimmermann.
</span></span></pre></div>
<a id="trunkWebCorepageDOMWindowcpp"></a>
<div class="modfile"><h4>Modified: trunk/WebCore/page/DOMWindow.cpp (44297 => \
44298)</h4> <pre class="diff"><span>
<span class="info">--- trunk/WebCore/page/DOMWindow.cpp	2009-05-31 18:22:20 UTC (rev \
                44297)
+++ trunk/WebCore/page/DOMWindow.cpp	2009-05-31 22:24:27 UTC (rev 44298)
</span><span class="lines">@@ -1537,6 +1537,26 @@
</span><span class="cx">     setAttributeEventListener(eventNames().mousewheelEvent, \
eventListener); </span><span class="cx"> }
</span><span class="cx"> 
</span><ins>+EventListener* DOMWindow::onoffline() const
+{
+    return getAttributeEventListener(eventNames().offlineEvent);
+}
+
+void DOMWindow::setOnoffline(PassRefPtr&lt;EventListener&gt; eventListener)
+{
+    setAttributeEventListener(eventNames().offlineEvent, eventListener);
+}
+
+EventListener* DOMWindow::ononline() const
+{
+    return getAttributeEventListener(eventNames().onlineEvent);
+}
+
+void DOMWindow::setOnonline(PassRefPtr&lt;EventListener&gt; eventListener)
+{
+    setAttributeEventListener(eventNames().onlineEvent, eventListener);
+}
+
</ins><span class="cx"> EventListener* DOMWindow::onreset() const
</span><span class="cx"> {
</span><span class="cx">     return \
getAttributeEventListener(eventNames().resetEvent); </span></span></pre></div>
<a id="trunkWebCorepageDOMWindowh"></a>
<div class="modfile"><h4>Modified: trunk/WebCore/page/DOMWindow.h (44297 => \
44298)</h4> <pre class="diff"><span>
<span class="info">--- trunk/WebCore/page/DOMWindow.h	2009-05-31 18:22:20 UTC (rev \
                44297)
+++ trunk/WebCore/page/DOMWindow.h	2009-05-31 22:24:27 UTC (rev 44298)
</span><span class="lines">@@ -275,6 +275,10 @@
</span><span class="cx">         void setOnmouseup(PassRefPtr&lt;EventListener&gt;);
</span><span class="cx">         EventListener* onmousewheel() const;
</span><span class="cx">         void \
setOnmousewheel(PassRefPtr&lt;EventListener&gt;); </span><ins>+        EventListener* \
onoffline() const; +        void setOnoffline(PassRefPtr&lt;EventListener&gt;);
+        EventListener* ononline() const;
+        void setOnonline(PassRefPtr&lt;EventListener&gt;);
</ins><span class="cx">         EventListener* onreset() const;
</span><span class="cx">         void setOnreset(PassRefPtr&lt;EventListener&gt;);
</span><span class="cx">         EventListener* onresize() const;
</span></span></pre></div>
<a id="trunkWebCorepageDOMWindowidl"></a>
<div class="modfile"><h4>Modified: trunk/WebCore/page/DOMWindow.idl (44297 => \
44298)</h4> <pre class="diff"><span>
<span class="info">--- trunk/WebCore/page/DOMWindow.idl	2009-05-31 18:22:20 UTC (rev \
                44297)
+++ trunk/WebCore/page/DOMWindow.idl	2009-05-31 22:24:27 UTC (rev 44298)
</span><span class="lines">@@ -188,6 +188,7 @@
</span><span class="cx"> 
</span><span class="cx">         // Events
</span><span class="cx">         attribute EventListener onabort;
</span><ins>+        attribute EventListener onbeforeunload;
</ins><span class="cx">         attribute EventListener onblur;
</span><span class="cx">         attribute EventListener onchange;
</span><span class="cx">         attribute EventListener onclick;
</span><span class="lines">@@ -204,6 +205,8 @@
</span><span class="cx">         attribute EventListener onmouseover;
</span><span class="cx">         attribute EventListener onmouseup;
</span><span class="cx">         attribute EventListener onmousewheel;
</span><ins>+        attribute EventListener onoffline;
+        attribute EventListener ononline;
</ins><span class="cx">         attribute EventListener onreset;
</span><span class="cx">         attribute EventListener onresize;
</span><span class="cx">         attribute EventListener onscroll;
</span><span class="lines">@@ -211,10 +214,9 @@
</span><span class="cx">         attribute EventListener onselect;
</span><span class="cx">         attribute EventListener onsubmit;
</span><span class="cx">         attribute EventListener onunload;
</span><del>-        attribute EventListener onbeforeunload;
</del><ins>+        attribute EventListener onwebkitanimationend;
+        attribute EventListener onwebkitanimationiteration;
</ins><span class="cx">         attribute EventListener onwebkitanimationstart;
</span><del>-        attribute EventListener onwebkitanimationiteration;
-        attribute EventListener onwebkitanimationend;
</del><span class="cx">         attribute EventListener onwebkittransitionend;
</span><span class="cx"> 
</span><span class="cx">         // EventTarget interface
</span></span></pre></div>
<a id="trunkWebCorepagePagecpp"></a>
<div class="modfile"><h4>Modified: trunk/WebCore/page/Page.cpp (44297 => 44298)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/WebCore/page/Page.cpp	2009-05-31 18:22:20 UTC (rev \
                44297)
+++ trunk/WebCore/page/Page.cpp	2009-05-31 22:24:27 UTC (rev 44298)
</span><span class="lines">@@ -90,17 +90,8 @@
</span><span class="cx">     }
</span><span class="cx"> 
</span><span class="cx">     AtomicString eventName = networkStateNotifier().onLine() \
? eventNames().onlineEvent : eventNames().offlineEvent; </span><del>-    
-    for (unsigned i = 0; i &lt; frames.size(); i++) {
-        Document* document = frames[i]-&gt;document();
-        
-        // If the document does not have a body the event should be dispatched to \
                the document
-        Node* eventTarget = document-&gt;body();
-        if (!eventTarget)
-            eventTarget = document;
-        
-        eventTarget-&gt;dispatchEvent(eventName, false, false);
-    }
</del><ins>+    for (unsigned i = 0; i &lt; frames.size(); i++)
+        frames[i]-&gt;document()-&gt;dispatchWindowEvent(eventName, false, false);
</ins><span class="cx"> }
</span><span class="cx"> 
</span><span class="cx"> Page::Page(ChromeClient* chromeClient, ContextMenuClient* \
contextMenuClient, EditorClient* editorClient, DragClient* dragClient, \
InspectorClient* inspectorClient) </span></span></pre>
</div>
</div>

</body>
</html>



_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes


[prev in list] [next in list] [prev in thread] [next in thread]

Configure | About | News | Add a list | Sponsored by KoreLogic