[prev in list] [next in list] [prev in thread] [next in thread] 

List:       webkit-changes
Subject:    [webkit-changes] [37114] trunk/WebKit
From:       hyatt () apple ! com
Date:       2008-09-30 21:31:47
Message-ID: 20080930213147.41382448CFA () beta ! macosforge ! org
[Download RAW message or body]

[Attachment #2 (text/html)]

<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[37114] trunk/WebKit</title>
</head>
<body>

<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: \
verdana,arial,helvetica,sans-serif; font-size: 10pt;  } #msg dl a { font-weight: \
bold} #msg dl a:link    { color:#fc3; }
#msg dl a:active  { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: \
bold; } #msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: \
6px; } #logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em \
0; } #logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg \
h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; } \
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; \
} #logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: \
-1.5em; padding-left: 1.5em; } #logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em \
1em 0 1em; background: white;} #logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid \
#fa0; border-bottom: 1px solid #fa0; background: #fff; } #logmsg table th { \
text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted \
#fa0; } #logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: \
0.2em 0.5em; } #logmsg table thead th { text-align: center; border-bottom: 1px solid \
#fa0; } #logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: \
6px; } #patch { width: 100%; }
#patch h4 {font-family: \
verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
 #patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff  {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, \
#patch .copfile {border:1px solid #ccc;margin:10px 0;} #patch ins \
{background:#dfd;text-decoration:none;display:block;padding:0 10px;} #patch del \
{background:#fdd;text-decoration:none;display:block;padding:0 10px;} #patch .lines, \
                .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a \
href="http://trac.webkit.org/projects/webkit/changeset/37114">37114</a></dd> \
<dt>Author</dt> <dd>hyatt@apple.com</dd> <dt>Date</dt> <dd>2008-09-30 14:31:46 -0700 \
(Tue, 30 Sep 2008)</dd> </dl>

<h3>Log Message</h3>
<pre>Tweak the Gtk/Qt ChromeClient methods structurally to make sure immediate \
displays/flushes can happen even if the content doesn't change.</pre>

<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkWebKitgtkWebCoreSupportChromeClientGtkcpp">trunk/WebKit/gtk/WebCoreSupport/ChromeClientGtk.cpp</a></li>
 <li><a href="#trunkWebKitqtWebCoreSupportChromeClientQtcpp">trunk/WebKit/qt/WebCoreSupport/ChromeClientQt.cpp</a></li>
 </ul>

</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkWebKitgtkWebCoreSupportChromeClientGtkcpp"></a>
<div class="modfile"><h4>Modified: \
trunk/WebKit/gtk/WebCoreSupport/ChromeClientGtk.cpp (37113 => 37114)</h4> <pre \
class="diff"><span> <span class="info">--- \
trunk/WebKit/gtk/WebCoreSupport/ChromeClientGtk.cpp	2008-09-30 21:30:56 UTC (rev \
                37113)
+++ trunk/WebKit/gtk/WebCoreSupport/ChromeClientGtk.cpp	2008-09-30 21:31:46 UTC (rev \
37114) </span><span class="lines">@@ -261,8 +261,7 @@
</span><span class="cx"> 
</span><span class="cx"> void ChromeClient::repaint(const WebCore::IntRect&amp; \
windowRect, bool contentChanged, bool immediate) </span><span class="cx"> {
</span><del>-    // No double buffer.
-    if (!contentChanged || !m_webView)
</del><ins>+    if (!m_webView)
</ins><span class="cx">         return;
</span><span class="cx"> 
</span><span class="cx">     GtkWidget* windowWidget = \
gtk_widget_get_toplevel(GTK_WIDGET(m_webView)); </span><span class="lines">@@ -273,7 \
+272,9 @@ </span><span class="cx">     GdkWindow* window = GTK_WINDOW(windowWidget);
</span><span class="cx"> 
</span><span class="cx">     if (window) {
</span><del>-        gdk_window_invalidate_rect(window, &amp;rect, true);
</del><ins>+        // No double buffer.
+        if (contentChanged)
+            gdk_window_invalidate_rect(window, &amp;rect, true);
</ins><span class="cx">         if (immediate)
</span><span class="cx">             gdk_window_process_updates(window, true);
</span><span class="cx">     }
</span></span></pre></div>
<a id="trunkWebKitqtWebCoreSupportChromeClientQtcpp"></a>
<div class="modfile"><h4>Modified: trunk/WebKit/qt/WebCoreSupport/ChromeClientQt.cpp \
(37113 => 37114)</h4> <pre class="diff"><span>
<span class="info">--- trunk/WebKit/qt/WebCoreSupport/ChromeClientQt.cpp	2008-09-30 \
                21:30:56 UTC (rev 37113)
+++ trunk/WebKit/qt/WebCoreSupport/ChromeClientQt.cpp	2008-09-30 21:31:46 UTC (rev \
37114) </span><span class="lines">@@ -298,20 +298,20 @@
</span><span class="cx"> 
</span><span class="cx"> void ChromeClientQt::repaint(const WebCore::IntRect&amp; \
windowRect, bool contentChanged, bool) </span><span class="cx"> {
</span><del>-    // No double buffer.
-    if (!contentChanged)
-        return;
</del><ins>+    // No double buffer, so only update the QWidget if content changed.
+    if (contentChanged) {
+        QWidget* view = m_webPage-&gt;view();
+        if (view) {
+            QRect rect(r);
+            rect = rect.intersected(QRect(QPoint(0, 0), \
m_webPage-&gt;viewportSize())); +            if (!r.isEmpty())
+                view-&gt;update(r);
+        } else
+            emit m_webPage-&gt;repaintRequested(r);
+    }
</ins><span class="cx"> 
</span><del>-    QWidget* view = m_webPage-&gt;view();
-    if (view) {
-        QRect rect(r);
-        rect = rect.intersected(QRect(QPoint(0, 0), m_webPage-&gt;viewportSize()));
-        if (!r.isEmpty())
-            view-&gt;update(r);
-    } else
-        emit m_webPage-&gt;repaintRequested(r);
-    
-    // FIXME: There is no &quot;immediate&quot; support.
</del><ins>+    // FIXME: There is no &quot;immediate&quot; support.  This should be \
done always whenever the flag +    // is set.
</ins><span class="cx"> }
</span><span class="cx"> 
</span><span class="cx"> void ChromeClientQt::addToDirtyRegion(const IntRect&amp; r)
</span></span></pre>
</div>
</div>

</body>
</html>



_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes


[prev in list] [next in list] [prev in thread] [next in thread]

Configure | About | News | Add a list | Sponsored by KoreLogic