[prev in list] [next in list] [prev in thread] [next in thread]
List: webkit-changes
Subject: [webkit-changes] [35991] trunk/WebKit/qt
From: hausmann () webkit ! org
Date: 2008-08-29 15:56:43
Message-ID: 20080829155644.12C4D2D642A () beta ! macosforge ! org
[Download RAW message or body]
[Attachment #2 (text/html)]
<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[35991] trunk/WebKit/qt</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: \
verdana,arial,helvetica,sans-serif; font-size: 10pt; } #msg dl a { font-weight: \
bold} #msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: \
bold; } #msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: \
6px; } #logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em \
0; } #logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg \
h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; } \
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; \
} #logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: \
-1.5em; padding-left: 1.5em; } #logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em \
1em 0 1em; background: white;} #logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid \
#fa0; border-bottom: 1px solid #fa0; background: #fff; } #logmsg table th { \
text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted \
#fa0; } #logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: \
0.2em 0.5em; } #logmsg table thead th { text-align: center; border-bottom: 1px solid \
#fa0; } #logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: \
6px; } #patch { width: 100%; }
#patch h4 {font-family: \
verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, \
#patch .copfile {border:1px solid #ccc;margin:10px 0;} #patch ins \
{background:#dfd;text-decoration:none;display:block;padding:0 10px;} #patch del \
{background:#fdd;text-decoration:none;display:block;padding:0 10px;} #patch .lines, \
.info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a \
href="http://trac.webkit.org/projects/webkit/changeset/35991">35991</a></dd> \
<dt>Author</dt> <dd>hausmann@webkit.org</dd> <dt>Date</dt> <dd>2008-08-29 08:56:43 \
-0700 (Fri, 29 Aug 2008)</dd> </dl>
<h3>Log Message</h3>
<pre>2008-08-29 Holger Hans Peter Freyther <zecke@selfish.org>
Reviewed by Simon.
Catch up with the introduction of PageGroup in r30840. Enable tracking of
visited links, enable this in QWebPage next to the other WebCore init call.
Calling this more than once is no issue and a cheap operation, we also do not
reset the state. When clearing the history of a page, clear the link \
state.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkWebKitqtApiqwebhistorycpp">trunk/WebKit/qt/Api/qwebhistory.cpp</a></li>
<li><a href="#trunkWebKitqtApiqwebhistoryinterfacecpp">trunk/WebKit/qt/Api/qwebhistoryinterface.cpp</a></li>
<li><a href="#trunkWebKitqtApiqwebpagecpp">trunk/WebKit/qt/Api/qwebpage.cpp</a></li>
<li><a href="#trunkWebKitqtChangeLog">trunk/WebKit/qt/ChangeLog</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkWebKitqtApiqwebhistorycpp"></a>
<div class="modfile"><h4>Modified: trunk/WebKit/qt/Api/qwebhistory.cpp (35990 => \
35991)</h4> <pre class="diff"><span>
<span class="info">--- trunk/WebKit/qt/Api/qwebhistory.cpp 2008-08-29 15:56:18 UTC \
(rev 35990)
+++ trunk/WebKit/qt/Api/qwebhistory.cpp 2008-08-29 15:56:43 UTC (rev 35991)
</span><span class="lines">@@ -24,6 +24,7 @@
</span><span class="cx"> #include "PlatformString.h"
</span><span class="cx"> #include "Image.h"
</span><span class="cx"> #include "Page.h"
</span><ins>+#include "PageGroup.h"
</ins><span class="cx">
</span><span class="cx"> #include <QSharedData>
</span><span class="cx">
</span><span class="lines">@@ -189,6 +190,11 @@
</span><span class="cx"> RefPtr<WebCore::HistoryItem> current = \
d->lst->currentItem(); </span><span class="cx"> int capacity = \
d->lst->capacity(); </span><span class="cx"> d->lst->setCapacity(0); \
</span><ins>+
+ WebCore::Page* page = d->lst->page();
+ if (page && page->groupPtr())
+ page->groupPtr()->removeVisitedLinks();
+
</ins><span class="cx"> d->lst->setCapacity(capacity);
</span><span class="cx"> d->lst->addItem(current.get());
</span><span class="cx"> d->lst->goToItem(current.get());
</span></span></pre></div>
<a id="trunkWebKitqtApiqwebhistoryinterfacecpp"></a>
<div class="modfile"><h4>Modified: trunk/WebKit/qt/Api/qwebhistoryinterface.cpp \
(35990 => 35991)</h4> <pre class="diff"><span>
<span class="info">--- trunk/WebKit/qt/Api/qwebhistoryinterface.cpp 2008-08-29 \
15:56:18 UTC (rev 35990)
+++ trunk/WebKit/qt/Api/qwebhistoryinterface.cpp 2008-08-29 15:56:43 UTC (rev 35991)
</span><span class="lines">@@ -19,12 +19,13 @@
</span><span class="cx"> This class provides all functionality needed for \
tracking global history. </span><span class="cx"> */
</span><span class="cx">
</span><ins>+#include "config.h"
</ins><span class="cx"> #include "qwebhistoryinterface.h"
</span><span class="cx">
</span><span class="cx"> #include <QCoreApplication>
</span><span class="cx">
</span><ins>+#include "PageGroup.h"
</ins><span class="cx"> #include "PlatformString.h"
</span><del>-#include <wtf/Platform.h>
</del><span class="cx">
</span><span class="cx"> // FIXME: It's not correct to just implement a WebCore \
function in WebKit! </span><span class="cx"> // This needs to be fixed to match other \
platforms. </span><span class="lines">@@ -66,7 +67,10 @@
</span><span class="cx"> return;
</span><span class="cx"> if (default_interface && \
default_interface->parent() == 0) </span><span class="cx"> delete \
default_interface; </span><ins>+
</ins><span class="cx"> default_interface = defaultInterface;
</span><ins>+ WebCore::PageGroup::removeAllVisitedLinks();
+
</ins><span class="cx"> if (!gRoutineAdded) {
</span><span class="cx"> qAddPostRoutine(gCleanupInterface);
</span><span class="cx"> gRoutineAdded = true;
</span></span></pre></div>
<a id="trunkWebKitqtApiqwebpagecpp"></a>
<div class="modfile"><h4>Modified: trunk/WebKit/qt/Api/qwebpage.cpp (35990 => \
35991)</h4> <pre class="diff"><span>
<span class="info">--- trunk/WebKit/qt/Api/qwebpage.cpp 2008-08-29 15:56:18 UTC (rev \
35990)
+++ trunk/WebKit/qt/Api/qwebpage.cpp 2008-08-29 15:56:43 UTC (rev 35991)
</span><span class="lines">@@ -43,6 +43,7 @@
</span><span class="cx"> #include "EditorClientQt.h"
</span><span class="cx"> #include "Settings.h"
</span><span class="cx"> #include "Page.h"
</span><ins>+#include "PageGroup.h"
</ins><span class="cx"> #include "Pasteboard.h"
</span><span class="cx"> #include "FrameLoader.h"
</span><span class="cx"> #include "FrameLoadRequest.h"
</span><span class="lines">@@ -214,6 +215,7 @@
</span><span class="cx"> , viewportSize(QSize(0,0))
</span><span class="cx"> {
</span><span class="cx"> WebCore::InitializeLoggingChannelsIfNecessary();
</span><ins>+ WebCore::PageGroup::setShouldTrackVisitedLinks(true);
</ins><span class="cx">
</span><span class="cx"> chromeClient = new ChromeClientQt(q);
</span><span class="cx"> contextMenuClient = new ContextMenuClientQt();
</span></span></pre></div>
<a id="trunkWebKitqtChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/WebKit/qt/ChangeLog (35990 => 35991)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/WebKit/qt/ChangeLog 2008-08-29 15:56:18 UTC (rev 35990)
+++ trunk/WebKit/qt/ChangeLog 2008-08-29 15:56:43 UTC (rev 35991)
</span><span class="lines">@@ -2,6 +2,22 @@
</span><span class="cx">
</span><span class="cx"> Reviewed by Simon.
</span><span class="cx">
</span><ins>+ Catch up with the introduction of PageGroup in r30840. Enable \
tracking of + visited links, enable this in QWebPage next to the other WebCore \
init call. + Calling this more than once is no issue and a cheap operation, we \
also do not + reset the state. When clearing the history of a page, clear the \
link state. +
+ * Api/qwebhistory.cpp:
+ (QWebHistory::clear):
+ * Api/qwebhistoryinterface.cpp:
+ (QWebHistoryInterface::setDefaultInterface):
+ * Api/qwebpage.cpp:
+ (QWebPagePrivate::QWebPagePrivate):
+
+2008-08-29 Holger Hans Peter Freyther <zecke@selfish.org>
+
+ Reviewed by Simon.
+
</ins><span class="cx"> Revert revision 34348 which removed the global \
historyContains() function. </span><span class="cx">
</span><span class="cx"> This function was needed to implement the public API \
of QWebHistoryInterface </span></span></pre>
</div>
</div>
</body>
</html>
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic