[prev in list] [next in list] [prev in thread] [next in thread]
List: webkit-changes
Subject: [webkit-changes] [31913] trunk/WebCore
From: antti () apple ! com
Date: 2008-04-15 18:50:02
Message-ID: 20080415185002.8FFA1159C396 () beta ! macosforge ! org
[Download RAW message or body]
[Attachment #2 (text/html)]
<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" /><style \
type="text/css"><!-- #msg dl { border: 1px #006 solid; background: #369; padding: \
6px; color: #fff; } #msg dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer { font-family: \
verdana,arial,helvetica,sans-serif; font-size: 10pt; } #msg dl a { font-weight: \
bold} #msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: \
bold; } #msg pre, #msg p { overflow: auto; background: #ffc; border: 1px #fc0 solid; \
padding: 6px; } #msg ul { overflow: auto; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: \
6px; } #patch { width: 100%; }
#patch h4 {font-family: \
verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, \
#patch .copfile {border:1px solid #ccc;margin:10px 0;} #patch ins \
{background:#dfd;text-decoration:none;display:block;padding:0 10px;} #patch del \
{background:#fdd;text-decoration:none;display:block;padding:0 10px;} #patch .lines, \
.info {color:#888;background:#fff;}
--></style>
<title>[31913] trunk/WebCore</title>
</head>
<body>
<div id="msg">
<dl>
<dt>Revision</dt> <dd><a \
href="http://trac.webkit.org/projects/webkit/changeset/31913">31913</a></dd> \
<dt>Author</dt> <dd>antti@apple.com</dd> <dt>Date</dt> <dd>2008-04-15 11:49:54 -0700 \
(Tue, 15 Apr 2008)</dd> </dl>
<h3>Log Message</h3>
<pre>2008-04-15 Antti Koivisto <antti@apple.com>
Reviewed by Geoff.
Fix <rdar://problem/5862921>
REGRESSION: Leak in SVGSVGElement::SVGSVGElement
In these strange days RefCounted starts with count of one.
* svg/SVGSVGElement.cpp:
(WebCore::SVGSVGElement::SVGSVGElement):
* svg/animation/SMILTimeContainer.h:
(WebCore::SMILTimeContainer::create):</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkWebCoreChangeLog">trunk/WebCore/ChangeLog</a></li>
<li><a href="#trunkWebCoresvgSVGSVGElementcpp">trunk/WebCore/svg/SVGSVGElement.cpp</a></li>
<li><a href="#trunkWebCoresvganimationSMILTimeContainerh">trunk/WebCore/svg/animation/SMILTimeContainer.h</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/WebCore/ChangeLog (31912 => 31913)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/WebCore/ChangeLog 2008-04-15 18:15:06 UTC (rev 31912)
+++ trunk/WebCore/ChangeLog 2008-04-15 18:49:54 UTC (rev 31913)
</span><span class="lines">@@ -1,3 +1,17 @@
</span><ins>+2008-04-15 Antti Koivisto <antti@apple.com>
+
+ Reviewed by Geoff.
+
+ Fix <rdar://problem/5862921>
+ REGRESSION: Leak in SVGSVGElement::SVGSVGElement
+
+ In these strange days RefCounted starts with count of one.
+
+ * svg/SVGSVGElement.cpp:
+ (WebCore::SVGSVGElement::SVGSVGElement):
+ * svg/animation/SMILTimeContainer.h:
+ (WebCore::SMILTimeContainer::create):
+
</ins><span class="cx"> 2008-04-15 Anatoli Papirovski <apapirovski@mac.com>
</span><span class="cx">
</span><span class="cx"> Reviewed by hyatt
</span></span></pre></div>
<a id="trunkWebCoresvgSVGSVGElementcpp"></a>
<div class="modfile"><h4>Modified: trunk/WebCore/svg/SVGSVGElement.cpp (31912 => \
31913)</h4> <pre class="diff"><span>
<span class="info">--- trunk/WebCore/svg/SVGSVGElement.cpp 2008-04-15 18:15:06 UTC \
(rev 31912)
+++ trunk/WebCore/svg/SVGSVGElement.cpp 2008-04-15 18:49:54 UTC (rev 31913)
</span><span class="lines">@@ -68,7 +68,7 @@
</span><span class="cx"> , m_width(this, LengthModeWidth)
</span><span class="cx"> , m_height(this, LengthModeHeight)
</span><span class="cx"> , m_useCurrentView(false)
</span><del>- , m_timeContainer(new SMILTimeContainer)
</del><ins>+ , m_timeContainer(SMILTimeContainer::create())
</ins><span class="cx"> , m_viewSpec(0)
</span><span class="cx"> , m_containerSize(300, 150)
</span><span class="cx"> , m_hasSetContainerSize(false)
</span></span></pre></div>
<a id="trunkWebCoresvganimationSMILTimeContainerh"></a>
<div class="modfile"><h4>Modified: trunk/WebCore/svg/animation/SMILTimeContainer.h \
(31912 => 31913)</h4> <pre class="diff"><span>
<span class="info">--- trunk/WebCore/svg/animation/SMILTimeContainer.h 2008-04-15 \
18:15:06 UTC (rev 31912)
+++ trunk/WebCore/svg/animation/SMILTimeContainer.h 2008-04-15 18:49:54 UTC (rev \
31913) </span><span class="lines">@@ -31,6 +31,7 @@
</span><span class="cx"> #include "SMILTime.h"
</span><span class="cx"> #include "Timer.h"
</span><span class="cx"> #include <wtf/HashSet.h>
</span><ins>+#include <wtf/PassRefPtr.h>
</ins><span class="cx"> #include <wtf/RefCounted.h>
</span><span class="cx">
</span><span class="cx"> namespace WebCore {
</span><span class="lines">@@ -39,8 +40,7 @@
</span><span class="cx">
</span><span class="cx"> class SMILTimeContainer : public \
RefCounted<SMILTimeContainer> { </span><span class="cx"> public:
</span><del>-
- SMILTimeContainer();
</del><ins>+ static PassRefPtr<SMILTimeContainer> create() { return \
adoptRef(new SMILTimeContainer); } </ins><span class="cx">
</span><span class="cx"> void schedule(SVGSMILElement*);
</span><span class="cx"> void unschedule(SVGSMILElement*);
</span><span class="lines">@@ -55,6 +55,8 @@
</span><span class="cx"> void resume();
</span><span class="cx">
</span><span class="cx"> private:
</span><ins>+ SMILTimeContainer();
+
</ins><span class="cx"> void timerFired(Timer<SMILTimeContainer>*);
</span><span class="cx"> void startTimer(SMILTime fireTime, SMILTime \
minimumDelay = 0); </span><span class="cx"> void updateAnimations(SMILTime \
elapsed); </span></span></pre>
</div>
</div>
</body>
</html>
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic