[prev in list] [next in list] [prev in thread] [next in thread] 

List:       webkit-changes
Subject:    [webkit-changes] [31911] trunk/WebKit/mac
From:       beidson () apple ! com
Date:       2008-04-15 17:54:25
Message-ID: 20080415175425.DA733159BCC1 () beta ! macosforge ! org
[Download RAW message or body]

[Attachment #2 (text/html)]

<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" /><style \
type="text/css"><!-- #msg dl { border: 1px #006 solid; background: #369; padding: \
6px; color: #fff; } #msg dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer { font-family: \
verdana,arial,helvetica,sans-serif; font-size: 10pt;  } #msg dl a { font-weight: \
bold} #msg dl a:link    { color:#fc3; }
#msg dl a:active  { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: \
bold; } #msg pre, #msg p { overflow: auto; background: #ffc; border: 1px #fc0 solid; \
padding: 6px; } #msg ul { overflow: auto; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: \
6px; } #patch { width: 100%; }
#patch h4 {font-family: \
verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
 #patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff  {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, \
#patch .copfile {border:1px solid #ccc;margin:10px 0;} #patch ins \
{background:#dfd;text-decoration:none;display:block;padding:0 10px;} #patch del \
{background:#fdd;text-decoration:none;display:block;padding:0 10px;} #patch .lines, \
                .info {color:#888;background:#fff;}
--></style>
<title>[31911] trunk/WebKit/mac</title>
</head>
<body>

<div id="msg">
<dl>
<dt>Revision</dt> <dd><a \
href="http://trac.webkit.org/projects/webkit/changeset/31911">31911</a></dd> \
<dt>Author</dt> <dd>beidson@apple.com</dd> <dt>Date</dt> <dd>2008-04-15 10:54:18 \
-0700 (Tue, 15 Apr 2008)</dd> </dl>

<h3>Log Message</h3>
<pre>2008-04-15  Brady Eidson  &lt;beidson@apple.com&gt;

        Reviewed by John Sullivan

        Do a more complete job adding the &quot;WebArchiveDebugMode&quot; pref

        * WebView/WebPreferences.m: Add both getter *and* setter
        (-[WebPreferences webArchiveDebugModeEnabled]):
        (-[WebPreferences setWebArchiveDebugModeEnabled:]):
        * WebView/WebPreferencesPrivate.h:

        * WebView/WebView.mm:
        (-[WebView _preferencesChangedNotification:]): Call the renamed getter</pre>

<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkWebKitmacChangeLog">trunk/WebKit/mac/ChangeLog</a></li>
<li><a href="#trunkWebKitmacWebViewWebPreferencesm">trunk/WebKit/mac/WebView/WebPreferences.m</a></li>
 <li><a href="#trunkWebKitmacWebViewWebPreferencesPrivateh">trunk/WebKit/mac/WebView/WebPreferencesPrivate.h</a></li>
 <li><a href="#trunkWebKitmacWebViewWebViewmm">trunk/WebKit/mac/WebView/WebView.mm</a></li>
 </ul>

</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkWebKitmacChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/WebKit/mac/ChangeLog (31910 => 31911)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/WebKit/mac/ChangeLog	2008-04-15 17:24:22 UTC (rev 31910)
+++ trunk/WebKit/mac/ChangeLog	2008-04-15 17:54:18 UTC (rev 31911)
</span><span class="lines">@@ -1,3 +1,17 @@
</span><ins>+2008-04-15  Brady Eidson  &lt;beidson@apple.com&gt;
+
+        Reviewed by John Sullivan
+
+        Do a more complete job adding the &quot;WebArchiveDebugMode&quot; pref
+
+        * WebView/WebPreferences.m: Add both getter *and* setter
+        (-[WebPreferences webArchiveDebugModeEnabled]):
+        (-[WebPreferences setWebArchiveDebugModeEnabled:]):
+        * WebView/WebPreferencesPrivate.h:
+
+        * WebView/WebView.mm:
+        (-[WebView _preferencesChangedNotification:]): Call the renamed getter
+
</ins><span class="cx"> 2008-04-14  Brady Eidson  &lt;beidson@apple.com&gt;
</span><span class="cx"> 
</span><span class="cx">         Reviewed by Anders
</span></span></pre></div>
<a id="trunkWebKitmacWebViewWebPreferencesm"></a>
<div class="modfile"><h4>Modified: trunk/WebKit/mac/WebView/WebPreferences.m (31910 \
=> 31911)</h4> <pre class="diff"><span>
<span class="info">--- trunk/WebKit/mac/WebView/WebPreferences.m	2008-04-15 17:24:22 \
                UTC (rev 31910)
+++ trunk/WebKit/mac/WebView/WebPreferences.m	2008-04-15 17:54:18 UTC (rev 31911)
</span><span class="lines">@@ -751,14 +751,19 @@
</span><span class="cx">     return [self \
_boolValueForKey:WebKitAuthorAndUserStylesEnabledPreferenceKey]; </span><span \
class="cx"> } </span><span class="cx"> 
</span><del>-- (BOOL)_webArchiveDebugModeEnabled
</del><ins>+- (void)setAuthorAndUserStylesEnabled:(BOOL)flag
</ins><span class="cx"> {
</span><ins>+    [self _setBoolValue:flag \
forKey:WebKitAuthorAndUserStylesEnabledPreferenceKey]; +}
+
+- (BOOL)webArchiveDebugModeEnabled
+{
</ins><span class="cx">     return [self \
_boolValueForKey:WebKitWebArchiveDebugModeEnabledPreferenceKey]; </span><span \
class="cx"> } </span><span class="cx"> 
</span><del>-- (void)setAuthorAndUserStylesEnabled:(BOOL)flag
</del><ins>+- (void)setWebArchiveDebugModeEnabled:(BOOL)flag
</ins><span class="cx"> {
</span><del>-    [self _setBoolValue:flag \
forKey:WebKitAuthorAndUserStylesEnabledPreferenceKey]; </del><ins>+    [self \
_setBoolValue:flag forKey:WebKitWebArchiveDebugModeEnabledPreferenceKey]; </ins><span \
class="cx"> } </span><span class="cx"> 
</span><span class="cx"> - (BOOL)respectStandardStyleKeyEquivalents
</span></span></pre></div>
<a id="trunkWebKitmacWebViewWebPreferencesPrivateh"></a>
<div class="modfile"><h4>Modified: trunk/WebKit/mac/WebView/WebPreferencesPrivate.h \
(31910 => 31911)</h4> <pre class="diff"><span>
<span class="info">--- trunk/WebKit/mac/WebView/WebPreferencesPrivate.h	2008-04-15 \
                17:24:22 UTC (rev 31910)
+++ trunk/WebKit/mac/WebView/WebPreferencesPrivate.h	2008-04-15 17:54:18 UTC (rev \
31911) </span><span class="lines">@@ -68,6 +68,9 @@
</span><span class="cx"> - (BOOL)automaticallyDetectsCacheModel;
</span><span class="cx"> - \
(void)setAutomaticallyDetectsCacheModel:(BOOL)automaticallyDetectsCacheModel; \
</span><span class="cx">  </span><ins>+- (BOOL)webArchiveDebugModeEnabled;
+- (void)setWebArchiveDebugModeEnabled:(BOOL)webArchiveDebugModeEnabled;
+
</ins><span class="cx"> // zero means do AutoScale
</span><span class="cx"> - (float)PDFScaleFactor;
</span><span class="cx"> - (void)setPDFScaleFactor:(float)scale;
</span><span class="lines">@@ -90,8 +93,6 @@
</span><span class="cx"> - (void)_setForceFTPDirectoryListings:(BOOL)force;
</span><span class="cx"> - (BOOL)_forceFTPDirectoryListings;
</span><span class="cx"> 
</span><del>-- (BOOL)_webArchiveDebugModeEnabled;
-
</del><span class="cx"> // Other private methods
</span><span class="cx"> - (void)_postPreferencesChangesNotification;
</span><span class="cx"> + (WebPreferences *)_getInstanceForIdentifier:(NSString \
*)identifier; </span></span></pre></div>
<a id="trunkWebKitmacWebViewWebViewmm"></a>
<div class="modfile"><h4>Modified: trunk/WebKit/mac/WebView/WebView.mm (31910 => \
31911)</h4> <pre class="diff"><span>
<span class="info">--- trunk/WebKit/mac/WebView/WebView.mm	2008-04-15 17:24:22 UTC \
                (rev 31910)
+++ trunk/WebKit/mac/WebView/WebView.mm	2008-04-15 17:54:18 UTC (rev 31911)
</span><span class="lines">@@ -983,7 +983,7 @@
</span><span class="cx">     settings-&gt;setNeedsAdobeFrameReloadingQuirk([self \
_needsAdobeFrameReloadingQuirk]); </span><span class="cx">     \
settings-&gt;setNeedsKeyboardEventDisambiguationQuirks([self \
_needsKeyboardEventDisambiguationQuirks]); </span><span class="cx">     \
settings-&gt;setNeedsSiteSpecificQuirks(_private-&gt;useSiteSpecificSpoofing); \
</span><del>-    settings-&gt;setWebArchiveDebugModeEnabled([preferences \
_webArchiveDebugModeEnabled]); </del><ins>+    \
settings-&gt;setWebArchiveDebugModeEnabled([preferences webArchiveDebugModeEnabled]); \
</ins><span class="cx"> } </span><span class="cx"> 
</span><span class="cx"> static inline IMP getMethod(id o, SEL s)
</span></span></pre>
</div>
</div>

</body>
</html>



_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes


[prev in list] [next in list] [prev in thread] [next in thread]

Configure | About | News | Add a list | Sponsored by KoreLogic