'Re: [vtk-developers] Integer overflow when clipping large volumes'

[prev in list] [next in list] [prev in thread] [next in thread] 

List: vtk-developers
Subject: Re: [vtk-developers] Integer overflow when clipping large volumes
From: Dan Lipsa <dan.lipsa () kitware ! com>
Date: 2018-08-25 0:34:02
Message-ID: CADwGrVpTi6Wb=FKYUzowwZ91i3Ludz0NjMc4p+xJ9_6GBU8gGQ () mail ! gmail ! com
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

Its merged.

On Fri, Aug 24, 2018 at 7:11 PM Dan Lipsa <dan.lipsa@kitware.com> wrote:

> Steven,
> Thanks for your contribution! Your change makes sense. I'll merge it when
> the tests finish.
>
> Dan
>
>
> On Fri, Aug 24, 2018 at 7:01 PM Hahn, Steven E. <hahnse@ornl.gov> wrote:
>
>> I encountered a segmentation fault when attempting to clip a stack of
>> tiffs (vtkImageData) in ParaView and, using the undefined behavior
>> sanitizer, tracked it down to integer overflow in vtkTableBasedClipDataSet.
>> Changing several variables from int to vtkIdType seems to correct the
>> problem.
>>
>>
>>
>> I opened a merge request with these changes and a python file to
>> reproduce the issue. The primary contributor to
>> vtkTableBasedClipDataSet.cxx isn't on the GitLab site, so I'm not sure who
>> to tag. Is someone else interested in reviewing it?
>>
>>
>>
>> https://gitlab.kitware.com/vtk/vtk/merge_requests/4620
>>
>>
>>
>> Steven
>> _______________________________________________
>> Powered by www.kitware.com
>>
>> Visit other Kitware open-source projects at
>> http://www.kitware.com/opensource/opensource.html
>>
>> Search the list archives at: http://markmail.org/search/?q=vtk-developers
>>
>> Follow this link to subscribe/unsubscribe:
>> https://public.kitware.com/mailman/listinfo/vtk-developers
>>
>>

[Attachment #5 (text/html)]

<div dir="ltr">Its merged.</div><br><div class="gmail_quote"><div dir="ltr">On Fri, \
Aug 24, 2018 at 7:11 PM Dan Lipsa &lt;<a \
href="mailto:dan.lipsa@kitware.com">dan.lipsa@kitware.com</a>&gt; \
wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 \
.8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">Steven,<div>Thanks \
for your contribution! Your change makes sense. I&#39;ll merge it when the tests \
finish.</div><div><br></div><div>Dan</div><div><br></div></div><br><div \
class="gmail_quote"><div dir="ltr">On Fri, Aug 24, 2018 at 7:01 PM Hahn, Steven E. \
&lt;<a href="mailto:hahnse@ornl.gov" target="_blank">hahnse@ornl.gov</a>&gt; \
wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 \
.8ex;border-left:1px #ccc solid;padding-left:1ex">

<div lang="EN-US" link="#0563C1" vlink="#954F72">
<div class="m_1195895559209247382m_-5504461550486690474WordSection1">
I encountered a segmentation \
fault when attempting to clip a stack of tiffs (vtkImageData) in ParaView and, using \
the undefined behavior sanitizer, tracked it down to integer overflow in \
vtkTableBasedClipDataSet. Changing several variables from int to vtkIdType seems to \
correct the problem. I opened a merge request with these changes and a python \
file to reproduce the issue. The primary contributor to vtkTableBasedClipDataSet.cxx \
isn't on the GitLab site, so I'm not sure who to tag. Is someone else interested in \
reviewing it? <a \
href="https://gitlab.kitware.com/vtk/vtk/merge_requests/4620" \
target="_blank">https://gitlab.kitware.com/vtk/vtk/merge_requests/4620</a>
 
Steven
</div>
</div>

_______________________________________________<br>
Powered by <a href="http://www.kitware.com" rel="noreferrer" \
target="_blank">www.kitware.com</a><br> <br>
Visit other Kitware open-source projects at <a \
href="http://www.kitware.com/opensource/opensource.html" rel="noreferrer" \
target="_blank">http://www.kitware.com/opensource/opensource.html</a><br> <br>
Search the list archives at: <a href="http://markmail.org/search/?q=vtk-developers" \
rel="noreferrer" target="_blank">http://markmail.org/search/?q=vtk-developers</a><br> \
<br> Follow this link to subscribe/unsubscribe:<br>
<a href="https://public.kitware.com/mailman/listinfo/vtk-developers" rel="noreferrer" \
target="_blank">https://public.kitware.com/mailman/listinfo/vtk-developers</a><br> \
<br> </blockquote></div>
</blockquote></div>

_______________________________________________
Powered by www.kitware.com

Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html

Search the list archives at: http://markmail.org/search/?q=vtk-developers

Follow this link to subscribe/unsubscribe:
https://public.kitware.com/mailman/listinfo/vtk-developers

[prev in list] [next in list] [prev in thread] [next in thread] 