[prev in list] [next in list] [prev in thread] [next in thread]
List: vtk-developers
Subject: Re: [vtk-developers] Adding a GIL ensure call before all call to python
From: Mathieu Westphal <mathieu.westphal () kitware ! com>
Date: 2015-11-23 13:48:53
Message-ID: CAC2t4UR8A7vXMrCX1rGC0xn3nb5ztN9WYpR68PbM6xS9giZVBw () mail ! gmail ! com
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
Hi
I have a fully tested gil branch, can someone review it and upvote if it's
ok ?
Thx.
https://gitlab.kitware.com/vtk/vtk/merge_requests/582
Mathieu Westphal
On Tue, Jul 7, 2015 at 8:30 AM, Mathieu Westphal <
mathieu.westphal@kitware.com> wrote:
> Ok, so we may add another option in cmake like :
> VTK_PYTHON_GIL_EVERYWHERE, so it will not break anything.
>
>
>
>
> Mathieu Westphal
>
> On Fri, Jul 3, 2015 at 3:59 PM, David E DeMarle <dave.demarle@kitware.com>
> wrote:
>
>> This was the commit I was referring to.
>> http://review.source.kitware.com/#/c/11214/
>>
>> David E DeMarle
>> Kitware, Inc.
>> R&D Engineer
>> 21 Corporate Drive
>> Clifton Park, NY 12065-8662
>> Phone: 518-881-4909
>>
>> On Fri, Jul 3, 2015 at 8:47 AM, David E DeMarle <dave.demarle@kitware.com
>> > wrote:
>>
>>> Careful there. We took something very much like that out at ParaView
>>> 4.0. The GIL made ParaView incompatible with many python packages. When I
>>> get to my desk I can check my notes and refresh my memory.
>>> On Jul 3, 2015 5:56 AM, "Mathieu Westphal" <mathieu.westphal@kitware.com>
>>> wrote:
>>>
>>>> A client requesting us to apply a patch to paraview so every single
>>>> call to python
>>>> (PyRun, Py_Decref, PyImport, PyObject, PyString... ) to be surrounded by
>>>> PyGILState_Ensure
>>>> PyGILState_Release
>>>>
>>>> if VTK_NO_PYTHON_THREADS is not defined.
>>>>
>>>> is this acceptable ? some python calls are already done like that, see
>>>> vtkPythonUtil.cxx.
>>>>
>>>> This option is defined to 1 by default.
>>>>
>>>>
>>>> Mathieu Westphal
>>>>
>>>> _______________________________________________
>>>> Powered by www.kitware.com
>>>>
>>>> Visit other Kitware open-source projects at
>>>> http://www.kitware.com/opensource/opensource.html
>>>>
>>>> Search the list archives at:
>>>> http://markmail.org/search/?q=vtk-developers
>>>>
>>>> Follow this link to subscribe/unsubscribe:
>>>> http://public.kitware.com/mailman/listinfo/vtk-developers
>>>>
>>>>
>>>>
>>
>
[Attachment #5 (text/html)]
<div dir="ltr"><div>Hi</div><div><br></div>I have a fully tested gil branch, can \
someone review it and upvote if it's ok \
?<div><br></div><div>Thx.</div><div><br></div><div><a \
href="https://gitlab.kitware.com/vtk/vtk/merge_requests/582">https://gitlab.kitware.com/vtk/vtk/merge_requests/582</a><br></div></div><div \
class="gmail_extra"><br clear="all"><div><div class="gmail_signature"><div \
dir="ltr">Mathieu Westphal<br></div></div></div> <br><div class="gmail_quote">On Tue, \
Jul 7, 2015 at 8:30 AM, Mathieu Westphal <span dir="ltr"><<a \
href="mailto:mathieu.westphal@kitware.com" \
target="_blank">mathieu.westphal@kitware.com</a>></span> wrote:<br><blockquote \
class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc \
solid;padding-left:1ex"><div dir="ltr"><div><div>Ok, so we may add another option in \
cmake like :<br></div>VTK_PYTHON_GIL_EVERYWHERE, so it will not break anything.<span \
class="HOEnZb"><font color="#888888"><br><br><br><br></font></span></div></div><div \
class="gmail_extra"><span class="HOEnZb"><font color="#888888"><br \
clear="all"><div><div><div dir="ltr">Mathieu \
Westphal<br></div></div></div></font></span><div><div class="h5"> <br><div \
class="gmail_quote">On Fri, Jul 3, 2015 at 3:59 PM, David E DeMarle <span \
dir="ltr"><<a href="mailto:dave.demarle@kitware.com" \
target="_blank">dave.demarle@kitware.com</a>></span> wrote:<br><blockquote \
class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc \
solid;padding-left:1ex"><div dir="ltr">This was the commit I was referring to.<div><a \
href="http://review.source.kitware.com/#/c/11214/" \
target="_blank">http://review.source.kitware.com/#/c/11214/</a><span><font \
color="#888888"><br></font></span></div></div><div class="gmail_extra"><span><font \
color="#888888"><br clear="all"><div><div>David E DeMarle<br>Kitware, Inc.<br>R&D \
Engineer<br>21 Corporate Drive<br>Clifton Park, NY 12065-8662<br>Phone: <a \
href="tel:518-881-4909" value="+15188814909" \
target="_blank">518-881-4909</a></div></div></font></span><div><div> <br><div \
class="gmail_quote">On Fri, Jul 3, 2015 at 8:47 AM, David E DeMarle <span \
dir="ltr"><<a href="mailto:dave.demarle@kitware.com" \
target="_blank">dave.demarle@kitware.com</a>></span> wrote:<br><blockquote \
class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc \
solid;padding-left:1ex"><p>Careful there. We took something very much like that out \
at ParaView 4.0. The GIL made ParaView incompatible with many python packages. When I \
get to my desk I can check my notes and refresh my memory.</p> <div \
class="gmail_quote"><div><div>On Jul 3, 2015 5:56 AM, "Mathieu Westphal" \
<<a href="mailto:mathieu.westphal@kitware.com" \
target="_blank">mathieu.westphal@kitware.com</a>> wrote:<br \
type="attribution"></div></div><blockquote class="gmail_quote" style="margin:0 0 0 \
.8ex;border-left:1px #ccc solid;padding-left:1ex"><div><div><div \
dir="ltr"><div><div>A client requesting us to apply a patch to paraview so every \
single call to python<br></div>(PyRun, Py_Decref, PyImport, PyObject, PyString... ) \
to be surrounded by<br>PyGILState_Ensure<br>PyGILState_Release<br><br>if \
VTK_NO_PYTHON_THREADS is not defined.<br><br></div><div>is this acceptable ? some \
python calls are already done like that, see \
vtkPythonUtil.cxx.<br></div><div><br>This option is defined to 1 by \
default.<br></div><br><div><br clear="all"><div><div><div><div><div dir="ltr">Mathieu \
Westphal<br></div></div></div> </div></div></div></div>
<br></div></div>_______________________________________________<br>
Powered by <a href="http://www.kitware.com" rel="noreferrer" \
target="_blank">www.kitware.com</a><br> <br>
Visit other Kitware open-source projects at <a \
href="http://www.kitware.com/opensource/opensource.html" rel="noreferrer" \
target="_blank">http://www.kitware.com/opensource/opensource.html</a><br> <br>
Search the list archives at: <a href="http://markmail.org/search/?q=vtk-developers" \
rel="noreferrer" target="_blank">http://markmail.org/search/?q=vtk-developers</a><br> \
<br> Follow this link to subscribe/unsubscribe:<br>
<a href="http://public.kitware.com/mailman/listinfo/vtk-developers" rel="noreferrer" \
target="_blank">http://public.kitware.com/mailman/listinfo/vtk-developers</a><br> \
<br> <br></blockquote></div>
</blockquote></div><br></div></div></div>
</blockquote></div><br></div></div></div>
</blockquote></div><br></div>
_______________________________________________
Powered by www.kitware.com
Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html
Search the list archives at: http://markmail.org/search/?q=vtk-developers
Follow this link to subscribe/unsubscribe:
http://public.kitware.com/mailman/listinfo/vtk-developers
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic