[prev in list] [next in list] [prev in thread] [next in thread] 

List:       vtk-developers
Subject:    Re: [vtk-developers] New WRAP_EXCLUDE_PYTHON
From:       David Gobbi <david.gobbi () gmail ! com>
Date:       2015-09-23 16:28:42
Message-ID: CANwS1=GsRyi7+MyDcCb8qPXrOSispqyj2nO0pk9ftRZvYOGC2Q () mail ! gmail ! com
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]


On Wed, Sep 23, 2015 at 8:00 AM, David Lonie <david.lonie@kitware.com>
wrote:

> On Wed, Sep 23, 2015 at 8:41 AM, David Gobbi <david.gobbi@gmail.com>
> wrote:
>
>> The wrapping has identified a few classes that break the "rule of three":
>> https://open.cdash.org/viewBuildError.php?type=1&buildid=4025415
>>
>> I'll see if I can fix these, but I might need to seek advice on some of
>> them.
>>
>
> vtkFreeTypeToolsCleanup is the one I'm familiar with, and it can just have
> an empty copy constructor as it's stateless.
>

It has a public constructor, so it can potentially have multiple
instances.  I added a counter to make sure it doesn't
call SetInstance(NULL) until all instances have destructed.
https://gitlab.kitware.com/vtk/vtk/merge_requests/686

 - David

[Attachment #5 (text/html)]

<div dir="ltr"><div class="gmail_extra"><div class="gmail_quote">On Wed, Sep 23, 2015 \
at 8:00 AM, David Lonie <span dir="ltr">&lt;<a href="mailto:david.lonie@kitware.com" \
target="_blank">david.lonie@kitware.com</a>&gt;</span> wrote:<br><blockquote \
class="gmail_quote" style="margin:0px 0px 0px \
0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex"><div \
dir="ltr"><div class="gmail_extra"><div class="gmail_quote"><span class="">On Wed, \
Sep 23, 2015 at 8:41 AM, David Gobbi <span dir="ltr">&lt;<a \
href="mailto:david.gobbi@gmail.com" \
target="_blank">david.gobbi@gmail.com</a>&gt;</span> wrote:<br><blockquote \
class="gmail_quote" style="margin:0px 0px 0px \
0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex"><div \
dir="ltr">The wrapping has identified a few classes that break the &quot;rule of \
three&quot;:<div><a href="https://open.cdash.org/viewBuildError.php?type=1&amp;buildid=4025415" \
target="_blank">https://open.cdash.org/viewBuildError.php?type=1&amp;buildid=4025415</a><br></div><div><br></div><div>I&#39;ll \
see if I can fix these, but I might need to seek advice on some of \
them.</div></div></blockquote><div><br></div></span>vtkFreeTypeToolsCleanup is the \
one I&#39;m familiar with, and it can just have an empty copy constructor as it&#39;s \
stateless.</div></div></div></blockquote><div><br></div><div>It has a public \
constructor, so it can potentially have multiple instances.   I added a counter to \
make sure it doesn&#39;t call  SetInstance(NULL) until all instances have \
destructed.</div><div><a \
href="https://gitlab.kitware.com/vtk/vtk/merge_requests/686">https://gitlab.kitware.com/vtk/vtk/merge_requests/686</a></div><div><br></div><div> \
- David  </div></div></div></div>



_______________________________________________
Powered by www.kitware.com

Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html

Search the list archives at: http://markmail.org/search/?q=vtk-developers

Follow this link to subscribe/unsubscribe:
http://public.kitware.com/mailman/listinfo/vtk-developers



[prev in list] [next in list] [prev in thread] [next in thread]