[prev in list] [next in list] [prev in thread] [next in thread] 

List:       vtk-developers
Subject:    Re: [vtk-developers] PROPOSAL: Changing VTK's indentation style
From:       Andrew Maclean <andrew.amaclean () gmail ! com>
Date:       2015-09-11 2:37:45
Message-ID: CAHDsG9OJYsC_wjQK80WGpaJbXEqUGJVQ6Q+wVozq_DGZ9m4A4A () mail ! gmail ! com
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]


Sorry I thought you did enforce the brace style using hooks ( I hadn't
looked), if so then it is even easier!

On Fri, Sep 11, 2015 at 11:16 AM, Ben Boeckel <ben.boeckel@kitware.com>
wrote:

> On Fri, Sep 11, 2015 at 10:13:37 +1000, Andrew Maclean wrote:
> > 2) git blame needs to be able to cope with the changes.
>
> git blame can be told to ignore whitespace-only changes to a line (-w).
>
> > 3) The git hooks need changing.
>
> In what way? We've never enforced brace-style using hooks. Or at least
> we don't now.
>
> > 4) All the existing code needs to be retroformatted. Presumably you will
> > write a script to do this. It would be a good idea to add this script
> > (python?) to Utilities so that the Slicer people and others can easily
> > reformat their code if so desired.
>
> Yeah, committing the tool would be good.
>
> --Ben
>



-- 
___________________________________________
Andrew J. P. Maclean

___________________________________________

[Attachment #5 (text/html)]

<div dir="ltr">Sorry I thought you did enforce the brace style using hooks ( I \
hadn&#39;t looked), if so then it is even easier!</div><div \
class="gmail_extra"><br><div class="gmail_quote">On Fri, Sep 11, 2015 at 11:16 AM, \
Ben Boeckel <span dir="ltr">&lt;<a href="mailto:ben.boeckel@kitware.com" \
target="_blank">ben.boeckel@kitware.com</a>&gt;</span> wrote:<br><blockquote \
class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc \
solid;padding-left:1ex"><span class="">On Fri, Sep 11, 2015 at 10:13:37 +1000, Andrew \
Maclean wrote:<br> &gt; 2) git blame needs to be able to cope with the changes.<br>
<br>
</span>git blame can be told to ignore whitespace-only changes to a line (-w).<br>
<span class=""><br>
&gt; 3) The git hooks need changing.<br>
<br>
</span>In what way? We&#39;ve never enforced brace-style using hooks. Or at least<br>
we don&#39;t now.<br>
<span class=""><br>
&gt; 4) All the existing code needs to be retroformatted. Presumably you will<br>
&gt; write a script to do this. It would be a good idea to add this script<br>
&gt; (python?) to Utilities so that the Slicer people and others can easily<br>
&gt; reformat their code if so desired.<br>
<br>
</span>Yeah, committing the tool would be good.<br>
<span class="HOEnZb"><font color="#888888"><br>
--Ben<br>
</font></span></blockquote></div><br><br clear="all"><div><br></div>-- <br><div \
class="gmail_signature">___________________________________________<br>Andrew J. P. \
Maclean<br><br>___________________________________________</div> </div>



_______________________________________________
Powered by www.kitware.com

Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html

Search the list archives at: http://markmail.org/search/?q=vtk-developers

Follow this link to subscribe/unsubscribe:
http://public.kitware.com/mailman/listinfo/vtk-developers



[prev in list] [next in list] [prev in thread] [next in thread]