[prev in list] [next in list] [prev in thread] [next in thread]
List: vtk-developers
Subject: Re: [vtk-developers] [EXTERNAL] PROPOSAL: Changing VTK's indentation style
From: "Scott, W Alan" <wascott () sandia ! gov>
Date: 2015-09-09 16:51:09
Message-ID: 2627d2862dd84849892904adaf0e4ca4 () ES01AMSNLNT ! srn ! sandia ! gov
[Download RAW message or body]
[Attachment #2 (text/plain)]
I have never liked the current indent style, and have always used and liked the one you propose.
Alan
From: vtk-developers [mailto:vtk-developers-bounces@vtk.org] On Behalf Of Berk Geveci
Sent: Wednesday, September 09, 2015 7:09 AM
To: VTK Developers
Subject: [EXTERNAL] [vtk-developers] PROPOSAL: Changing VTK's indentation style
Hi folks,
What would you think of changing VTK's indentation style from:
if ()
{
// ..
}
to
if ()
{
// ...
}
?
Our current style (modified Whitesmiths I am told) is used only by very few projects,
mostly related to VTK ones (ITK, CMake). It is poorly supported by some of the newer editors
that are widely popular (Sublime, TextMate etc.) and IMO foreign to the new generation
C++ developers.
The style I propose is modified Allman style - with indentation changed from 4 to 2 spaces.
It is much more common.
If approved by the community, we would change VTK wholesale. This should not be
an issue for history as git blame/annotate can be told to skip white spaces.
Best,
-berk
[Attachment #3 (text/html)]
<html xmlns:v="urn:schemas-microsoft-com:vml" \
xmlns:o="urn:schemas-microsoft-com:office:office" \
xmlns:w="urn:schemas-microsoft-com:office:word" \
xmlns:m="http://schemas.microsoft.com/office/2004/12/omml" \
xmlns="http://www.w3.org/TR/REC-html40"> <head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8">
<meta name="Generator" content="Microsoft Word 14 (filtered medium)">
<style><!--
/* Font Definitions */
@font-face
{font-family:Calibri;
panose-1:2 15 5 2 2 2 4 3 2 4;}
@font-face
{font-family:Tahoma;
panose-1:2 11 6 4 3 5 4 4 2 4;}
/* Style Definitions */
p.MsoNormal, li.MsoNormal, div.MsoNormal
{margin:0in;
margin-bottom:.0001pt;
font-size:12.0pt;
font-family:"Times New Roman","serif";}
a:link, span.MsoHyperlink
{mso-style-priority:99;
color:blue;
text-decoration:underline;}
a:visited, span.MsoHyperlinkFollowed
{mso-style-priority:99;
color:purple;
text-decoration:underline;}
span.EmailStyle17
{mso-style-type:personal-reply;
font-family:"Calibri","sans-serif";
color:#1F497D;}
.MsoChpDefault
{mso-style-type:export-only;
font-family:"Calibri","sans-serif";}
@page WordSection1
{size:8.5in 11.0in;
margin:1.0in 1.0in 1.0in 1.0in;}
div.WordSection1
{page:WordSection1;}
--></style><!--[if gte mso 9]><xml>
<o:shapedefaults v:ext="edit" spidmax="1026" />
</xml><![endif]--><!--[if gte mso 9]><xml>
<o:shapelayout v:ext="edit">
<o:idmap v:ext="edit" data="1" />
</o:shapelayout></xml><![endif]-->
</head>
<body lang="EN-US" link="blue" vlink="purple">
<div class="WordSection1">
<p class="MsoNormal"><span \
style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D">I \
have never liked the current indent style, and have always used and liked the one you \
propose.<o:p></o:p></span></p> <p class="MsoNormal"><span \
style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D"><o:p> </o:p></span></p>
<p class="MsoNormal"><span \
style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D">Alan<o:p></o:p></span></p>
<p class="MsoNormal"><span \
style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D"><o:p> </o:p></span></p>
<p class="MsoNormal"><b><span \
style="font-size:10.0pt;font-family:"Tahoma","sans-serif"">From:</span></b><span \
style="font-size:10.0pt;font-family:"Tahoma","sans-serif""> \
vtk-developers [mailto:vtk-developers-bounces@vtk.org] <b>On Behalf Of </b>Berk \
Geveci<br> <b>Sent:</b> Wednesday, September 09, 2015 7:09 AM<br>
<b>To:</b> VTK Developers<br>
<b>Subject:</b> [EXTERNAL] [vtk-developers] PROPOSAL: Changing VTK's indentation \
style<o:p></o:p></span></p> <p class="MsoNormal"><o:p> </o:p></p>
<div>
<p class="MsoNormal">Hi folks,<o:p></o:p></p>
<div>
<p class="MsoNormal"><o:p> </o:p></p>
</div>
<div>
<div>
<p class="MsoNormal"><span style="font-size:9.5pt">What would you think of changing \
VTK's indentation style from:<o:p></o:p></span></p> </div>
<div>
<p class="MsoNormal"><span style="font-size:9.5pt"><o:p> </o:p></span></p>
</div>
<div>
<div>
<p class="MsoNormal"><span style="font-size:9.5pt">if ()<o:p></o:p></span></p>
</div>
<div>
<p class="MsoNormal"><span style="font-size:9.5pt"> {<o:p></o:p></span></p>
</div>
<div>
<p class="MsoNormal"><span style="font-size:9.5pt"> // ..<o:p></o:p></span></p>
</div>
<div>
<p class="MsoNormal"><span style="font-size:9.5pt"> }<o:p></o:p></span></p>
</div>
<div>
<p class="MsoNormal"><span style="font-size:9.5pt"><o:p> </o:p></span></p>
</div>
<div>
<p class="MsoNormal"><span style="font-size:9.5pt">to<o:p></o:p></span></p>
</div>
<div>
<p class="MsoNormal"><span style="font-size:9.5pt"><o:p> </o:p></span></p>
</div>
<div>
<p class="MsoNormal"><span style="font-size:9.5pt">if ()<o:p></o:p></span></p>
</div>
<div>
<p class="MsoNormal"><span style="font-size:9.5pt">{<o:p></o:p></span></p>
</div>
<div>
<p class="MsoNormal"><span style="font-size:9.5pt"> // \
...<o:p></o:p></span></p> </div>
<div>
<p class="MsoNormal"><span style="font-size:9.5pt">}<o:p></o:p></span></p>
</div>
<div>
<p class="MsoNormal"><span style="font-size:9.5pt"><o:p> </o:p></span></p>
</div>
<div>
<p class="MsoNormal"><span style="font-size:9.5pt">?<o:p></o:p></span></p>
</div>
<div>
<p class="MsoNormal"><span style="font-size:9.5pt"><o:p> </o:p></span></p>
</div>
<div>
<p class="MsoNormal"><span style="font-size:9.5pt">Our current style (modified \
Whitesmiths I am told) is used only by very few projects,<o:p></o:p></span></p> \
</div> <div>
<p class="MsoNormal"><span style="font-size:9.5pt">mostly related to VTK ones (ITK, \
CMake). It is poorly supported by some of the newer editors<o:p></o:p></span></p> \
</div> <div>
<p class="MsoNormal"><span style="font-size:9.5pt">that are widely popular (Sublime, \
TextMate etc.) and IMO foreign to the new generation<o:p></o:p></span></p> </div>
<div>
<p class="MsoNormal"><span style="font-size:9.5pt">C++ \
developers.<o:p></o:p></span></p> </div>
<div>
<p class="MsoNormal"><span style="font-size:9.5pt"><o:p> </o:p></span></p>
</div>
<div>
<p class="MsoNormal"><span style="font-size:9.5pt">The style I propose is modified \
Allman style - with indentation changed from 4 to 2 spaces.<o:p></o:p></span></p> \
</div> <div>
<p class="MsoNormal"><span style="font-size:9.5pt">It is much more \
common.<o:p></o:p></span></p> </div>
<div>
<p class="MsoNormal"><span style="font-size:9.5pt"><o:p> </o:p></span></p>
</div>
<div>
<p class="MsoNormal"><span style="font-size:9.5pt">If approved by the community, we \
would change VTK wholesale. This should not be<o:p></o:p></span></p> </div>
<div>
<p class="MsoNormal"><span style="font-size:9.5pt">an issue for history as git \
blame/annotate can be told to skip white spaces.<o:p></o:p></span></p> </div>
<div>
<p class="MsoNormal"><span style="font-size:9.5pt"><o:p> </o:p></span></p>
</div>
<div>
<p class="MsoNormal"><span style="font-size:9.5pt">Best,<o:p></o:p></span></p>
</div>
<div>
<p class="MsoNormal"><span style="font-size:9.5pt">-berk<o:p></o:p></span></p>
</div>
</div>
</div>
</div>
</div>
</body>
</html>
_______________________________________________
Powered by www.kitware.com
Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html
Search the list archives at: http://markmail.org/search/?q=vtk-developers
Follow this link to subscribe/unsubscribe:
http://public.kitware.com/mailman/listinfo/vtk-developers
--===============1872906507==--
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic