[prev in list] [next in list] [prev in thread] [next in thread]
List: vtk-developers
Subject: [vtk-developers] Fwd: New valgrind defect after checkins on July 11
From: Bill Lorensen <bill.lorensen () gmail ! com>
Date: 2013-07-28 11:44:17
Message-ID: CADZJ4hNR9EO0fr3M=EDEDATGB+zBKR3JDF4Ed+WoZ9AYwWEBUw () mail ! gmail ! com
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
---------- Forwarded message ----------
From: Burlen Loring <burlen.loring@gmail.com>
Date: Sat, Jul 27, 2013 at 7:02 PM
Subject: Re: [vtk-developers] New valgrind defect after checkins on July 11
To: Bill Lorensen <bill.lorensen@gmail.com>
Hi Bill,
Thanks for waiting for me to finish my last patch. I wasn't sure if it
would change the path through this test since it disabled some OpenGL
features for Mesa 7. It looks like we need a suppression for these errors.
I've copied the suppressions from the test output into a new patch,
http://review.source.kitware.com/#/c/12115/. I wouldn't want to merge it
without trying it first, would you (or anyone who has access to karego)
mind verifying that this fixes the issue?
Thank you
Burlen
On 7/19/2013 10:22 AM, Bill Lorensen wrote:
Burlen,
No problem. I just did not want to have it fall through the cracks.
Vacation is a much higher priority for sure.
Being retired, I'm always on vacation.
Regards,
Bill
On Fri, Jul 19, 2013 at 1:15 PM, Burlen Loring <burlen.loring@gmail.com>wrote:
> Hi Bill,
>
> That would be mine. I commited a change that enabled OpenGL features (eg
> FBO) for Mesa that were previously unconditionally disabled regardless of
> if the driver supported it or not. I've been cleaning dashboard failures
> that popped up after my patch and looking at features that were disabled
> because of Mesa specific bugs this week and have a patch that addresses a
> number of them, http://review.source.kitware.com/#/c/11985/. It's been
> reviewed and I have to make another pass over it to address some minor
> issues that reviewers found. I am on vacation today and will be away until
> Monday. On Monday I plan to make the changes to my patch and merge asap
> (once reviewers are satisfied). This patch may fix the valgrind issues, but
> if not I will add an suppression since the error reported by valgrind is in
> Mesa not VTK.
>
> Thanks for being patient, my vacation is planned at an inconvenient time!
> Burlen
>
>
> On 7/19/2013 5:13 AM, Bill Lorensen wrote:
>
> Folks,
>
> There were 86 files changed on July 11:
> http://open.cdash.org/index.php?project=VTK&date=2013-07-12
>
> This valgrind defect appeared:
> http://open.cdash.org/viewDynamicAnalysisFile.php?id=2973840
>
> Bill
>
>
>
>
> _______________________________________________
> Powered by www.kitware.com
>
> Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html
>
> Follow this link to subscribe/unsubscribe:http://www.vtk.org/mailman/listinfo/vtk-developers
>
>
>
--
Unpaid intern in BillsBasement at noware dot com
--
Unpaid intern in BillsBasement at noware dot com
[Attachment #5 (text/html)]
<div dir="ltr"><br><br><div class="gmail_quote">---------- Forwarded message \
----------<br>From: <b class="gmail_sendername">Burlen Loring</b> <span \
dir="ltr"><<a href="mailto:burlen.loring@gmail.com">burlen.loring@gmail.com</a>></span><br>
Date: Sat, Jul 27, 2013 at 7:02 PM<br>Subject: Re: [vtk-developers] New valgrind \
defect after checkins on July 11<br>To: Bill Lorensen <<a \
href="mailto:bill.lorensen@gmail.com">bill.lorensen@gmail.com</a>><br><br><br>
<div text="#000000" bgcolor="#FFFFFF">
<div>Hi Bill,<br>
<br>
Thanks for waiting for me to finish my last patch. I wasn't sure
if it would change the path through this test since it disabled
some OpenGL features for Mesa 7. It looks like we need a
suppression for these errors. I've copied the suppressions from
the test output into a new patch, <a \
href="http://review.source.kitware.com/#/c/12115/" \
target="_blank">http://review.source.kitware.com/#/c/12115/</a>.
I wouldn't want to merge it without trying it first, would you (or
anyone who has access to karego) mind verifying that this fixes
the issue?<br>
<br>
Thank you<span class="HOEnZb"><font color="#888888"><br>
Burlen</font></span><div><div class="h5"><br>
<br>
On 7/19/2013 10:22 AM, Bill Lorensen wrote:<br>
</div></div></div><div><div class="h5">
<blockquote type="cite">
<div dir="ltr">
<div>
<div>
<div>
<div>
<div>Burlen,<br>
<br>
</div>
No problem. I just did not want to have it fall through
the cracks.<br>
<br>
</div>
Vacation is a much higher priority for sure.<br>
<br>
</div>
Being retired, I'm always on vacation.<br>
<br>
</div>
Regards,<br>
<br>
</div>
Bill<br>
</div>
<div class="gmail_extra"><br>
<br>
<div class="gmail_quote">On Fri, Jul 19, 2013 at 1:15 PM, Burlen
Loring <span dir="ltr"><<a href="mailto:burlen.loring@gmail.com" \
target="_blank">burlen.loring@gmail.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px \
#ccc solid;padding-left:1ex"> <div text="#000000" bgcolor="#FFFFFF">
<div>Hi Bill,<br>
<br>
That would be mine. I commited a change that enabled
OpenGL features (eg FBO) for Mesa that were previously
unconditionally disabled regardless of if the driver
supported it or not. I've been cleaning dashboard
failures that popped up after my patch and looking at
features that were disabled because of Mesa specific
bugs this week and have a patch that addresses a number
of them, <a href="http://review.source.kitware.com/#/c/11985/" \
target="_blank">http://review.source.kitware.com/#/c/11985/</a>.
It's been reviewed and I have to make another pass over
it to address some minor issues that reviewers found. I
am on vacation today and will be away until Monday. On
Monday I plan to make the changes to my patch and merge
asap (once reviewers are satisfied). This patch may fix
the valgrind issues, but if not I will add an
suppression since the error reported by valgrind is in
Mesa not VTK.<br>
<br>
Thanks for being patient, my vacation is planned at an
inconvenient time!<br>
Burlen
<div>
<div><br>
<br>
On 7/19/2013 5:13 AM, Bill Lorensen wrote:<br>
</div>
</div>
</div>
<blockquote type="cite">
<div>
<div>
<div dir="ltr">Folks,
<div><br>
</div>
<div>There were 86 files changed on July 11:</div>
<div><a \
href="http://open.cdash.org/index.php?project=VTK&date=2013-07-12" \
target="_blank">http://open.cdash.org/index.php?project=VTK&date=2013-07-12</a><br>
</div>
<div><br>
</div>
<div>This valgrind defect appeared:</div>
<div><a \
href="http://open.cdash.org/viewDynamicAnalysisFile.php?id=2973840" \
target="_blank">http://open.cdash.org/viewDynamicAnalysisFile.php?id=2973840</a><br> \
</div> <div><br>
</div>
<div>Bill<br>
</div>
<div><br>
</div>
<div><br>
</div>
</div>
<br>
<fieldset></fieldset>
<br>
</div>
</div>
<pre>_______________________________________________
Powered by <a href="http://www.kitware.com" target="_blank">www.kitware.com</a>
Visit other Kitware open-source projects at <a \
href="http://www.kitware.com/opensource/opensource.html" \
target="_blank">http://www.kitware.com/opensource/opensource.html</a>
Follow this link to subscribe/unsubscribe:
<a href="http://www.vtk.org/mailman/listinfo/vtk-developers" \
target="_blank">http://www.vtk.org/mailman/listinfo/vtk-developers</a>
</pre>
</blockquote>
<br>
</div>
</blockquote>
</div>
<br>
<br clear="all">
<br>
-- <br>
Unpaid intern in BillsBasement at noware dot com<br>
</div>
</blockquote>
<br>
</div></div></div>
</div><br><br clear="all"><div><br></div>-- <br>Unpaid intern in BillsBasement at \
noware dot com<br> </div>
_______________________________________________
Powered by www.kitware.com
Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html
Follow this link to subscribe/unsubscribe:
http://www.vtk.org/mailman/listinfo/vtk-developers
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic