[prev in list] [next in list] [prev in thread] [next in thread] 

List:       vtk-developers
Subject:    Re: [vtk-developers] Gerrit questions
From:       Bill Lorensen <bill.lorensen () gmail ! com>
Date:       2013-02-28 17:51:11
Message-ID: CADZJ4hMhNKk4b9-B=scVo5VkKPoqh4ZRFZh2gZjgMZ591-kejg () mail ! gmail ! com
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]


Sounds great.

Those strange image failures you experienced yesterday helped us find a
nasty problem in VTKData/Baselines

Bill

On Thu, Feb 28, 2013 at 12:19 PM, David Thompson <david.thompson@kitware.com
> wrote:

> Hi Bill,
>
> > Can you rebase you patch to master and push it again.
>
> Sure.
>
> > Also, I have some comments regarding your new images. The scalar bar do
> not "look as nice" as the original ones.
>
> I've added some padding back between the title and scalar bar. I want to
> test it a little more but will push this weekend sometime. And I appreciate
> the feedback.
>
>         Thanks,
>         David
>
> >
> >
> > On Thu, Feb 28, 2013 at 11:14 AM, David Thompson <
> david.thompson@kitware.com> wrote:
> > Hi David,
> >
> > > This has also been seen elsewhere. We have noticed a discrepancy in
> baseline alternates that may explain size differences like those reported
> here. ... We’ll trigger a new CDash@home builds later after that happens
> and we can check to see what those results look like.
> > >
> > > So, hold off on merging this for now. If nobody replies again before
> midnight tonight -- ping again to check on the status.
> >
> > Ping!
> >
> >         David
> >
> > _______________________________________________
> > Powered by www.kitware.com
> >
> > Visit other Kitware open-source projects at
> http://www.kitware.com/opensource/opensource.html
> >
> > Follow this link to subscribe/unsubscribe:
> > http://www.vtk.org/mailman/listinfo/vtk-developers
> >
> >
> >
> >
> > --
> > Unpaid intern in BillsBasement at noware dot com
>
> David Thompson
> R&D Engineer – Kitware, Inc.
> david.thompson@kitware.com
> (919)869-8868
> Suite G-4
> 101 E. Weaver St.
> Carrboro, NC 27510
>
>


-- 
Unpaid intern in BillsBasement at noware dot com

[Attachment #5 (text/html)]

Sounds great.<br><br>Those strange image failures you experienced yesterday helped us \
find a nasty problem in VTKData/Baselines<br><br>Bill<br><br><div \
class="gmail_quote">On Thu, Feb 28, 2013 at 12:19 PM, David Thompson <span \
dir="ltr">&lt;<a href="mailto:david.thompson@kitware.com" \
target="_blank">david.thompson@kitware.com</a>&gt;</span> wrote:<br> <blockquote \
class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc \
solid;padding-left:1ex">Hi Bill,<br> <div class="im"><br>
&gt; Can you rebase you patch to master and push it again.<br>
<br>
</div>Sure.<br>
<div class="im"><br>
&gt; Also, I have some comments regarding your new images. The scalar bar do not \
&quot;look as nice&quot; as the original ones.<br> <br>
</div>I&#39;ve added some padding back between the title and scalar bar. I want to \
test it a little more but will push this weekend sometime. And I appreciate the \
feedback.<br> <br>
        Thanks,<br>
        David<br>
<div class="HOEnZb"><div class="h5"><br>
&gt;<br>
&gt;<br>
&gt; On Thu, Feb 28, 2013 at 11:14 AM, David Thompson &lt;<a \
href="mailto:david.thompson@kitware.com">david.thompson@kitware.com</a>&gt; \
wrote:<br> &gt; Hi David,<br>
&gt;<br>
&gt; &gt; This has also been seen elsewhere. We have noticed a discrepancy in \
baseline alternates that may explain size differences like those reported here. ... \
We’ll trigger a new CDash@home builds later after that happens and we can check to \
see what those results look like.<br>

&gt; &gt;<br>
&gt; &gt; So, hold off on merging this for now. If nobody replies again before \
midnight tonight -- ping again to check on the status.<br> &gt;<br>
&gt; Ping!<br>
&gt;<br>
&gt;         David<br>
&gt;<br>
&gt; _______________________________________________<br>
&gt; Powered by <a href="http://www.kitware.com" \
target="_blank">www.kitware.com</a><br> &gt;<br>
&gt; Visit other Kitware open-source projects at <a \
href="http://www.kitware.com/opensource/opensource.html" \
target="_blank">http://www.kitware.com/opensource/opensource.html</a><br> &gt;<br>
&gt; Follow this link to subscribe/unsubscribe:<br>
&gt; <a href="http://www.vtk.org/mailman/listinfo/vtk-developers" \
target="_blank">http://www.vtk.org/mailman/listinfo/vtk-developers</a><br> &gt;<br>
&gt;<br>
&gt;<br>
&gt;<br>
&gt; --<br>
&gt; Unpaid intern in BillsBasement at noware dot com<br>
<br>
</div></div><span class="HOEnZb"><font color="#888888">David Thompson<br>
R&amp;D Engineer – Kitware, Inc.<br>
<a href="mailto:david.thompson@kitware.com">david.thompson@kitware.com</a><br>
<a href="tel:%28919%29869-8868" value="+19198698868">(919)869-8868</a><br>
Suite G-4<br>
101 E. Weaver St.<br>
Carrboro, NC 27510<br>
<br>
</font></span></blockquote></div><br><br clear="all"><br>-- <br>Unpaid intern in \
BillsBasement at noware dot com<br>



_______________________________________________
Powered by www.kitware.com

Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html

Follow this link to subscribe/unsubscribe:
http://www.vtk.org/mailman/listinfo/vtk-developers



[prev in list] [next in list] [prev in thread] [next in thread] 

Configure | About | News | Add a list | Sponsored by KoreLogic