[prev in list] [next in list] [prev in thread] [next in thread] 

List:       vtk-developers
Subject:    Re: [vtk-developers] Wrapper fixes for vtkDispatcher
From:       Robert Maynard <robert.maynard () kitware ! com>
Date:       2012-08-27 21:32:00
Message-ID: CAFzjYVr71GeQLgotyD9U3rmRbwcmNrDvswOnc4hCcpxnDh6PZQ () mail ! gmail ! com
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]


That makes sense, thanks for the clarification.

On Mon, Aug 27, 2012 at 5:27 PM, David Gobbi <david.gobbi@gmail.com> wrote:

> Hi Robert,
>
> The vtkWrapHierarchy tool tabulates _all_ of the types that are
> defined in any VTK header, just in case those types are ever
> encountered (even if only as forward declarations) in one of the
> wrapped class interfaces.  The idea is that even a non-wrapped
> type might appear as a method parameter in a wrapped class
> (VTK used to require BTX/ETX around such methods).
>
>  - David
>
>
> On Mon, Aug 27, 2012 at 3:08 PM, Robert Maynard
> <robert.maynard@kitware.com> wrote:
> > The changes look good to me. I had thought since the classes are listed
> in
> > WRAP_EXCLUDE we wouldn't have any issues with the parser.
> >
> >
> > On Mon, Aug 27, 2012 at 4:42 PM, David Gobbi <david.gobbi@gmail.com>
> wrote:
> >>
> >> The nested template declarations in vtkDispatcher.h identified a
> >> couple errors in the wrapper code. I've submitted a gerrit patch for
> >> the wrappers that should fix the issue & allow the wrappers to
> >> compile.
> >>
> >> http://review.source.kitware.com/#/t/1144/
> >>
> >> Ignore the vtkParse.tab.c changes, it's generated from vtkParse.y.
> >>
> >>  - David
> >
> >
> >
> >
> > --
> > Robert Maynard
>



-- 
Robert Maynard

[Attachment #5 (text/html)]

That makes sense, thanks for the clarification. <br><br><div class="gmail_quote">On \
Mon, Aug 27, 2012 at 5:27 PM, David Gobbi <span dir="ltr">&lt;<a \
href="mailto:david.gobbi@gmail.com" \
target="_blank">david.gobbi@gmail.com</a>&gt;</span> wrote:<br>

<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc \
solid;padding-left:1ex">Hi Robert,<br> <br>
The vtkWrapHierarchy tool tabulates _all_ of the types that are<br>
defined in any VTK header, just in case those types are ever<br>
encountered (even if only as forward declarations) in one of the<br>
wrapped class interfaces.  The idea is that even a non-wrapped<br>
type might appear as a method parameter in a wrapped class<br>
(VTK used to require BTX/ETX around such methods).<br>
<span class="HOEnZb"><font color="#888888"><br>
 - David<br>
</font></span><div class="HOEnZb"><div class="h5"><br>
<br>
On Mon, Aug 27, 2012 at 3:08 PM, Robert Maynard<br>
&lt;<a href="mailto:robert.maynard@kitware.com">robert.maynard@kitware.com</a>&gt; \
wrote:<br> &gt; The changes look good to me. I had thought since the classes are \
listed in<br> &gt; WRAP_EXCLUDE we wouldn&#39;t have any issues with the parser.<br>
&gt;<br>
&gt;<br>
&gt; On Mon, Aug 27, 2012 at 4:42 PM, David Gobbi &lt;<a \
href="mailto:david.gobbi@gmail.com">david.gobbi@gmail.com</a>&gt; wrote:<br> \
&gt;&gt;<br> &gt;&gt; The nested template declarations in vtkDispatcher.h identified \
a<br> &gt;&gt; couple errors in the wrapper code. I&#39;ve submitted a gerrit patch \
for<br> &gt;&gt; the wrappers that should fix the issue &amp; allow the wrappers \
to<br> &gt;&gt; compile.<br>
&gt;&gt;<br>
&gt;&gt; <a href="http://review.source.kitware.com/#/t/1144/" \
target="_blank">http://review.source.kitware.com/#/t/1144/</a><br> &gt;&gt;<br>
&gt;&gt; Ignore the vtkParse.tab.c changes, it&#39;s generated from vtkParse.y.<br>
&gt;&gt;<br>
&gt;&gt;  - David<br>
&gt;<br>
&gt;<br>
&gt;<br>
&gt;<br>
&gt; --<br>
&gt; Robert Maynard<br>
</div></div></blockquote></div><br><br clear="all"><div><br></div>-- <br>Robert \
Maynard<br>



_______________________________________________
Powered by www.kitware.com

Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html

Follow this link to subscribe/unsubscribe:
http://www.vtk.org/mailman/listinfo/vtk-developers



[prev in list] [next in list] [prev in thread] [next in thread] 

Configure | About | News | Add a list | Sponsored by KoreLogic