[prev in list] [next in list] [prev in thread] [next in thread]
List: vtk-developers
Subject: Re: [vtk-developers] Patch for VTK bug #3941
From: Dave Partyka <dave.partyka () kitware ! com>
Date: 2010-03-23 19:56:54
Message-ID: a44d4ae01003231256n455876a8rdc672d0c3f281241 () mail ! gmail ! com
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
Fixed by the following patch from Berk: Thanks all for your patience.
diff --git a/VTK/Filtering/vtkTrivialProducer.cxx
b/VTK/Filtering/vtkTrivialProducer.cxx
index 10c20bf..80881bb 100644
--- a/VTK/Filtering/vtkTrivialProducer.cxx
+++ b/VTK/Filtering/vtkTrivialProducer.cxx
@@ -20,6 +20,7 @@
#include "vtkInformation.h"
#include "vtkInformationVector.h"
#include "vtkObjectFactory.h"
+#include "vtkDataObject.h"
vtkCxxRevisionMacro(vtkTrivialProducer, "$Revision$");
vtkStandardNewMacro(vtkTrivialProducer);
@@ -148,6 +149,20 @@ vtkTrivialProducer::ProcessRequest(vtkInformation*
request,
outputInfo->Set(vtkStreamingDemandDrivenPipeline::TIME_STEPS(),
timeRange, 2);
}
+
+ if (this->Output->IsA("vtkImageData"))
+ {
+ vtkImageData* img = static_cast<vtkImageData*>(this->Output);
+ vtkInformation* pinfo = img->GetPipelineInformation();
+
+ double spacing[3];
+ img->GetSpacing(spacing);
+ pinfo->Set(vtkDataObject::SPACING(), spacing[0], spacing[1], spacing[2]);
+
+ double origin[3];
+ img->GetOrigin(origin);
+ pinfo->Set(vtkDataObject::ORIGIN(), origin[0], origin[1], origin[2]);
+ }
}
#if VTK_TRIVIAL_PRODUCER_CHECK_UPDATE_EXTENT
if(request->Has(vtkStreamingDemandDrivenPipeline::REQUEST_UPDATE_EXTENT()))
Committed:
Committer: Dave Partyka <dave.partyka@kitware.com>
/cvsroot/ParaView3/ParaView3/VTK/Filtering/vtkTrivialProducer.cxx,v <--
Filtering/vtkTrivialProducer.cxx
new revision: 1.14; previous revision: 1.13
On Tue, Mar 23, 2010 at 11:05 AM, Dave Partyka <dave.partyka@kitware.com>wrote:
> I will go poke those responsible. Thanks!
>
> On Tue, Mar 23, 2010 at 11:01 AM, David Doria <daviddoria+vtk@gmail.com<daviddoria%2Bvtk@gmail.com>
> > wrote:
>
>> On Wed, Mar 17, 2010 at 2:16 PM, Dominique Belhachemi <
>> domibel@cs.tu-berlin.de> wrote:
>>
>>> Dear VTK developers,
>>>
>>> Please consider the attached patch to close bug #3941.
>>>
>>> I applied this patch to Debian's vtk package in May 2009. It works very
>>> well.
>>>
>>> Cheers
>>> Dominique
>>>
>>>
>> Guys,
>>
>> It seems too often that posts like this are ignored. If someone has taken
>> the time to fix a bug, it should either be committed, or some discussion
>> about why it cannot be committed should follow.
>>
>> David
>>
>> _______________________________________________
>> Powered by www.kitware.com
>>
>> Visit other Kitware open-source projects at
>> http://www.kitware.com/opensource/opensource.html
>>
>> Follow this link to subscribe/unsubscribe:
>> http://www.vtk.org/mailman/listinfo/vtk-developers
>>
>>
>>
>
[Attachment #5 (text/html)]
<span class="Apple-style-span" style="font-family: Verdana, Arial, Helvetica, \
sans-serif; font-size: 13px; "><a name="bugnotes" id="bugnotes"><div \
id="bugnotes_open" style="padding-top: 3px; padding-right: 3px; padding-bottom: 3px; \
padding-left: 3px; "> <div style="text-align: left;"><span class="Apple-style-span" \
style="-webkit-border-horizontal-spacing: 1px; -webkit-border-vertical-spacing: \
1px;"><div style="text-align: left;">Fixed by the following patch from Berk: Thanks \
all for your patience.</div> <div style="text-align: left;"><br></div><div \
style="text-align: left;">diff --git a/VTK/Filtering/vtkTrivialProducer.cxx \
b/VTK/Filtering/vtkTrivialProducer.cxx</div><div style="text-align: left;">index \
10c20bf..80881bb 100644</div> <div style="text-align: left;">--- \
a/VTK/Filtering/vtkTrivialProducer.cxx</div><div style="text-align: left;">+++ \
b/VTK/Filtering/vtkTrivialProducer.cxx</div><div style="text-align: left;">@@ -20,6 \
+20,7 @@</div><div style="text-align: left;"> #include \
"vtkInformation.h"</div><div style="text-align: left;"> #include \
"vtkInformationVector.h"</div><div style="text-align: left;"> #include \
"vtkObjectFactory.h"</div><div style="text-align: left;"> +#include \
"vtkDataObject.h"</div><div style="text-align: left;"> </div><div \
style="text-align: left;"> vtkCxxRevisionMacro(vtkTrivialProducer, \
"$Revision$");</div><div style="text-align: left;"> \
vtkStandardNewMacro(vtkTrivialProducer);</div> <div style="text-align: left;">@@ \
-148,6 +149,20 @@ vtkTrivialProducer::ProcessRequest(vtkInformation* \
request,</div><div style="text-align: left;"> \
outputInfo->Set(vtkStreamingDemandDrivenPipeline::TIME_STEPS(),</div> <div \
style="text-align: left;"> timeRange, 2);</div><div \
style="text-align: left;"> }</div><div style="text-align: left;">+</div><div \
style="text-align: left;">+ if \
(this->Output->IsA("vtkImageData"))</div> <div style="text-align: \
left;">+ {</div><div style="text-align: left;">+ vtkImageData* img = \
static_cast<vtkImageData*>(this->Output);</div><div style="text-align: \
left;">+ vtkInformation* pinfo = img->GetPipelineInformation();</div> <div \
style="text-align: left;">+</div><div style="text-align: left;">+ double \
spacing[3];</div><div style="text-align: left;">+ \
img->GetSpacing(spacing);</div><div style="text-align: left;">+ \
pinfo->Set(vtkDataObject::SPACING(), spacing[0], spacing[1], spacing[2]);</div> \
<div style="text-align: left;">+</div><div style="text-align: left;">+ double \
origin[3];</div><div style="text-align: left;">+ img->GetOrigin(origin);</div><div \
style="text-align: left;">+ pinfo->Set(vtkDataObject::ORIGIN(), origin[0], \
origin[1], origin[2]);</div> <div style="text-align: left;">+ }</div><div \
style="text-align: left;"> }</div><div style="text-align: left;"> #if \
VTK_TRIVIAL_PRODUCER_CHECK_UPDATE_EXTENT</div><div style="text-align: left;"> \
if(request->Has(vtkStreamingDemandDrivenPipeline::REQUEST_UPDATE_EXTENT()))</div> \
<div style="text-align: left;"><br></div><div style="text-align: \
left;">Committed:</div><div style="text-align: left;"><br></div><div \
style="text-align: left;">Committer: Dave Partyka \
<dave.partyka@kitware.com></div> <div style="text-align: \
left;">/cvsroot/ParaView3/ParaView3/VTK/Filtering/vtkTrivialProducer.cxx,v <-- \
Filtering/vtkTrivialProducer.cxx</div><div style="text-align: left;">new revision: \
1.14; previous revision: 1.13</div> </span></div><br></div></a></span><br><div \
class="gmail_quote">On Tue, Mar 23, 2010 at 11:05 AM, Dave Partyka <span \
dir="ltr"><<a href="mailto:dave.partyka@kitware.com">dave.partyka@kitware.com</a>></span> \
wrote:<br> <blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px \
#ccc solid;padding-left:1ex;">I will go poke those responsible. Thanks!<br><br><div \
class="gmail_quote"><div><div></div><div class="h5">On Tue, Mar 23, 2010 at 11:01 AM, \
David Doria <span dir="ltr"><<a href="mailto:daviddoria%2Bvtk@gmail.com" \
target="_blank">daviddoria+vtk@gmail.com</a>></span> wrote:<br>
</div></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px \
#ccc solid;padding-left:1ex"><div><div></div><div class="h5"><div \
class="gmail_quote"><div><div></div><div>On Wed, Mar 17, 2010 at 2:16 PM, Dominique \
Belhachemi <span dir="ltr"><<a href="mailto:domibel@cs.tu-berlin.de" \
target="_blank">domibel@cs.tu-berlin.de</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc \
solid;padding-left:1ex"> Dear VTK developers,<br>
<br>
Please consider the attached patch to close bug #3941.<br>
<br>
I applied this patch to Debian's vtk package in May 2009. It works very<br>
well.<br>
<br>
Cheers<br>
<font color="#888888">Dominique<br><br></font></blockquote><div \
class="gmail_quote"><br></div></div></div>Guys,</div><div \
class="gmail_quote"><br></div><div class="gmail_quote">It seems too often that posts \
like this are ignored. If someone has taken the time to fix a bug, it should either \
be committed, or some discussion about why it cannot be committed should \
follow.</div>
<div class="gmail_quote"><br><font color="#888888"><div>David</div></font></div>
<br></div></div>_______________________________________________<br>
Powered by <a href="http://www.kitware.com" target="_blank">www.kitware.com</a><br>
<br>
Visit other Kitware open-source projects at <a \
href="http://www.kitware.com/opensource/opensource.html" \
target="_blank">http://www.kitware.com/opensource/opensource.html</a><br> <br>
Follow this link to subscribe/unsubscribe:<br>
<a href="http://www.vtk.org/mailman/listinfo/vtk-developers" \
target="_blank">http://www.vtk.org/mailman/listinfo/vtk-developers</a><br> <br>
<br></blockquote></div><br>
</blockquote></div><br>
_______________________________________________
Powered by www.kitware.com
Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html
Follow this link to subscribe/unsubscribe:
http://www.vtk.org/mailman/listinfo/vtk-developers
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic