[prev in list] [next in list] [prev in thread] [next in thread] 

List:       vtk-developers
Subject:    Re: [vtk-developers] Labeling classes with which library is
From:       David Doria <daviddoria+vtk () gmail ! com>
Date:       2009-10-14 11:02:08
Message-ID: c19fcadc0910140402t433d19d1wcb3e1b8f01ef7b0f () mail ! gmail ! com
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]


On Wed, Oct 14, 2009 at 1:53 AM, Jeff Baumes <jeff.baumes@kitware.com>wrote:

> As a quick trick that should almost always work, look at the very
> bottom of the doxygen page for a class for the text like:
>
> The documentation for this class was generated from the following file:
> dox/Infovis/vtkBoostPrimMinimumSpanningTree.h
>
> The "Infovis" directory signals that you need to link against
> vtkInfovis. In general, the library name matches the directory name
> exactly. But this is not always the case (e.g. the library in
> GUISupport\Qt is called QVTK), so I'd welcome an automated script to
> make this clear in all cases.
>
> Jeff
>
> On Wed, Oct 14, 2009 at 1:07 AM, David Gobbi <david.gobbi@gmail.com>
> wrote:
> > Adding the library names to the doxygen documentation seems like a very
> good
> > idea to me.  It could be done automatically, the perl script
> > VTK/Utilities/Doxygen/doc_header2doxygen.pl would have to be modified so
> > that it adds the name of the appropriate library to each doxygen page.
> >
> >     David
> >
> >
> > On Tue, Oct 13, 2009 at 7:41 PM, David Doria <daviddoria+vtk@gmail.com<daviddoria%2Bvtk@gmail.com>
> >
> > wrote:
> >>
> >> As an example:
> >>
> >> I found a class to find the minimum spanning tree on a graph:
> >> vtkBoostPrimMinimumSpanningTree. So I setup a little test case
> including:
> >> vtkBoostPrimMinimumSpanningTree* MinimumSpanningTree =
> >> vtkBoostPrimMinimumSpanningTree::New();
> >>
> >> I got a linker error. It was not at all obvious or quick to figure out
> >> that I needed to link to libvtkInfovis to use this functionality.
> >>
> >> Even some of the basic ones that seem ridiculous obvious (i.e. vtkIO for
> >> vtkXMLPolyDataReader) could be quite annoying to figure out for a first
> time
> >> user. Would it make sense to add a single line to every class's
> >> documentation that explains this? Something like:
> >>
> >> Required libraries: vtkIO
> >>
> >> Please let me know what you think.
> >>
> >> Thanks,
> >>
> >> David
> >>
> >
> >
> > _______________________________________________
> > Powered by www.kitware.com
> >
> > Visit other Kitware open-source projects at
> > http://www.kitware.com/opensource/opensource.html
> >
> > Follow this link to subscribe/unsubscribe:
> > http://www.vtk.org/mailman/listinfo/vtk-developers
> >
> >
> >
> _______________________________________________
> Powered by www.kitware.com
>
> Visit other Kitware open-source projects at
> http://www.kitware.com/opensource/opensource.html
>
> Follow this link to subscribe/unsubscribe:
> http://www.vtk.org/mailman/listinfo/vtk-developers
>
>
@Andrew

I did not look at the actual VTK tests - I wrote my own. It is quite a chore
to look through the testing directories to find the correct CMake files to
figure out which libraries the real vtk tests link against.

Also, I don't understand your (2). This should not actually change anything
- it is simply an extra comment line. I don't see how it would be difficult
to maintain, the library structure doesn't really change.

@Jeff, David

Unfortunately I'm not a perl guru - nor do I still know where to extract the
information about which libraries are required (since you said it is not
always the folder that it is in). Can we "assign" this to someone who has
the necessary knowledge?

Thanks,

David

[Attachment #5 (text/html)]

<br><br><div class="gmail_quote">On Wed, Oct 14, 2009 at 1:53 AM, Jeff Baumes <span \
dir="ltr">&lt;<a href="mailto:jeff.baumes@kitware.com">jeff.baumes@kitware.com</a>&gt;</span> \
wrote:<br><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, \
204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;"> As a quick trick that should \
almost always work, look at the very<br> bottom of the doxygen page for a class for \
the text like:<br> <br>
The documentation for this class was generated from the following file:<br>
dox/Infovis/vtkBoostPrimMinimumSpanningTree.h<br>
<br>
The &quot;Infovis&quot; directory signals that you need to link against<br>
vtkInfovis. In general, the library name matches the directory name<br>
exactly. But this is not always the case (e.g. the library in<br>
GUISupport\Qt is called QVTK), so I&#39;d welcome an automated script to<br>
make this clear in all cases.<br>
<br>
Jeff<br>
<div><div></div><div class="h5"><br>
On Wed, Oct 14, 2009 at 1:07 AM, David Gobbi &lt;<a \
href="mailto:david.gobbi@gmail.com">david.gobbi@gmail.com</a>&gt; wrote:<br> &gt; \
Adding the library names to the doxygen documentation seems like a very good<br> &gt; \
idea to me.  It could be done automatically, the perl script<br> &gt; \
VTK/Utilities/Doxygen/<a href="http://doc_header2doxygen.pl" \
target="_blank">doc_header2doxygen.pl</a> would have to be modified so<br> &gt; that \
it adds the name of the appropriate library to each doxygen page.<br> &gt;<br>
&gt;     David<br>
&gt;<br>
&gt;<br>
&gt; On Tue, Oct 13, 2009 at 7:41 PM, David Doria &lt;<a \
href="mailto:daviddoria%2Bvtk@gmail.com">daviddoria+vtk@gmail.com</a>&gt;<br> &gt; \
wrote:<br> &gt;&gt;<br>
&gt;&gt; As an example:<br>
&gt;&gt;<br>
&gt;&gt; I found a class to find the minimum spanning tree on a graph:<br>
&gt;&gt; vtkBoostPrimMinimumSpanningTree. So I setup a little test case \
including:<br> &gt;&gt; vtkBoostPrimMinimumSpanningTree* MinimumSpanningTree =<br>
&gt;&gt; vtkBoostPrimMinimumSpanningTree::New();<br>
&gt;&gt;<br>
&gt;&gt; I got a linker error. It was not at all obvious or quick to figure out<br>
&gt;&gt; that I needed to link to libvtkInfovis to use this functionality.<br>
&gt;&gt;<br>
&gt;&gt; Even some of the basic ones that seem ridiculous obvious (i.e. vtkIO for<br>
&gt;&gt; vtkXMLPolyDataReader) could be quite annoying to figure out for a first \
time<br> &gt;&gt; user. Would it make sense to add a single line to every \
class&#39;s<br> &gt;&gt; documentation that explains this? Something like:<br>
&gt;&gt;<br>
&gt;&gt; Required libraries: vtkIO<br>
&gt;&gt;<br>
&gt;&gt; Please let me know what you think.<br>
&gt;&gt;<br>
&gt;&gt; Thanks,<br>
&gt;&gt;<br>
&gt;&gt; David<br>
&gt;&gt;<br>
&gt;<br>
&gt;<br>
</div></div><div class="im">&gt; _______________________________________________<br>
&gt; Powered by <a href="http://www.kitware.com" \
target="_blank">www.kitware.com</a><br> &gt;<br>
&gt; Visit other Kitware open-source projects at<br>
&gt; <a href="http://www.kitware.com/opensource/opensource.html" \
target="_blank">http://www.kitware.com/opensource/opensource.html</a><br> &gt;<br>
</div><div class="im">&gt; Follow this link to subscribe/unsubscribe:<br>
</div>&gt; <a href="http://www.vtk.org/mailman/listinfo/vtk-developers" \
target="_blank">http://www.vtk.org/mailman/listinfo/vtk-developers</a><br> <div \
class="im">&gt;<br> &gt;<br>
&gt;<br>
_______________________________________________<br>
Powered by <a href="http://www.kitware.com" target="_blank">www.kitware.com</a><br>
<br>
Visit other Kitware open-source projects at <a \
href="http://www.kitware.com/opensource/opensource.html" \
target="_blank">http://www.kitware.com/opensource/opensource.html</a><br> <br>
</div><div class="im">Follow this link to subscribe/unsubscribe:<br>
</div><a href="http://www.vtk.org/mailman/listinfo/vtk-developers" \
target="_blank">http://www.vtk.org/mailman/listinfo/vtk-developers</a><br> \
<br></blockquote><div><br>@Andrew <br> <br>
I did not look at the actual VTK tests - I wrote my own. It is quite a
chore to look through the testing directories to find the correct CMake
files to figure out which libraries the real vtk tests link against.<br>
<br>
Also, I don&#39;t understand your (2). This should not actually change
anything - it is simply an extra comment line. I don&#39;t see how it would
be difficult to maintain, the library structure doesn&#39;t really change.<br>
<br>@Jeff, David<br><br>Unfortunately I&#39;m not a perl guru - nor do I still know \
where to extract the information about which libraries are required (since you said \
it is not always the folder that it is in). Can we &quot;assign&quot; this to someone \
who has the necessary knowledge?<br> <br clear="all">Thanks,<br><br>David \
<br></div></div><br>



_______________________________________________
Powered by www.kitware.com

Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html

Follow this link to subscribe/unsubscribe:
http://www.vtk.org/mailman/listinfo/vtk-developers



[prev in list] [next in list] [prev in thread] [next in thread] 

Configure | About | News | Add a list | Sponsored by KoreLogic