[prev in list] [next in list] [prev in thread] [next in thread]
List: vtk-developers
Subject: Re: [vtk-developers] Patch: Re: Exporter bugs
From: Gerrick Bivins <gbivins () objectreservoir ! com>
Date: 2008-08-13 13:29:31
Message-ID: C4C84BEC.1850%gbivins () objectreservoir ! com
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
No problem! Glad to finally łgive back˛!
;)
Any chance of the patch for vtkInteractiveRubberBandZoom I submitted getting
into 5.2?
http://www.vtk.org/Bug/view.php?id=3713
Gerrick
On 8/12/08 1:59 PM, "David Cole" <david.cole@kitware.com> wrote:
> Fixed in CVS HEAD:
>
> /cvsroot/VTK/VTK/Rendering/vtkOBJExporter.cxx,v <--
> Rendering/vtkOBJExporter.cxx
> new revision: 1.59; previous revision: 1.58
> /cvsroot/VTK/VTK/Rendering/vtkVRMLExporter.cxx,v <--
> Rendering/vtkVRMLExporter.cxx
> new revision: 1.83; previous revision: 1.82
> /cvsroot/VTK/VTK/Rendering/vtkVRMLExporter.h,v <--
> Rendering/vtkVRMLExporter.h
> new revision: 1.37; previous revision: 1.36
>
> Thanks for the patches...
>
>
> 2008/8/12 Gerrick Bivins <gbivins@objectreservoir.com>
>>
>> No prob. I posted a bug on mantis that has the updated VRML patch as I found
>> that I left a debug print statement.
>>
>> http://www.vtk.org/Bug/view.php?id=7474
>>
>> vtkVRMLExporter.cxx.08112008.patch is the file for the cxx patch.
>> Gerrick
>>
>>
>> On 8/12/08 12:40 PM, "David Cole" <david.cole@kitware.com> wrote:
>>
>>> I am going to apply these patches to CVS HEAD, and after a clean night on
>>> the dashboards, I will merge them to the VTK-5-2 branch.
>>>
>>> Did anybody have any objections to these patches?
>>>
>>> Thanks, Gerrick, for contributing.
>>>
>>>
>>> David
>>>
>>>
>>> 2008/8/7 Gerrick Bivins <gbivins@objectreservoir.com>
>>>> Here are the associated patch files. I've tested on MacOSX 10.5.4 and
>>>> windows xp 32 against the VTK 5.2 branch.
>>>> Hopefully these can make it into the 5.2 release.
>>>> Gerrick
>>>>
>>>>
>>>> On 8/7/08 9:54 AM, "Gerrick Bivins" <gbivins@objectreservoir.com> wrote:
>>>>
>>>>> Hello,
>>>>> I ran across a couple of bugs with the following Exporters in the vtk 5.2
>>>>> branch while trying to export my scenes in from my vtk application:
>>>>> VRML Exporter:
>>>>> 1) Exported file won't load in Paraview or most other VRML viewers.If it
>>>>> is succesful, only the last *Set is read in. The problem is that there
>>>>> needs to be one *Set per Shape node.
>>>>> 2) Exported file doesn't take into consideration actor's visibility so
>>>>> all actors are exported even if they aren't visible in the render window.
>>>>> I have fixed both of these.
>>>>>
>>>>> In trying to verify some of these bugs by exporting to obj and reading in
>>>>> the file, I ran into these bugs:
>>>>> OBJExporter
>>>>> 1) Exported file doesn't take into consideration actor's visibility so
>>>>> all actors are exported even if they aren't visible in the render window.
>>>>> 2) Exporter file only uses Actors color rather than the mappers scalars
>>>>> for coloring (color by vertex).
>>>>> 3) Exported file doesn't use transparency. This is because the variable
>>>>> set for transparency is named incorrectly as "Tf" should be "Tr" according
>>>>> to specs.
>>>>> 4) Exported file's transparency is inverse of vtkProperty opacity value
>>>>> (1.0-opacity). Should just be opacity.
>>>>>
>>>>> I have fixed 1,2 and 4 in my local build. 3 seems like it will be a little
>>>>> more complicated so it may take some time
>>>>>
>>>>> Eventually, I'd like to use x3D (or some other embeddable format UCD
>>>>> maybe) so I gave that a shot but ran into another issue:
>>>>>
>>>>> X3DExporter
>>>>> 1)Exported file is unloadable in external viewers. I'm not familiar
>>>>> enough with X3D format yet to debug this one.
>>>>>
>>>>> My question is, has anyone run into these issues or are the Exporters not
>>>>> used that much? Also, how do I go about submitting the fixes I have so
>>>>> far, patch, whole files, submission list? Not sure on this one.
>>>>> I've read these links:
>>>>> http://vtk.org/contribute.php
>>>>> http://www.vtk.org/Wiki/VTK_Coding_Standards
>>>>> But submission information seems to be missing.
>>>>>
>>>>> Gerrick
>>>>>
>>>>>
>>>>>
>>>>> _______________________________________________
>>>>> vtk-developers mailing list
>>>>> vtk-developers@vtk.org
>>>>> http://www.vtk.org/mailman/listinfo/vtk-developers
>>>>>
>>>>> _______________________________________________
>>>>> vtk-developers mailing list
>>>>> vtk-developers@vtk.org
>>>>> http://www.vtk.org/mailman/listinfo/vtk-developers
>>>>>
>>>>>
>>>>>
>>>>>
>>>>> _______________________________________________
>>>>> vtk-developers mailing list
>>>>> vtk-developers@vtk.org
>>>>> http://www.vtk.org/mailman/listinfo/vtk-developers
>>>>>
>>>>>
>>>>>
[Attachment #5 (text/html)]
<HTML>
<HEAD>
<TITLE>Re: [vtk-developers] Patch: Re: Exporter bugs</TITLE>
</HEAD>
<BODY>
<FONT SIZE="4"><FONT FACE="Calibri, Verdana, Helvetica, Arial"><SPAN \
STYLE='font-size:11pt'>No problem! Glad to finally “give back”!<BR> \
;)<BR> Any chance of the patch for vtkInteractiveRubberBandZoom I submitted getting \
into 5.2?<BR> <a href="http://www.vtk.org/Bug/view.php?id=3713">http://www.vtk.org/Bug/view.php?id=3713</a><BR>
<BR>
Gerrick<BR>
<BR>
<BR>
On 8/12/08 1:59 PM, "David Cole" <david.cole@kitware.com> wrote:<BR>
<BR>
</SPAN></FONT></FONT><BLOCKQUOTE><FONT SIZE="4"><FONT FACE="Calibri, Verdana, \
Helvetica, Arial"><SPAN STYLE='font-size:11pt'>Fixed in CVS HEAD:<BR> <BR>
/cvsroot/VTK/VTK/Rendering/vtkOBJExporter.cxx,v <-- \
Rendering/vtkOBJExporter.cxx<BR> new revision: 1.59; \
previous revision: 1.58<BR> \
/cvsroot/VTK/VTK/Rendering/vtkVRMLExporter.cxx,v <-- \
Rendering/vtkVRMLExporter.cxx<BR> new revision: 1.83; \
previous revision: 1.82<BR> \
/cvsroot/VTK/VTK/Rendering/vtkVRMLExporter.h,v <-- \
Rendering/vtkVRMLExporter.h<BR> new revision: 1.37; \
previous revision: 1.36<BR> <BR>
Thanks for the patches...<BR>
<BR>
<BR>
2008/8/12 Gerrick Bivins <gbivins@objectreservoir.com><BR>
</SPAN></FONT></FONT><BLOCKQUOTE><FONT SIZE="4"><FONT FACE="Calibri, Verdana, \
Helvetica, Arial"><SPAN STYLE='font-size:11pt'><BR> No prob. I posted a bug on mantis \
that has the updated VRML patch as I found that I left a debug print statement.<BR> \
<BR> <a href="http://www.vtk.org/Bug/view.php?id=7474">http://www.vtk.org/Bug/view.php?id=7474</a><BR>
<BR>
vtkVRMLExporter.cxx.08112008.patch is the file for the cxx patch.<BR>
<FONT COLOR="#888888">Gerrick<BR>
</FONT><BR>
<BR>
On 8/12/08 12:40 PM, "David Cole" <david.cole@kitware.com> wrote:<BR>
<BR>
</SPAN></FONT></FONT><BLOCKQUOTE><FONT SIZE="4"><FONT FACE="Calibri, Verdana, \
Helvetica, Arial"><SPAN STYLE='font-size:11pt'>I am going to apply these patches to \
CVS HEAD, and after a clean night on the dashboards, I will merge them to the VTK-5-2 \
branch.<BR> <BR>
Did anybody have any objections to these patches?<BR>
<BR>
Thanks, Gerrick, for contributing.<BR>
<BR>
<BR>
David<BR>
<BR>
<BR>
2008/8/7 Gerrick Bivins <gbivins@objectreservoir.com><BR>
</SPAN></FONT></FONT><BLOCKQUOTE><FONT SIZE="4"><FONT FACE="Calibri, Verdana, \
Helvetica, Arial"><SPAN STYLE='font-size:11pt'>Here are the associated patch files. \
I've tested on MacOSX 10.5.4 and windows xp 32 against the VTK 5.2 branch.<BR> \
Hopefully these can make it into the 5.2 release.<BR> Gerrick<BR>
<BR>
<BR>
On 8/7/08 9:54 AM, "Gerrick Bivins" <gbivins@objectreservoir.com> \
wrote:<BR> <BR>
</SPAN></FONT></FONT><BLOCKQUOTE><FONT SIZE="4"><FONT FACE="Calibri, Verdana, \
Helvetica, Arial"><SPAN STYLE='font-size:11pt'>Hello,<BR> I ran across a couple of \
bugs with the following Exporters in the vtk 5.2 branch while trying to export my \
scenes in from my vtk application:<BR> VRML Exporter:<BR>
1) Exported file won't load in Paraview or most other VRML viewers.If it \
is succesful, only the last *Set is read in. The problem is that there needs to be \
one *Set per Shape node. <BR> 2) Exported file doesn't take into \
consideration actor's visibility so all actors are exported even if they aren't \
visible in the render window.<BR> I have fixed both of these.<BR>
<BR>
In trying to verify some of these bugs by exporting to obj and reading in the file, I \
ran into these bugs:<BR> OBJExporter<BR>
1) Exported file doesn't take into consideration actor's visibility so \
all actors are exported even if they aren't visible in the render window.<BR> \
2) Exporter file only uses Actors color rather than the mappers scalars \
for coloring (color by vertex).<BR> 3) Exported file doesn't use \
transparency. This is because the variable set for transparency is named incorrectly \
as "Tf" should be "Tr" according to specs.<BR> 4) \
Exported file's transparency is inverse of vtkProperty opacity value (1.0-opacity). \
Should just be opacity.<BR> <BR>
I have fixed 1,2 and 4 in my local build. 3 seems like it will be a little more \
complicated so it may take some time<BR> <BR>
Eventually, I'd like to use x3D (or some other embeddable format UCD maybe) so I gave \
that a shot but ran into another issue:<BR> <BR>
X3DExporter<BR>
1)Exported file is unloadable in external viewers. I'm not familiar \
enough with X3D format yet to debug this one.<BR> <BR>
My question is, has anyone run into these issues or are the Exporters not used that \
much? Also, how do I go about submitting the fixes I have so far, patch, whole files, \
submission list? Not sure on this one.<BR> I've read these links:<BR>
<a href="http://vtk.org/contribute.php">http://vtk.org/contribute.php</a><BR>
<a href="http://www.vtk.org/Wiki/VTK_Coding_Standards">http://www.vtk.org/Wiki/VTK_Coding_Standards</a><BR>
But submission information seems to be missing.<BR>
<BR>
Gerrick<BR>
<BR>
<BR>
<HR ALIGN=CENTER SIZE="3" WIDTH="95%"></SPAN></FONT><FONT FACE="Consolas, Courier \
New, Courier"><SPAN STYLE='font-size:10pt'>_______________________________________________<BR>
vtk-developers mailing list<BR>
vtk-developers@vtk.org<BR>
<a href="http://www.vtk.org/mailman/listinfo/vtk-developers">http://www.vtk.org/mailman/listinfo/vtk-developers</a><BR>
</SPAN></FONT><FONT FACE="Calibri, Verdana, Helvetica, Arial"><SPAN \
STYLE='font-size:11pt'><BR> _______________________________________________<BR>
vtk-developers mailing list<BR>
vtk-developers@vtk.org<BR>
<a href="http://www.vtk.org/mailman/listinfo/vtk-developers">http://www.vtk.org/mailman/listinfo/vtk-developers</a><BR>
<BR>
<BR>
<BR>
<BR>
_______________________________________________<BR>
vtk-developers mailing list<BR>
vtk-developers@vtk.org<BR>
<a href="http://www.vtk.org/mailman/listinfo/vtk-developers">http://www.vtk.org/mailman/listinfo/vtk-developers</a><BR>
<BR>
<BR>
</SPAN></FONT></FONT></BLOCKQUOTE><FONT SIZE="4"><FONT FACE="Calibri, Verdana, \
Helvetica, Arial"><SPAN STYLE='font-size:11pt'><BR> \
</SPAN></FONT></FONT></BLOCKQUOTE></BLOCKQUOTE></BLOCKQUOTE></BLOCKQUOTE> </BODY>
</HTML>
_______________________________________________
vtk-developers mailing list
vtk-developers@vtk.org
http://www.vtk.org/mailman/listinfo/vtk-developers
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic