[prev in list] [next in list] [prev in thread] [next in thread] 

List:       vtk-developers
Subject:    [vtk-developers] Fix(?) of update locking in vtkSource.cxx
From:       "Charl P. Botha" <c.p.botha () its ! tudelft ! nl>
Date:       2003-03-11 17:11:46
Message-ID: 1047402706.9288.44.camel () dutidad
[Download RAW message or body]

Has anyone had more time to look at my small patch to vtkSource.cxx? 
This patch moves the unsetting of the this->Updating ivar to the end of
UpdateData()... it used take place earlier in the UpdateData() method,
but to my mind this was not correct, as it did not completely prevent
re-entrancy of UpdateData().

Thanks,
Charl

-- 
charl p. botha http://cpbotha.net/ http://visualisation.tudelft.nl/

["vtkSource.Updating-FIX.diff" (vtkSource.Updating-FIX.diff)]

Index: vtkSource.cxx
===================================================================
RCS file: /vtk/cvsroot/VTK/Common/vtkSource.cxx,v
retrieving revision 1.101
diff -u -r1.101 vtkSource.cxx
--- vtkSource.cxx	17 Jan 2003 14:09:51 -0000	1.101
+++ vtkSource.cxx	19 Feb 2003 21:48:51 -0000
@@ -352,7 +352,7 @@
         }
       }
     }
-  this->Updating = 0;     
+
     
   // Initialize all the outputs
   for (idx = 0; idx < this->NumberOfOutputs; idx++)
@@ -425,6 +425,8 @@
         }
       }  
     }
+
+  this->Updating = 0;
   
 }
 


[prev in list] [next in list] [prev in thread] [next in thread]