[prev in list] [next in list] [prev in thread] [next in thread] 

List:       vtigercrm-developers
Subject:    Re: [Vtigercrm-developers] [PATCH] TeX rendering API and invoice pdf
From:       "Minnie A" <minnie () vtiger ! com>
Date:       2007-12-31 6:11:41
Message-ID: fc4c72e40712302159p4adb486el43348efebc408a17 () mail ! gmail ! com
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]


Hi,

Kindly find the status of the patches which taken up for 5.0.4 release.


 S.No
Patch
Contributor
File
Message
Status
Comment
1
new functions and some cleanups  weigelt@metux.de01_PearDatabase_newfuncs.diff
Hi folks,

here are some patches (against latest trunk), which introduce
the new functions and so some cleanups.

cu Integrated

2
new functions and some cleanups  weigelt@metux.de
3_strip_useless_comments.diff
Integrated
3
remove noise in invoice module weigelt@metux.de02_nekrad-remove-noise.diffHi
folks,

this patch removes some noise in the invoice module ...

cuNot integrated
Expected behaviour.
4
PearDatabase.php sanity check in Move()weigelt@metux.de
08_nekrad_peardb_sanitycheck-1.diffHi folks,

as we sometimes get some errors like:

# Fatal error: Call to a member function Move() on a non-object
# in .../include/database/PearDatabase.php on line 443

Obviously sometimes the query_result() method is called with an
non-existing result object.

This patch adds an check which throws an exception on missing
result object, so we can easily track it down.


cu Integrated
5
Invoice: fix PDF link weigelt@metux.deinvoice-link-pdf.diff
Hi folks,

this patch fixes the really strange javascript link for pdf
invoice to an plain url.

cuDifferent fix has been integrated.

6
some new $adb (PearDatabase) methods weigelt@metux.de09_nekrad_peardb-
newfuncs.diff
Hi folks,

this patch adds two new functions to the PearDatabase ($adb)
class:

* sql_concat(array):
generates an sql expression for field concatenations, based
on selected RDBMS.

* run_query_field(string):
executes an given SQL query and returns only the first field
of the first record.


cu Integrated
7
leads module fix (postgres) weigelt@metux.de31_nekrad-leads-fix.diff
Hi folks,


the leads module (Tracker.php) suffers from an sql bug: it uses
mysql specific sql statements for concatenating fields. This ends
up in empty result objects and so the already mentioned error
of trying to call Move() on non-object.

This patch solves this by using the new PearDatabas::sql_concat()
function (see prev. patch) for creating the statement.

Also this patch calls the new PearDatabase::run_query_field()
for the one-field-query.


cuIntegrated with small modification.

8
Link leak in calendar module calendar viewjon@eyesopen.comcalendarlink.patch
Integrated


Thanks & Regards,
Minnie

On 12/29/07, Enrico Weigelt <weigelt@metux.de> wrote:
>
> * Enrico Weigelt <weigelt@metux.de> schrieb:
>
> Hi,
>
> > these patches add an universal rendering API for things like
> > invoices and an TeX renderer backend. The old invoice pdf code
> > is changed to run via the rendering API. Now it's very easy to
> > add new renderers. I also included my own templates as example.
> >
> > The API patch (renderapi-1) does not change anything but just
> > adding some new files in the lib/render/ subdir and could be
> > applied to 5.1 and 5.1_jens asap.
>
> What's the current status on my this patch ?
>
>
> cu
> _______________________________________________
> Reach hundreds of potential candidates - http://jobs.vtiger.com
>

[Attachment #5 (text/html)]

Hi,<br><br>Kindly find the status of the patches which taken up for 5.0.4 \
release.<br><br><br> <table style="text-align: left; width: 807px; height: 1411px;" \
border="1" cellpadding="2" cellspacing="2"> <tbody><tr><td style="vertical-align: \
top; font-weight: bold;">S.No<br></td><td style="vertical-align: top; font-weight: \
bold;">Patch<br></td><td style="font-weight: bold;">Contributor<br></td><td \
style="font-weight: bold;"> File<br></td><td>Message <br></td><td \
style="vertical-align: top; font-weight: bold;">Status<br></td><td \
style="vertical-align: top; font-weight: bold;">Comment<br></td></tr><tr><td \
style="vertical-align: top;">1<br></td> <td style="vertical-align: top;">new \
                functions and some cleanups&nbsp;
      </td><td><a href="mailto:weigelt@metux.de">weigelt@metux.de</a></td><td>01_PearDatabase_newfuncs.diff \
</td><td>Hi folks,<br><br> here are some patches (against latest trunk), which \
introduce <br> the new functions and so some cleanups. <br><br>
cu</td><td style="vertical-align: top;"> Integrated<br></td><td \
style="vertical-align: top;"><br></td></tr><tr><td style="vertical-align: \
top;">2<br></td><td style="vertical-align: top;">new functions and some \
cleanups&nbsp;  </td><td><a \
href="mailto:weigelt@metux.de">weigelt@metux.de</a></td><td>3_strip_useless_comments.diff</td><td><br></td><td \
style="vertical-align: top;">  Integrated</td><td style="vertical-align: \
top;"><br></td></tr> <tr><td style="vertical-align: top;">3<br></td><td \
                style="vertical-align: top;">remove noise in invoice module
      </td><td><a href="mailto:weigelt@metux.de">weigelt@metux.de</a></td><td>02_nekrad-remove-noise.diff</td><td>Hi \
folks,<br><br> this patch removes some noise in the invoice module ...<br><br>
cu</td><td style="vertical-align: top;">Not integrated<br></td><td \
style="vertical-align: top;">Expected behaviour.<br></td></tr><tr><td \
style="vertical-align: top;">4<br></td><td style="vertical-align: top;">  \
PearDatabase.php sanity check  in	Move()</td><td><a \
href="mailto:weigelt@metux.de">weigelt@metux.de</a></td><td>08_nekrad_peardb_sanitycheck-1.diff</td><td>Hi \
folks,<br><br> as we sometimes get some errors like:<br><br>
# Fatal error: Call to a member function Move() on a non-object <br>
# in .../include/database/PearDatabase.php on line 443<br><br>
Obviously sometimes the query_result() method is called with an<br>
non-existing result object.<br><br>
This patch adds an check which throws an exception on missing <br>
result object, so we can easily track it down.<br><br><br>
cu</td><td style="vertical-align: top;">  Integrated</td><td style="vertical-align: \
top;"><br></td></tr><tr><td style="vertical-align: top;">5<br></td><td \
                style="vertical-align: top;">Invoice: fix PDF link
      </td><td><a href="mailto:weigelt@metux.de">weigelt@metux.de</a></td><td>invoice-link-pdf.diff<br></td><td>Hi \
folks,<br><br> this patch fixes the really strange javascript link for pdf<br>
invoice to an plain url.<br><br>
cu</td><td style="vertical-align: top;">Different fix has been integrated.<br>
</td><td style="vertical-align: top;"><br></td></tr><tr><td style="vertical-align: \
top;">6<br></td><td style="vertical-align: top;"> some new $adb (PearDatabase) \
                methods
      </td><td><a href="mailto:weigelt@metux.de">weigelt@metux.de</a></td><td>09_nekrad_peardb-newfuncs.diff<br></td><td>Hi \
folks,<br><br> this patch adds two new functions to the PearDatabase ($adb) <br>
class:<br><br>
* sql_concat(array):<br>
  generates an sql expression for field concatenations, based <br>
  on selected RDBMS.<br><br>
* run_query_field(string):<br>
  executes an given SQL query and returns only the first field<br>
  of the first record.<br><br><br>
cu</td><td style="vertical-align: top;"> Integrated</td><td style="vertical-align: \
top;"><br></td></tr><tr><td style="vertical-align: top;">7<br></td><td \
                style="vertical-align: top;">leads module fix (postgres)
      </td><td><a href="mailto:weigelt@metux.de">weigelt@metux.de</a></td><td>31_nekrad-leads-fix.diff<br></td><td>Hi \
folks,<br><br><br> the leads module (Tracker.php) suffers from an sql bug: it \
uses<br> mysql specific sql statements for concatenating fields. This ends<br>
up in empty result objects and so the already mentioned error<br>
of trying to call Move() on non-object.<br><br>
This patch solves this by using the new PearDatabas::sql_concat()<br>
function (see prev. patch) for creating the statement.<br><br>
Also this patch calls the new PearDatabase::run_query_field()<br>
for the one-field-query.<br><br><br>
cu</td><td style="vertical-align: top;">Integrated with small modification.<br>
</td><td style="vertical-align: top;"><br></td></tr><tr><td style="vertical-align: \
top;">8<br></td><td style="vertical-align: top;">Link leak in calendar module \
calendar view</td><td><a href="mailto:jon@eyesopen.com">jon@eyesopen.com \
</a></td><td>calendarlink.patch</td><td><br></td><td style="vertical-align: \
top;">Integrated<br></td><td style="vertical-align: top;"><br></td></tr></tbody> \
</table> <br>Thanks &amp; Regards,<br>Minnie<br><br><div><span class="gmail_quote">On \
12/29/07, <b class="gmail_sendername">Enrico Weigelt</b> &lt;<a \
href="mailto:weigelt@metux.de">weigelt@metux.de</a>&gt; wrote:</span><blockquote \
class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt \
                0pt 0.8ex; padding-left: 1ex;">
* Enrico Weigelt &lt;<a href="mailto:weigelt@metux.de">weigelt@metux.de</a>&gt; \
schrieb:<br><br>Hi,<br><br>&gt; these patches add an universal rendering API for \
things like<br>&gt; invoices and an TeX renderer backend. The old invoice pdf code \
<br>&gt; is changed to run via the rendering API. Now it&#39;s very easy to<br>&gt; \
add new renderers. I also included my own templates as example.<br>&gt;<br>&gt; The \
API patch (renderapi-1) does not change anything but just <br>&gt; adding some new \
files in the lib/render/ subdir and could be<br>&gt; applied to 5.1 and 5.1_jens \
asap.<br><br>What&#39;s the current status on my this patch \
?<br><br><br>cu<br>_______________________________________________ <br>Reach hundreds \
of potential candidates - <a \
href="http://jobs.vtiger.com">http://jobs.vtiger.com</a><br></blockquote></div><br>



_______________________________________________
Reach hundreds of potential candidates - http://jobs.vtiger.com 

[prev in list] [next in list] [prev in thread] [next in thread] 

Configure | About | News | Add a list | Sponsored by KoreLogic