[prev in list] [next in list] [prev in thread] [next in thread] 

List:       velocity-dev
Subject:    Re: svn commit: r1683210 - in /velocity/engine/branches/1.x: build/BUILD_PARSER_README.txt src/java/
From:       Mike Kienenberger <mkienenb () gmail ! com>
Date:       2015-06-03 2:50:37
Message-ID: CAM1yOjZ5-gFeeB+D7qyJyyFyAN831czVdu=XFpSkf+9wDZ7FQg () mail ! gmail ! com
[Download RAW message or body]

Yeah, that bothered me as well, but I'm no expert on the parser, so I
didn't want to guess whether it was still applicable.  If I didn't
know, I left the original readme as-is.  Java 3.1 has been required
since 1.5, so it's been "wrong" for a long time.

Please feel free to improve it further.


On Tue, Jun 2, 2015 at 10:48 PM, Sergiu Dumitriu
<sergiu.dumitriu@gmail.com> wrote:
> On 06/02/2015 10:15 PM, mkienenb@apache.org wrote:
>> +In the event that something 'serious' changes, such as an AST node is created
>> +or altered, it must be *manually* moved to the node subdirectory, and have its
>> +package declaration fixed.  This should be an extremely rare event at this point
>> +and will change with javacc 2.0.
>
> Since we already require JavaCC 3.2+ does the "will change with javacc
> 2.0" part make sense?
>
>> +-gmj
>
> I'd remove this ^
>
> --
> Sergiu Dumitriu
> http://purl.org/net/sergiu/
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@velocity.apache.org
> For additional commands, e-mail: dev-help@velocity.apache.org
>

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@velocity.apache.org
For additional commands, e-mail: dev-help@velocity.apache.org

[prev in list] [next in list] [prev in thread] [next in thread]