[prev in list] [next in list] [prev in thread] [next in thread] 

List:       velocity-dev
Subject:    [jira] Updated: (VELOCITY-760) DataSourceResourceLoader doesn't
From:       "Nathan Bubna (JIRA)" <dev () velocity ! apache ! org>
Date:       2010-04-27 21:10:36
Message-ID: 22344203.41771272402636136.JavaMail.jira () thor
[Download RAW message or body]


     [ https://issues.apache.org/jira/browse/VELOCITY-760?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel \
]

Nathan Bubna updated VELOCITY-760:
----------------------------------

    Fix Version/s: 1.7

> DataSourceResourceLoader doesn't close PreparedStatements
> ---------------------------------------------------------
> 
> Key: VELOCITY-760
> URL: https://issues.apache.org/jira/browse/VELOCITY-760
> Project: Velocity
> Issue Type: Bug
> Components: Engine
> Affects Versions: 1.6.2
> Reporter: Jerome Waibel
> Fix For: 1.7
> 
> Attachments: velocity-760.patch
> 
> 
> DataSourceResourceLoader.java contains this method:
> private ResultSet readData(final Connection conn,
> final String columnNames,
> final String templateName) throws SQLException
> {
> PreparedStatement ps = conn.prepareStatement("SELECT " + columnNames + " FROM "+ \
> tableName + " WHERE " + keyColumn + " = ?"); ps.setString(1, templateName);
> return ps.executeQuery();
> }
> PreparedStatements created in this method never get closed, only the resultset \
> returned may eventually be closed later which isn't sufficient for releasing all \
> bound resources. In my project this statement leak lead to the oracle running out \
> of open cursors (the infamous ORA-01000 error). 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@velocity.apache.org
For additional commands, e-mail: dev-help@velocity.apache.org


[prev in list] [next in list] [prev in thread] [next in thread]