[prev in list] [next in list] [prev in thread] [next in thread] 

List:       velocity-dev
Subject:    [jira] Commented: (VELOCITY-681) [regression] Changes on the macro
From:       Jarkko_Viinamäki_(JIRA) <dev () velocity ! apache ! org>
Date:       2009-01-28 19:06:59
Message-ID: 579432751.1233169619567.JavaMail.jira () brutus
[Download RAW message or body]


    [ https://issues.apache.org/jira/browse/VELOCITY-681?page=com.atlassian.jira.plugi \
n.system.issuetabpanels:comment-tabpanel&focusedCommentId=12668112#action_12668112 ] 

Jarkko Viinamäki commented on VELOCITY-681:
-------------------------------------------

Unfortunately I don't have any time until Saturday to take a closer look at this but \
I still don't understand what those ".literal."-calls are doing in ProxyVMContext.

Question to the committer: do you fully understand what this patch does, why it does \
it so and how "render literal if null" functionality works?

My answer to that question at the moment is "no" (because I haven't had time to \
investigate) and therefore I would not blindly commit this. 

> [regression] Changes on the macro parameters are not persisted outside the macro \
>                 call
> -------------------------------------------------------------------------------------
>  
> Key: VELOCITY-681
> URL: https://issues.apache.org/jira/browse/VELOCITY-681
> Project: Velocity
> Issue Type: Bug
> Components: Engine
> Affects Versions: 1.6.1
> Reporter: Sergiu Dumitriu
> Priority: Critical
> Fix For: 1.6.2, 1.7
> 
> Attachments: VELOCITY-681-1.6.patch, VELOCITY-681-trunk.patch
> 
> 
> The fix for VELOCITY-615 was too radical, since it completely disables #setting new \
> values to the formal arguments. A minimalistic example that used to work up to 1.6 \
> (but not with 1.6.1) is: {noformat}
> #macro(myMacro $result)
> #set($result = 'some value')
> #end
> #myMacro($x)
> $x
> {/noformat}
> which prints $x (as an undefined variable).

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@velocity.apache.org
For additional commands, e-mail: dev-help@velocity.apache.org


[prev in list] [next in list] [prev in thread] [next in thread]