[prev in list] [next in list] [prev in thread] [next in thread] 

List:       vdsm-patches
Subject:    Change in vdsm[master]: m2c: signature change in getsockopt
From:       Code Review <gerrit () ovirt ! org>
Date:       2017-01-31 19:06:36
Message-ID: 201701311906.v0VJ6ahr021639 () gerrit ! ovirt ! org
[Download RAW message or body]

From Dan Kenigsberg <danken@redhat.com>:

Dan Kenigsberg has submitted this change and it was merged.

Change subject: m2c: signature change in getsockopt
......................................................................


m2c: signature change in getsockopt

In 0.23 m2c there was delegation to socket.getsockopt by using apply
function:

    def getsockopt(self, *args):
        return apply(self.socket.getsockopt, args)

Whereas in 0.25 the implementation has changed [1] to:

    def getsockopt(self, level, optname, buflen=None):
        return self.socket.getsockopt(level, optname, buflen)

The above issue is causing:

<type 'exceptions.TypeError'>:an integer is required

from /usr/lib64/python2.7/asyncore.py|set_reuse_addr|313

In order to fix it we need to unpack arg tuple ourselves.

[1]
https://gitlab.com/m2crypto/m2crypto/commit/6ffc9561a6cf3b5e1f4002d5cd2beef69023df56


Bug-Url: https://bugzilla.redhat.com/1414075
Change-Id: I851445fc6b7c463e062e5eb4964a40dd1d8a6fd5
Signed-off-by: Piotr Kliczewski <piotr.kliczewski@gmail.com>
---
M lib/vdsm/m2cutils.py
1 file changed, 3 insertions(+), 0 deletions(-)

Approvals:
  Piotr Kliczewski: Verified
  Jenkins CI: Passed CI tests
  Irit Goihman: Looks good to me, but someone else must approve
  Dan Kenigsberg: Looks good to me, approved
  Edward Haas: Looks good to me, but someone else must approve



-- 
To view, visit https://gerrit.ovirt.org/71246
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I851445fc6b7c463e062e5eb4964a40dd1d8a6fd5
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski@gmail.com>
Gerrit-Reviewer: Dan Kenigsberg <danken@redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh@redhat.com>
Gerrit-Reviewer: Irit Goihman <igoihman@redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski@gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei@redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation@ovirt.org>
_______________________________________________
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-leave@lists.fedorahosted.org

[prev in list] [next in list] [prev in thread] [next in thread]