[prev in list] [next in list] [prev in thread] [next in thread] 

List:       vdsm-patches
Subject:    Change in vdsm[master]: tests: Avoid global state modification using forked
From:       Code Review <gerrit () ovirt ! org>
Date:       2016-11-29 20:10:38
Message-ID: 201611292010.uATKAcRg004822 () gerrit ! ovirt ! org
[Download RAW message or body]

From Dan Kenigsberg <danken@redhat.com>:

Dan Kenigsberg has posted comments on this change.

Change subject: tests: Avoid global state modification using forked
......................................................................


Patch Set 1: -Code-Review

(1 comment)

https://gerrit.ovirt.org/#/c/67338/1/tests/moduleloader_test.py
File tests/moduleloader_test.py:

Line 39:             for f in files:
Line 40:                 utils.touchFile(os.path.join(path, f))
Line 41:             utils.touchFile(os.path.join(path, '__init__.py'))
Line 42:             sys.path.append(os.path.dirname(path))
Line 43:             yield importlib.import_module(os.path.basename(path))
> You don't need to monkey patch if you run in another process, this is compl
Do you suggest to run all tests (everywhere, not just this module) in a subprocess?
Line 44: 
Line 45:     @permutations(
Line 46:         [(('a.py', 'b.py'), ('a', 'b')),
Line 47:          (('a.py', 'b.py', 'a.pyc', 'a.pyioas'), ('a', 'b')),


-- 
To view, visit https://gerrit.ovirt.org/67338
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2130bcf39918c3c70ed9f8eb9c436c5c8f9c6c09
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <nsoffer@redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken@redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani@redhat.com>
Gerrit-Reviewer: Irit Goihman <igoihman@redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer@redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski@gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei@redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation@ovirt.org>
Gerrit-HasComments: Yes
_______________________________________________
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-leave@lists.fedorahosted.org

[prev in list] [next in list] [prev in thread] [next in thread]