[prev in list] [next in list] [prev in thread] [next in thread] 

List:       vdsm-patches
Subject:    Change in vdsm[master]: virt: Don't crash on missing <memory> in MutableDomainDescri...
From:       Code Review <gerrit () ovirt ! org>
Date:       2016-11-29 15:16:45
Message-ID: 201611291516.uATFGjD5013947 () gerrit ! ovirt ! org
[Download RAW message or body]

From Dan Kenigsberg <danken@redhat.com>:

Dan Kenigsberg has submitted this change and it was merged.

Change subject: virt: Don't crash on missing <memory> in MutableDomainDescriptor
......................................................................


virt: Don't crash on missing <memory> in MutableDomainDescriptor

During minidom->etree conversion changes and rebases, <memory> element stopped
being optional in MutableDomainDescriptor.get_memory_size.  This patch restores
the original behavior and adds a test for it.

Change-Id: I338956c5f27f7b670e6ef7854ede1f393e66713f
Signed-off-by: Milan Zamazal <mzamazal@redhat.com>
---
M tests/domainDescriptorTests.py
M vdsm/virt/domain_descriptor.py
2 files changed, 25 insertions(+), 2 deletions(-)

Approvals:
  Jenkins CI: Passed CI tests
  Francesco Romani: Looks good to me, approved
  Milan Zamazal: Verified



-- 
To view, visit https://gerrit.ovirt.org/67180
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I338956c5f27f7b670e6ef7854ede1f393e66713f
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Milan Zamazal <mzamazal@redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken@redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani@redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik <mpolednik@redhat.com>
Gerrit-Reviewer: Milan Zamazal <mzamazal@redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation@ovirt.org>
_______________________________________________
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-leave@lists.fedorahosted.org

[prev in list] [next in list] [prev in thread] [next in thread]