[prev in list] [next in list] [prev in thread] [next in thread] 

List:       vdsm-patches
Subject:    Change in vdsm[master]: after_vm_destroy.py: migrate to jsonrpc
From:       Code Review <gerrit () ovirt ! org>
Date:       2016-11-28 21:35:35
Message-ID: 201611282135.uASLZZjg025889 () gerrit ! ovirt ! org
[Download RAW message or body]

From Dan Kenigsberg <danken@redhat.com>:

Dan Kenigsberg has posted comments on this change.

Change subject: after_vm_destroy.py: migrate to jsonrpc
......................................................................


Patch Set 10: Code-Review-1

(1 comment)

https://gerrit.ovirt.org/#/c/62383/10/vdsm_hooks/vhostmd/after_vm_destroy.py
File vdsm_hooks/vhostmd/after_vm_destroy.py:

PS10, Line 30: use_tls=True
this means that the hook would fail if localhost has tls disabled. you may not want \
connect() to have the fancy logic, but it should sit somewhere.


-- 
To view, visit https://gerrit.ovirt.org/62383
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3f3fa6479dde2c4a1298d0ae167d888d9f7e020a
Gerrit-PatchSet: 10
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Irit Goihman <igoihman@redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken@redhat.com>
Gerrit-Reviewer: Irit Goihman <igoihman@redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Marcin Mirecki <mmirecki@redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer@redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski@gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei@redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation@ovirt.org>
Gerrit-HasComments: Yes
_______________________________________________
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-leave@lists.fedorahosted.org


[prev in list] [next in list] [prev in thread] [next in thread]