[prev in list] [next in list] [prev in thread] [next in thread] 

List:       vdsm-patches
Subject:    Change in vdsm[master]: tests: rename api_test.py -> api_response_test.py
From:       Code Review <gerrit () ovirt ! org>
Date:       2016-11-28 13:08:56
Message-ID: 201611281308.uASD8u38015962 () gerrit ! ovirt ! org
[Download RAW message or body]

From Dan Kenigsberg <danken@redhat.com>:

Dan Kenigsberg has submitted this change and it was merged.

Change subject: tests: rename api_test.py -> api_response_test.py
......................................................................


tests: rename api_test.py -> api_response_test.py

Cosmetic only change. We now have two test modules
which test related but different things, whose name
differs only by case.

This could be confusing for humans, and surely
confuses the Apple FS -with default settings.

Since we are very near to name shortage again[1],
we just rename api_test.py to api_response_test.py
to avoid the confusion.

+++

[1] $ git grep -i api Makefile.am
Makefile.am:47: API_test.py \
Makefile.am:49: api_response_test.py \
Makefile.am:153:        vdsmapi_test.py \
Makefile.am:156:        vmApiTests.py \
Makefile.am:173:        API_test.py \
Makefile.am:243:        vmApiTests.py \
Makefile.am:329:        apiData.py \

Change-Id: If8ad99b576a373d28dfa8086901b22f69d5f50b5
Signed-off-by: Francesco Romani <fromani@redhat.com>
---
M tests/Makefile.am
R tests/api_response_test.py
2 files changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Jenkins CI: Passed CI tests
  Dan Kenigsberg: Looks good to me, approved
  Francesco Romani: Verified
  Martin Polednik: Verified; Looks good to me, but someone else must approve



-- 
To view, visit https://gerrit.ovirt.org/67396
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: If8ad99b576a373d28dfa8086901b22f69d5f50b5
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani@redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken@redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani@redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik <mpolednik@redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation@ovirt.org>
_______________________________________________
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-leave@lists.fedorahosted.org

[prev in list] [next in list] [prev in thread] [next in thread]