[prev in list] [next in list] [prev in thread] [next in thread] 

List:       vdsm-patches
Subject:    Change in vdsm[master]: Introduce VolumeArtifacts
From:       alitke () redhat ! com
Date:       2016-03-31 18:07:35
Message-ID: 201603311807.u2VI7Zwn020866 () gerrit ! ovirt ! org
[Download RAW message or body]

Adam Litke has posted comments on this change.

Change subject: Introduce VolumeArtifacts
......................................................................


Patch Set 26:

(3 comments)

https://gerrit.ovirt.org/#/c/48097/26/tests/storage_volume_artifacts_test.py
File tests/storage_volume_artifacts_test.py:

Line 112:             vol = env.sd_manifest.produceVolume(self.img_id, self.vol_id)
Line 113:             self.assertEqual(volume.type2name(volume.LEAF_VOL),
Line 114:                              vol.getVolType())
Line 115:             self.assertEqual(artifacts.get_volume_preallocation(vol_format),
Line 116:                              vol.getType())
> I would test this property in a separate test in file and block volume, and
Done
Line 117:             self.assertEqual(desc, vol.getDescription())
Line 118:             self.assertEqual(volume.LEGAL_VOL, vol.getLegality())
Line 119:             self.assertEqual(size / volume.BLOCK_SIZE, vol.getSize())
Line 120:             self.assertEqual(vol_format, vol.getFormat())


Line 140: class FileVolumeArtifactsTests(VolumeArtifactsTestsMixin, VdsmTestCase):
Line 141: 
Line 142:     def fake_env(self):
Line 143:         return fake_file_env()
Line 144: 
> We should add a stupid test that get_volume_preallocate() returns SPARSE. O
Done
Line 145:     def test_new_image_create_metadata_failure(self):
Line 146:         # If we fail before the metadata is created we will have an empty
Line 147:         # image directory with a garbage collection prefix left behind
Line 148:         with self.fake_env() as env:


Line 211:         self.assertEqual(has_md, os.path.exists(artifacts.meta_volatile_path))
Line 212:         self.assertEqual(has_lease, os.path.exists(artifacts.lease_path))
Line 213:         self.assertEqual(has_volume, os.path.exists(artifacts.volume_path))
Line 214: 
Line 215:     def validate_artifacts(self, artifacts, env):
> env is unused
Needed for block volume tests coming up and I figured I might as well establish the interface now.
Line 216:         self.assertTrue(os.path.exists(artifacts.meta_volatile_path))
Line 217:         self.assertTrue(os.path.exists(artifacts.volume_path))
Line 218:         self.assertTrue(os.path.exists(artifacts.lease_path))
Line 219: 


-- 
To view, visit https://gerrit.ovirt.org/48097
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I352423e39a899b9b83ccf3b8f6c17ec433e9c353
Gerrit-PatchSet: 26
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke <alitke@redhat.com>
Gerrit-Reviewer: Adam Litke <alitke@redhat.com>
Gerrit-Reviewer: Ala Hino <ahino@redhat.com>
Gerrit-Reviewer: Amit Aviram <aaviram@redhat.com>
Gerrit-Reviewer: Daniel Erez <derez@redhat.com>
Gerrit-Reviewer: Freddy Rolland <frolland@redhat.com>
Gerrit-Reviewer: Greg Padgett <gpadgett@redhat.com>
Gerrit-Reviewer: Idan Shaby <ishaby@redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liron Aravot <laravot@redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk@redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer@redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan@redhat.com>
Gerrit-Reviewer: Vered Volansky <vvolansk@redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation@ovirt.org>
Gerrit-HasComments: Yes
_______________________________________________
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

[prev in list] [next in list] [prev in thread] [next in thread]