[prev in list] [next in list] [prev in thread] [next in thread] 

List:       vdsm-patches
Subject:    Change in vdsm[master]: set the # of vcpus for a VM (hot plug/unplug)
From:       fromani () redhat ! com
Date:       2013-12-31 17:27:40
Message-ID: 201312311727.rBVHRf6m007464 () gerrit ! ovirt ! org
[Download RAW message or body]

Francesco Romani has posted comments on this change.

Change subject: set the # of vcpus for a VM (hot plug/unplug)
......................................................................


Patch Set 11:

(2 comments)

just noticed a couple of minor things.

....................................................
File tests/vmTests.py
Line 45:                      'function': '0x0', 'type': 'pci'}
Line 46: 
Line 47:     def __init__(self, *args, **kwargs):
Line 48:         TestCaseBase.__init__(self, *args, **kwargs)
Line 49:         self.maxDiff = None
stray? seems unused.
Line 50:         self.conf = {'vmName': 'testVm',
Line 51:                      'vmId': '9ffe28b6-6134-4b1e-8804-1185f49c436f',
Line 52:                      'smp': '8', 'memSize': '1024', 'memGuaranteedSize': '512'}
Line 53: 


....................................................
File vdsm/API.py
Line 455:             return errCode['noVM']
Line 456: 
Line 457:         return curVm.hotunplugDisk(params)
Line 458: 
Line 459:     def setNumberOfCpus(self, vmId, numberOfCpus):
`vmId` is consumed by the wrapping method in BindingXMLRPC so it seems useless in this method
Line 460: 
Line 461:         if vmId is None or numberOfCpus is None:
Line 462:             self.log.error(
Line 463:                 'Missing one of required parameters: vmId, numberOfCpus')


-- 
To view, visit http://gerrit.ovirt.org/21789
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ief35e1d335737cd98d21a5413ac9f8ab9d824c3e
Gerrit-PatchSet: 11
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Roy Golan <rgolan@redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani@redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan@redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi@redhat.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr@redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

[prev in list] [next in list] [prev in thread] [next in thread]