[prev in list] [next in list] [prev in thread] [next in thread] 

List:       vdsm-patches
Subject:    Change in vdsm[master]: vdsm: Hardware information about POWER hosts
From:       danken () redhat ! com
Date:       2013-11-30 9:27:23
Message-ID: 201311300927.rAU9RNHK023118 () gerrit ! ovirt ! org
[Download RAW message or body]

Dan Kenigsberg has posted comments on this change.

Change subject: vdsm: Hardware information about POWER hosts
......................................................................


Patch Set 4: Code-Review+1

(2 comments)

Minor nits remain. Please add yourself as an AUTHOR, too.

....................................................
File vdsm.spec.in
Line 1055: %{python_sitearch}/%{vdsm_name}/define.py*
Line 1056: %{python_sitearch}/%{vdsm_name}/exception.py*
Line 1057: %{python_sitearch}/%{vdsm_name}/ipwrapper.py*
Line 1058: %{python_sitearch}/%{vdsm_name}/libvirtconnection.py*
Line 1059: %{python_sitearch}/%{vdsm_name}/netinfo.py*
Intentional?
Line 1060: 
Line 1061: %{python_sitearch}/%{vdsm_name}/qemuImg.py*
Line 1062: %{python_sitearch}/%{vdsm_name}/SecureXMLRPCServer.py*
Line 1063: %{python_sitearch}/%{vdsm_name}/netconfpersistence.py*


....................................................
File vdsm/Makefile.am
Line 31: 	clientIF.py \
Line 32: 	configNetwork.py \
Line 33: 	debugPluginClient.py \
Line 34: 	dmidecodeUtil.py \
Line 35: 	ppc64HardwareInfo.py \
Please keep sorted.
Line 36: 	guestIF.py \
Line 37: 	hooking.py \
Line 38: 	hooks.py \
Line 39: 	kaxmlrpclib.py \


-- 
To view, visit http://gerrit.ovirt.org/19395
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ice513b9386273a44146852944741578023c1e17a
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Vitor de Lima <vitor.lima@eldorado.org.br>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap@redhat.com>
Gerrit-Reviewer: Better Saggi <bettersaggi@gmail.com>
Gerrit-Reviewer: Dan Kenigsberg <danken@redhat.com>
Gerrit-Reviewer: Gustavo Frederico Temple Pedrosa <gustavo.pedrosa@eldorado.org.br>
Gerrit-Reviewer: Leonardo Bianconi <leonardo.bianconi@eldorado.org.br>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi@redhat.com>
Gerrit-Reviewer: Vitor de Lima <vitor.lima@eldorado.org.br>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei@redhat.com>
Gerrit-HasComments: Yes
_______________________________________________
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

[prev in list] [next in list] [prev in thread] [next in thread]