[prev in list] [next in list] [prev in thread] [next in thread] 

List:       vdsm-patches
Subject:    Change in vdsm[master]: Add iproute2 configurator
From:       asegurap () redhat ! com
Date:       2013-11-29 10:04:18
Message-ID: 201311291004.rATA4I8U012458 () gerrit ! ovirt ! org
[Download RAW message or body]

Antoni Segura Puimedon has posted comments on this change.

Change subject: Add iproute2 configurator
......................................................................


Patch Set 20: Verified-1

(1 comment)

Fails for when configurator is ifcgs (see comment).

....................................................
File vdsm/netconf/ifcfg.py
Line 48:         super(Ifcfg, self).__init__(ConfigWriter(), inRollback)
Line 49: 
Line 50:     def begin(self):
Line 51:         if self.configApplier is None:
Line 52:             self.configApplier = ConfigWriter()
Since you removed the unified persistence attribute, this will raise an AttributeError.
Line 53:         if self.unifiedPersistence and self.runningConfig is None:
Line 54:             self.runningConfig = RunningConfig()
Line 55: 
Line 56:     def rollback(self):


-- 
To view, visit http://gerrit.ovirt.org/15301
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I762cfa30f78c5a46507b86f53e98bcf79dfc5844
Gerrit-PatchSet: 20
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Mark Wu <wudxw@linux.vnet.ibm.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap@redhat.com>
Gerrit-Reviewer: Assaf Muller <amuller@redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron@redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken@redhat.com>
Gerrit-Reviewer: Itamar Heim <iheim@redhat.com>
Gerrit-Reviewer: Mark Wu <wudxw@linux.vnet.ibm.com>
Gerrit-Reviewer: Petr Å ebek <psebek@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

[prev in list] [next in list] [prev in thread] [next in thread]