[prev in list] [next in list] [prev in thread] [next in thread] 

List:       vdsm-patches
Subject:    Change in vdsm[master]: package: allow redefine user and group as configure options
From:       zhshzhou () linux ! vnet ! ibm ! com
Date:       2013-11-29 2:27:42
Message-ID: 201311290227.rAT2RgA3015524 () gerrit ! ovirt ! org
[Download RAW message or body]

Zhou Zheng Sheng has posted comments on this change.

Change subject: package: allow redefine user and group as configure options
......................................................................


Patch Set 2: Code-Review-1

(2 comments)

....................................................
File configure.ac
Line 121: 
Line 122: if grep -i ubuntu /etc/*-release; then
Line 123:   default_qemu_user=libvirt-qemu
Line 124:   default_qemu_group=kvm
Line 125: fi
Nice patch. I also agree that we do not need distribution default values in this \
script. Distribution default values should be in vdsm.spec and debian/rules. For \
example, in debian/rules, the override_dh_auto_configure target, it configures vdsm \
with the option "--with-qemu-group=kvm" and "--with-qemu-user=libvirt-qemu".

If you want to make vdsm user configurable, you can just follow how it configures \
qemu user line line 80. Line 126: 
Line 127: AC_ARG_WITH([vdsm-user],
Line 128:   AC_HELP_STRING([--with-vdsm-user],
Line 129:   [username to run vdsm daemon as @<:@default=platform dependent@:>@]),


Line 150: AC_SUBST(METADATAUSER)
Line 151: AC_SUBST(METADATAGROUP)
Line 152: 
Line 153: AC_ARG_WITH([qemu-user],
Line 154:   AC_HELP_STRING([--with-qemu-user],
It seems we already have this in line 80.
Line 155:   [username to run QEMU system instance as @<:@default=platform \
dependent@:>@]), Line 156:   [QEMUUSER=${withval}],
Line 157:   [QEMUUSER=${default_qemu_user}])
Line 158: AC_ARG_WITH([qemu-group],


-- 
To view, visit http://gerrit.ovirt.org/18703
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6033f2450551600ec172523ab038fdf157176a8f
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Alexey Shabalin <a.shabalin@gmail.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl@redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei@redhat.com>
Gerrit-Reviewer: Zhou Zheng Sheng <zhshzhou@linux.vnet.ibm.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches


[prev in list] [next in list] [prev in thread] [next in thread]