[prev in list] [next in list] [prev in thread] [next in thread] 

List:       vdsm-patches
Subject:    Change in vdsm[master]: NetReload: ConfigWriter, ifup/down to configurator
From:       wudxw () linux ! vnet ! ibm ! com
Date:       2013-03-29 7:45:56
Message-ID: 201303290745.r2T7juNp023978 () gerrit ! ovirt ! org
[Download RAW message or body]

Mark Wu has posted comments on this change.

Change subject: NetReload: ConfigWriter, ifup/down to configurator
......................................................................


Patch Set 9: Looks good to me, but someone else must approve

(1 inline comment)

....................................................
File vdsm/ifcfgConfigurator.py
Line 37: from vdsm import utils
Line 38: import neterrors as ne
Line 39: 
Line 40: # TODO: This constant is duplicated. Find a better place.
Line 41: DEFAULT_MTU = '1500'
I think we could move it and the one in configNetwork.py to netinfo.py
Line 42: 
Line 43: 
Line 44: class IfcfgConfigurator(object):
Line 45:     # TODO: Do all the configWriter interaction from here.


--
To view, visit http://gerrit.ovirt.org/13182
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8f28fa717eb501f61ed922cf2571181ff3b42532
Gerrit-PatchSet: 9
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Antoni Segura Puimedon <asegurap@redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap@redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken@redhat.com>
Gerrit-Reviewer: Mark Wu <wudxw@linux.vnet.ibm.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

[prev in list] [next in list] [prev in thread] [next in thread]