[prev in list] [next in list] [prev in thread] [next in thread] 

List:       vdsm-patches
Subject:    Change in vdsm[master]: libvirtvm: Removing libvirt snapshot metadata.
From:       apahim () redhat ! com (apahim at redhat ! com)
Date:       2012-11-29 20:40:47
Message-ID: 201211292040.qATKelUi013698 () gerrit ! ovirt ! org
[Download RAW message or body]

Amador Pahim has posted comments on this change.

Change subject: libvirtvm: Removing libvirt snapshot metadata.
......................................................................


Patch Set 3: (3 inline comments)

....................................................
Commit Message
Line 5: CommitDate: 2012-11-26 09:20:36 -0200
Line 6: 
Line 7: libvirtvm: Removing libvirt snapshot metadata.
Line 8: 
Line 9: Bug-Url: http://bugzilla.redhat.com/872277
Done
Line 10: 
Line 11: After creating a new snapshot, it is not possible
Line 12: to live migrate vm:
Line 13: 


Line 7: libvirtvm: Removing libvirt snapshot metadata.
Line 8: 
Line 9: Bug-Url: http://bugzilla.redhat.com/872277
Line 10: 
Line 11: After creating a new snapshot, it is not possible
Done
Line 12: to live migrate vm:
Line 13: 
Line 14:   libvirtError: Requested operation is not valid:
Line 15: cannot migrate domain with 1 snapshots


....................................................
File vdsm/libvirtvm.py
Line 1902: 
Line 1903:         self.log.debug(snapxml)
Line 1904:         self.stopDisksStatsCollection()
Line 1905: 
Line 1906:         snapFlags = (libvirt.VIR_DOMAIN_SNAPSHOT_CREATE_DISK_ONLY |
Indeed. It works.
Line 1907:                      libvirt.VIR_DOMAIN_SNAPSHOT_CREATE_REUSE_EXT)
Line 1908: 
Line 1909:         if utils.tobool(self.conf.get('qgaEnable', 'true')):
Line 1910:             snapFlags |= libvirt.VIR_DOMAIN_SNAPSHOT_CREATE_QUIESCE


--
To view, visit http://gerrit.ovirt.org/9139
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I928983a404f822522a0a48218f9c58fa8d6296b1
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Amador Pahim <apahim at redhat.com>
Gerrit-Reviewer: Amador Pahim <apahim at redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Gal Hammer <ghammer at redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek at redhat.com>
Gerrit-Reviewer: Peter V. Saveliev <peet at redhat.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server

[prev in list] [next in list] [prev in thread] [next in thread]