[prev in list] [next in list] [prev in thread] [next in thread] 

List:       vdsm-patches
Subject:    Change in vdsm[master]: Refactored configWriter add methods for code reuse.
From:       danken () redhat ! com (danken at redhat ! com)
Date:       2012-07-29 7:25:29
Message-ID: 201207290725.q6T7PTXQ009279 () gerrit ! ovirt ! org
[Download RAW message or body]

Dan Kenigsberg has submitted this change and it was merged.

Change subject: Refactored configWriter add methods for code reuse.
......................................................................


Refactored configWriter add methods for code reuse.

Moved the backup and write part into a separate method and added tests
for these add methods. The tests work by doing some monkey patching of the
open and the writeConfing method.

Change-Id: I7582950ae68731c71785b020330b7d207ed43aed
Signed-off-by: Antoni S. Puimedon <asegurap at redhat.com>
---
M vdsm/configNetwork.py
1 file changed, 43 insertions(+), 41 deletions(-)

Approvals:
  Dan Kenigsberg: Verified; Looks good to me, approved


--
To view, visit http://gerrit.ovirt.org/6366
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I7582950ae68731c71785b020330b7d207ed43aed
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky at redhat.com>
Gerrit-Reviewer: Livnat Peer <lpeer at redhat.com>

[prev in list] [next in list] [prev in thread] [next in thread]