[prev in list] [next in list] [prev in thread] [next in thread] 

List:       vdsm-patches
Subject:    Change in vdsm[master]: Close and remove the temporary file before raising a excepti...
From:       wenyi () linux ! vnet ! ibm ! com (wenyi at linux ! vnet ! ibm ! com)
Date:       2012-05-30 13:52:37
Message-ID: 201205301352.q4UDqbkl026925 () gerrit ! ovirt ! org
[Download RAW message or body]

Wenyi Gao has posted comments on this change.

Change subject: Close and remove the temporary file before raising a exception
......................................................................


Patch Set 1: (2 inline comments)

....................................................
File vdsm/storage/multipath.py
Line 116:     supported state. The original configuration, if any, is saved
Yes, it seems to make sense.

Line 121:     f.write(MPATH_CONF_TEMPLATE)
Good, suggestion.

--
To view, visit http://gerrit.ovirt.org/4885
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I93eafbcf78805669596258b3579ee49cc1b79360
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Wenyi Gao <wenyi at linux.vnet.ibm.com>
Gerrit-Reviewer: Adam Litke <agl at us.ibm.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Ryan Harper <ryanh at us.ibm.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: Shu Ming <shuming at linux.vnet.ibm.com>
Gerrit-Reviewer: Wenyi Gao <wenyi at linux.vnet.ibm.com>

[prev in list] [next in list] [prev in thread] [next in thread]