[prev in list] [next in list] [prev in thread] [next in thread]
List: vdsm-devel
Subject: =?utf-8?q?=5Bovirt-devel=5D?= Re: [VDSM] Trouble merging patch, related to jenkins whitelist or new
From: Ehud Yonasi <eyonasi () redhat ! com>
Date: 2020-08-03 7:35:27
Message-ID: CAC3Yk1+4XXoRY89MDe3E-7t04xfv3B-6CvS3Y--W4H3AT9rUXg () mail ! gmail ! com
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
Nir, I will.
On Mon, Aug 3, 2020 at 10:17 AM Nir Soffer <nsoffer@redhat.com> wrote:
>
>
> On Mon, Aug 3, 2020, 09:55 Ales Musil <amusil@redhat.com> wrote:
>
>>
>>
>> On Mon, Aug 3, 2020 at 8:51 AM Ehud Yonasi <eyonasi@redhat.com> wrote:
>>
>>> Try again please, I think it will now work.
>>>
>>
>> It does. Thank you.
>>
>>
>>>
>>> On Mon, Aug 3, 2020 at 9:47 AM Ales Musil <amusil@redhat.com> wrote:
>>>
>>>>
>>>>
>>>> On Mon, Aug 3, 2020 at 8:30 AM Ehud Yonasi <eyonasi@redhat.com> wrote:
>>>>
>>>>> Hey,
>>>>> That's my fault there, I've added the label to prepare for the rhel
>>>>> tests on ovirt and forgot to add the maintainers group.
>>>>>
>>>>
> Ehud, please discuss here changes to vdsm CI before applying them.
>
>
>>>>> Could you verify you can add it now?
>>>>>
>>>>
>>>> Unfortunately not. It still has the same message/error.
>>>>
>>>>
>>>>>
>>>>> Thanks,
>>>>> Ehud.
>>>>>
>>>>> On Mon, Aug 3, 2020 at 8:43 AM Ales Musil <amusil@redhat.com> wrote:
>>>>>
>>>>>>
>>>>>>
>>>>>> On Mon, Aug 3, 2020 at 2:24 AM Germano Veit Michel <
>>>>>> germano@redhat.com> wrote:
>>>>>>
>>>>>>>
>>>>>>>
>>>>>>> On Sat, Aug 1, 2020 at 7:11 AM Nir Soffer <nsoffer@redhat.com>
>>>>>>> wrote:
>>>>>>>
>>>>>>>> I could not merge:
>>>>>>>> https://gerrit.ovirt.org/c/109402/
>>>>>>>>
>>>>>>>> Although it was approved and verified, and got +1 from Continuous
>>>>>>>> Integration.
>>>>>>>>
>>>>>>>> There is a new "RHEL-Continuous-Integration", which does not run
>>>>>>>> with
>>>>>>>> this change,
>>>>>>>> even when I trigger the tests manually with "ci test".
>>>>>>>>
>>>>>>>> I tried to add +1 for "RHEL-Continuous-Integration" but this is not
>>>>>>>> possible, I see:
>>>>>>>>
>>>>>>>> RHEL-Continuous-Integration You don't have permission to edit
>>>>>>>> this label.
>>>>>>>>
>>>>>>>
>>>>>> I cannot merge anything as well. I wonder why maintainers don't get
>>>>>> the permission
>>>>>> for the new flag? Apparently the automation for this is not working
>>>>>> yet.
>>>>>>
>>>>>>
>>>>>>>
>>>>>>>> So finally I downloaded the patch and pushed it manually.
>>>>>>>>
>>>>>>>> I think this patch will fix the problem:
>>>>>>>> https://gerrit.ovirt.org/#/c/110576/
>>>>>>>>
>>>>>>>> But I need CI experts to review this. Since we have 50 projects
>>>>>>>> that need this,
>>>>>>>> this probably should be fixed elsewhere, and inherited by all
>>>>>>>> projects.
>>>>>>>>
>>>>>>>> I know that Germano was not able to trigger tests because he was
>>>>>>>> missing in the
>>>>>>>> jenkins whitelist, but this was fixed last week.
>>>>>>>>
>>>>>>>> Germano, maybe just to check that everything works for you, you can
>>>>>>>> post some
>>>>>>>> trivial patch?
>>>>>>>>
>>>>>>> Build and test are working for me now after contacting infra.
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>>>
>>>>>>>> Nir
>>>>>>>>
>>>>>>>>
>>>>>>
>>>>>> --
>>>>>>
>>>>>> Ales Musil
>>>>>>
>>>>>> Software Engineer - RHV Network
>>>>>>
>>>>>> Red Hat EMEA <https://www.redhat.com>
>>>>>>
>>>>>> amusil@redhat.com IM: amusil
>>>>>> <https://red.ht/sig>
>>>>>> _______________________________________________
>>>>>> Devel mailing list -- devel@ovirt.org
>>>>>> To unsubscribe send an email to devel-leave@ovirt.org
>>>>>> Privacy Statement: https://www.ovirt.org/privacy-policy.html
>>>>>> oVirt Code of Conduct:
>>>>>> https://www.ovirt.org/community/about/community-guidelines/
>>>>>> List Archives:
>>>>>> https://lists.ovirt.org/archives/list/devel@ovirt.org/message/GFIT7NPOYQUINUYLQR75LNRAWSXYH65L/
>>>>>>
>>>>>
>>>>
>>>> --
>>>>
>>>> Ales Musil
>>>>
>>>> Software Engineer - RHV Network
>>>>
>>>> Red Hat EMEA <https://www.redhat.com>
>>>>
>>>> amusil@redhat.com IM: amusil
>>>> <https://red.ht/sig>
>>>>
>>>
>>
>> --
>>
>> Ales Musil
>>
>> Software Engineer - RHV Network
>>
>> Red Hat EMEA <https://www.redhat.com>
>>
>> amusil@redhat.com IM: amusil
>> <https://red.ht/sig>
>> _______________________________________________
>> Infra mailing list -- infra@ovirt.org
>> To unsubscribe send an email to infra-leave@ovirt.org
>> Privacy Statement: https://www.ovirt.org/privacy-policy.html
>> oVirt Code of Conduct:
>> https://www.ovirt.org/community/about/community-guidelines/
>> List Archives:
>> https://lists.ovirt.org/archives/list/infra@ovirt.org/message/H7FLG4HKUDNGXXLIPZTBAVSL7DVKMVOK/
>>
>
[Attachment #5 (text/html)]
<div dir="ltr"><div class="gmail_default" style="font-family:georgia,serif">Nir, I \
will.</div></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On \
Mon, Aug 3, 2020 at 10:17 AM Nir Soffer <<a \
href="mailto:nsoffer@redhat.com">nsoffer@redhat.com</a>> \
wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px \
0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div \
dir="auto"><div><br><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On \
Mon, Aug 3, 2020, 09:55 Ales Musil <<a href="mailto:amusil@redhat.com" \
target="_blank">amusil@redhat.com</a>> wrote:<br></div><blockquote \
class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid \
rgb(204,204,204);padding-left:1ex"><div dir="ltr"><div dir="ltr"><br></div><br><div \
class="gmail_quote"><div dir="ltr" class="gmail_attr">On Mon, Aug 3, 2020 at 8:51 AM \
Ehud Yonasi <<a href="mailto:eyonasi@redhat.com" rel="noreferrer" \
target="_blank">eyonasi@redhat.com</a>> wrote:<br></div><blockquote \
class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid \
rgb(204,204,204);padding-left:1ex"><div dir="ltr"><div \
style="font-family:georgia,serif">Try again please, I think it will now \
work.<br></div></div></blockquote><div><br></div><div>It does. Thank you. \
<br></div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px \
0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr"><div \
style="font-family:georgia,serif"></div></div><br><div class="gmail_quote"><div \
dir="ltr" class="gmail_attr">On Mon, Aug 3, 2020 at 9:47 AM Ales Musil <<a \
href="mailto:amusil@redhat.com" rel="noreferrer" \
target="_blank">amusil@redhat.com</a>> wrote:<br></div><blockquote \
class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid \
rgb(204,204,204);padding-left:1ex"><div dir="ltr"><div dir="ltr"><br></div><br><div \
class="gmail_quote"><div dir="ltr" class="gmail_attr">On Mon, Aug 3, 2020 at 8:30 AM \
Ehud Yonasi <<a href="mailto:eyonasi@redhat.com" rel="noreferrer" \
target="_blank">eyonasi@redhat.com</a>> wrote:<br></div><blockquote \
class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid \
rgb(204,204,204);padding-left:1ex"><div dir="ltr"><div \
style="font-family:georgia,serif">Hey,</div><div \
style="font-family:georgia,serif">That's my fault there, I've added the label \
to prepare for the rhel tests on ovirt and forgot to add the maintainers \
group.</div></div></blockquote></div></div></blockquote></div></blockquote></div></div></blockquote></div></div><div \
dir="auto"><br></div><div dir="auto">Ehud, please discuss here changes to vdsm CI \
before applying them.</div><div dir="auto"><br></div><div dir="auto"><div \
class="gmail_quote"><blockquote class="gmail_quote" style="margin:0px 0px 0px \
0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr"><div \
class="gmail_quote"><blockquote class="gmail_quote" style="margin:0px 0px 0px \
0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div \
class="gmail_quote"><blockquote class="gmail_quote" style="margin:0px 0px 0px \
0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr"><div \
class="gmail_quote"><blockquote class="gmail_quote" style="margin:0px 0px 0px \
0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr"><div \
style="font-family:georgia,serif"><br></div><div \
style="font-family:georgia,serif">Could you verify you can add it now? \
<br></div></div></blockquote><div><br></div><div>Unfortunately not. It still has the \
same message/error. <br></div><div> </div><blockquote class="gmail_quote" \
style="margin:0px 0px 0px 0.8ex;border-left:1px solid \
rgb(204,204,204);padding-left:1ex"><div dir="ltr"><div \
style="font-family:georgia,serif"></div><div \
style="font-family:georgia,serif"><br></div><div \
style="font-family:georgia,serif">Thanks,</div><div \
style="font-family:georgia,serif">Ehud.<br></div></div><br><div \
class="gmail_quote"><div dir="ltr" class="gmail_attr">On Mon, Aug 3, 2020 at 8:43 AM \
Ales Musil <<a href="mailto:amusil@redhat.com" rel="noreferrer" \
target="_blank">amusil@redhat.com</a>> wrote:<br></div><blockquote \
class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid \
rgb(204,204,204);padding-left:1ex"><div dir="ltr"><div dir="ltr"><br></div><br><div \
class="gmail_quote"><div dir="ltr" class="gmail_attr">On Mon, Aug 3, 2020 at 2:24 AM \
Germano Veit Michel <<a href="mailto:germano@redhat.com" rel="noreferrer" \
target="_blank">germano@redhat.com</a>> wrote:<br></div><blockquote \
class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid \
rgb(204,204,204);padding-left:1ex"><div dir="ltr"><div dir="ltr"><br></div><br><div \
class="gmail_quote"><div dir="ltr" class="gmail_attr">On Sat, Aug 1, 2020 at 7:11 AM \
Nir Soffer <<a href="mailto:nsoffer@redhat.com" rel="noreferrer" \
target="_blank">nsoffer@redhat.com</a>> wrote:<br></div><blockquote \
class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid \
rgb(204,204,204);padding-left:1ex">I could not merge:<br> <a \
href="https://gerrit.ovirt.org/c/109402/" rel="noreferrer noreferrer" \
target="_blank">https://gerrit.ovirt.org/c/109402/</a><br> <br>
Although it was approved and verified, and got +1 from Continuous Integration.<br>
<br>
There is a new "RHEL-Continuous-Integration", which does not run with<br>
this change,<br>
even when I trigger the tests manually with "ci test".<br>
<br>
I tried to add +1 for "RHEL-Continuous-Integration" but this is not<br>
possible, I see:<br>
<br>
RHEL-Continuous-Integration You don't have permission to edit this \
label.<br></blockquote></div></div></blockquote><div><br></div><div>I cannot merge \
anything as well. I wonder why maintainers don't get the \
permission<br></div><div>for the new flag? Apparently the automation for this is not \
working yet. <br></div><div> </div><blockquote class="gmail_quote" \
style="margin:0px 0px 0px 0.8ex;border-left:1px solid \
rgb(204,204,204);padding-left:1ex"><div dir="ltr"><div \
class="gmail_quote"><blockquote class="gmail_quote" style="margin:0px 0px 0px \
0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"> <br>
So finally I downloaded the patch and pushed it manually.<br>
<br>
I think this patch will fix the problem:<br>
<a href="https://gerrit.ovirt.org/#/c/110576/" rel="noreferrer noreferrer" \
target="_blank">https://gerrit.ovirt.org/#/c/110576/</a><br> <br>
But I need CI experts to review this. Since we have 50 projects that need this,<br>
this probably should be fixed elsewhere, and inherited by all projects.<br>
<br>
I know that Germano was not able to trigger tests because he was missing in the<br>
jenkins whitelist, but this was fixed last week.<br>
<br>
Germano, maybe just to check that everything works for you, you can post some<br>
trivial patch?<br></blockquote><div>Build and test are working for me now after \
contacting infra.</div><div></div><div><br></div><div> </div><blockquote \
class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid \
rgb(204,204,204);padding-left:1ex"> <br>
Nir<br>
<br>
</blockquote></div></div>
</blockquote></div><br clear="all"><br>-- <br><div dir="ltr"><div dir="ltr"><div><div \
dir="ltr"><div>
<p style="font-weight:bold;margin:0px;padding:0px;font-size:14px;text-transform:capitalize;font-family:"RedHatText",sans-serif">
<span>Ales</span> <span>Musil</span><span \
style="color:rgb(170,170,170);margin:0px"></span> </p>
<p style="font-weight:normal;font-size:12px;margin:0px;text-transform:capitalize;font-family:"RedHatText",sans-serif"><span>Software \
Engineer - RHV Network</span> </p>
<p style="font-weight:normal;margin:0px 0px \
4px;font-size:12px;font-family:"RedHatText",sans-serif"> <a \
style="color:rgb(0,136,206);font-size:12px;margin:0px;text-decoration:none;font-family:"RedHatText",sans-serif" \
href="https://www.redhat.com" rel="noreferrer" target="_blank">Red Hat \
<span>EMEA</span></a> </p>
<div style="margin-bottom:4px">
</div>
<p style="font-weight:normal;margin:0px;font-size:12px;font-family:"RedHatText",sans-serif">
<span style="margin:0px;padding:0px"><a \
style="color:rgb(0,0,0);font-size:12px;margin:0px;text-decoration:none;font-family:"RedHatText",sans-serif" \
href="mailto:amusil@redhat.com" rel="noreferrer" \
target="_blank">amusil@redhat.com</a> </span>
<span>IM: <span>amusil</span></span>
</p>
<div style="margin-top:12px">
<table border="0">
<tbody><tr>
<td width="100px"><a href="https://red.ht/sig" rel="noreferrer" \
target="_blank"> <img \
src="https://static.redhat.com/libs/redhat/brand-assets/latest/corp/logo.png" \
width="90" height="auto"></a> </td>
</tr>
</tbody></table>
</div>
</div></div></div></div></div></div>
_______________________________________________<br>
Devel mailing list -- <a href="mailto:devel@ovirt.org" rel="noreferrer" \
target="_blank">devel@ovirt.org</a><br> To unsubscribe send an email to <a \
href="mailto:devel-leave@ovirt.org" rel="noreferrer" \
target="_blank">devel-leave@ovirt.org</a><br> Privacy Statement: <a \
href="https://www.ovirt.org/privacy-policy.html" rel="noreferrer noreferrer" \
target="_blank">https://www.ovirt.org/privacy-policy.html</a><br> oVirt Code of \
Conduct: <a href="https://www.ovirt.org/community/about/community-guidelines/" \
rel="noreferrer noreferrer" \
target="_blank">https://www.ovirt.org/community/about/community-guidelines/</a><br> \
List Archives: <a href="https://lists.ovirt.org/archives/list/devel@ovirt.org/message/GFIT7NPOYQUINUYLQR75LNRAWSXYH65L/" \
rel="noreferrer noreferrer" \
target="_blank">https://lists.ovirt.org/archives/list/devel@ovirt.org/message/GFIT7NPOYQUINUYLQR75LNRAWSXYH65L/</a><br>
</blockquote></div>
</blockquote></div><br clear="all"><br>-- <br><div dir="ltr"><div dir="ltr"><div><div \
dir="ltr"><div>
<p style="font-weight:bold;margin:0px;padding:0px;font-size:14px;text-transform:capitalize;font-family:"RedHatText",sans-serif">
<span>Ales</span> <span>Musil</span><span \
style="color:rgb(170,170,170);margin:0px"></span> </p>
<p style="font-weight:normal;font-size:12px;margin:0px;text-transform:capitalize;font-family:"RedHatText",sans-serif"><span>Software \
Engineer - RHV Network</span> </p>
<p style="font-weight:normal;margin:0px 0px \
4px;font-size:12px;font-family:"RedHatText",sans-serif"> <a \
style="color:rgb(0,136,206);font-size:12px;margin:0px;text-decoration:none;font-family:"RedHatText",sans-serif" \
href="https://www.redhat.com" rel="noreferrer" target="_blank">Red Hat \
<span>EMEA</span></a> </p>
<div style="margin-bottom:4px">
</div>
<p style="font-weight:normal;margin:0px;font-size:12px;font-family:"RedHatText",sans-serif">
<span style="margin:0px;padding:0px"><a \
style="color:rgb(0,0,0);font-size:12px;margin:0px;text-decoration:none;font-family:"RedHatText",sans-serif" \
href="mailto:amusil@redhat.com" rel="noreferrer" \
target="_blank">amusil@redhat.com</a> </span>
<span>IM: <span>amusil</span></span>
</p>
<div style="margin-top:12px">
<table border="0">
<tbody><tr>
<td width="100px"><a href="https://red.ht/sig" rel="noreferrer" \
target="_blank"> <img \
src="https://static.redhat.com/libs/redhat/brand-assets/latest/corp/logo.png" \
width="90" height="auto"></a> </td>
</tr>
</tbody></table>
</div>
</div></div></div></div></div></div>
</blockquote></div>
</blockquote></div><br clear="all"><br>-- <br><div dir="ltr"><div dir="ltr"><div><div \
dir="ltr"><div>
<p style="font-weight:bold;margin:0px;padding:0px;font-size:14px;text-transform:capitalize;font-family:"RedHatText",sans-serif">
<span>Ales</span> <span>Musil</span><span \
style="color:rgb(170,170,170);margin:0px"></span> </p>
<p style="font-weight:normal;font-size:12px;margin:0px;text-transform:capitalize;font-family:"RedHatText",sans-serif"><span>Software \
Engineer - RHV Network</span> </p>
<p style="font-weight:normal;margin:0px 0px \
4px;font-size:12px;font-family:"RedHatText",sans-serif"> <a \
style="color:rgb(0,136,206);font-size:12px;margin:0px;text-decoration:none;font-family:"RedHatText",sans-serif" \
href="https://www.redhat.com" rel="noreferrer" target="_blank">Red Hat \
<span>EMEA</span></a> </p>
<div style="margin-bottom:4px">
</div>
<p style="font-weight:normal;margin:0px;font-size:12px;font-family:"RedHatText",sans-serif">
<span style="margin:0px;padding:0px"><a \
style="color:rgb(0,0,0);font-size:12px;margin:0px;text-decoration:none;font-family:"RedHatText",sans-serif" \
href="mailto:amusil@redhat.com" rel="noreferrer" \
target="_blank">amusil@redhat.com</a> </span>
<span>IM: <span>amusil</span></span>
</p>
<div style="margin-top:12px">
<table border="0">
<tbody><tr>
<td width="100px"><a href="https://red.ht/sig" rel="noreferrer" \
target="_blank"> <img \
src="https://static.redhat.com/libs/redhat/brand-assets/latest/corp/logo.png" \
width="90" height="auto"></a> </td>
</tr>
</tbody></table>
</div>
</div></div></div></div></div></div>
_______________________________________________<br>
Infra mailing list -- <a href="mailto:infra@ovirt.org" rel="noreferrer" \
target="_blank">infra@ovirt.org</a><br> To unsubscribe send an email to <a \
href="mailto:infra-leave@ovirt.org" rel="noreferrer" \
target="_blank">infra-leave@ovirt.org</a><br> Privacy Statement: <a \
href="https://www.ovirt.org/privacy-policy.html" rel="noreferrer noreferrer" \
target="_blank">https://www.ovirt.org/privacy-policy.html</a><br> oVirt Code of \
Conduct: <a href="https://www.ovirt.org/community/about/community-guidelines/" \
rel="noreferrer noreferrer" \
target="_blank">https://www.ovirt.org/community/about/community-guidelines/</a><br> \
List Archives: <a href="https://lists.ovirt.org/archives/list/infra@ovirt.org/message/H7FLG4HKUDNGXXLIPZTBAVSL7DVKMVOK/" \
rel="noreferrer noreferrer" \
target="_blank">https://lists.ovirt.org/archives/list/infra@ovirt.org/message/H7FLG4HKUDNGXXLIPZTBAVSL7DVKMVOK/</a><br>
</blockquote></div></div></div>
</blockquote></div>
[Attachment #6 (text/plain)]
_______________________________________________
Devel mailing list -- devel@ovirt.org
To unsubscribe send an email to devel-leave@ovirt.org
Privacy Statement: https://www.ovirt.org/privacy-policy.html
oVirt Code of Conduct: https://www.ovirt.org/community/about/community-guidelines/
List Archives: https://lists.ovirt.org/archives/list/devel@ovirt.org/message/TBH6FXQHANVZISR7CLTZK2WVVJR5ZUMA/
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic