[prev in list] [next in list] [prev in thread] [next in thread]
List: vdsm-devel
Subject: =?utf-8?q?=5Bovirt-devel=5D?= Re: OST 100_basic_ui_sanity.virtual_machines
From: Lucia Jelinkova <ljelinko () redhat ! com>
Date: 2020-03-23 12:13:16
Message-ID: CAMq-9uJDzPmaq5q+ynm0e=Uw3dCcfMoeqL6gS6SkT+qoPoqLdQ () mail ! gmail ! com
[Download RAW message or body]
[Attachment #2 (multipart/related)]
[Attachment #4 (multipart/alternative)]
Hi all,
the notifications handling is a bit tricky, but it is not possible for the
test just to ignore them since they cover the action buttons and the test
cannot click the buttons Yes, we can get rid of them by clicking "Do not
disturb" or we can simply wait until they disappear and the action button
is visible again. But I'd prefer the notifications to be part of the
workflow because that is something a real user does so I'd give it a try.
Anyway, I believe that these problems with the notifications in the OST UI
tests only reflect the problem the real users have - namely that the
notifications cover the action buttons.The following patch by Radek should
solve it - the notifications will be displayed at the bottom right corner
so they would not cover the action buttons.
https://gerrit.ovirt.org/#/c/107710/
Regards,
Lucia
On Mon, Mar 23, 2020 at 9:34 AM Radoslaw Szwajkowski <rszwajko@redhat.com>
wrote:
> Hi guys,
> if closing notification was proven to be unstable then I would rather
> remove it from the suite and concentrate on the happy path.
> Of course I assume we care only about jenkins - if we want to make the
> tests run locally on every possible browser/hardware combination then we
> might need to remove even more features.
>
> best regards,
> Radek
>
> On Sat, Mar 21, 2020 at 8:26 PM Michal Skrivanek <
> michal.skrivanek@redhat.com> wrote:
>
> >
> >
> > On 20 Mar 2020, at 10:13, Lucia Jelinkova <ljelinko@redhat.com> wrote:
> >
> > Hi all,
> >
> > the patch that should improve notifications handling in the UI test has
> > been merged. If you see more issues, please let me know.
> >
> >
> > Hi Lucia,
> > unfortunately I still see issues. It still doesn't close the notification
> > properly and in my case fails to click on "Power Off" in chrome.
> > Test is clicking to 1222, 153. Maybe just move it 20 pixels to the left
> > and that should do the job…
> >
> > Thanks,
> > michal
> >
> >
> > Regards,
> >
> > Lucia
> >
> > On Wed, Mar 18, 2020 at 2:38 PM Lucia Jelinkova <ljelinko@redhat.com>
> > wrote:
> >
> > > Thank you Marcin,
> > >
> > > I'll post a patch for that.
> > >
> > > Lucia
> > >
> > > On Wed, Mar 18, 2020 at 2:24 PM Marcin Sobczyk <msobczyk@redhat.com>
> > > wrote:
> > >
> > > > Hi,
> > > >
> > > > On 3/16/20 8:59 AM, Michal Skrivanek wrote:
> > > >
> > > >
> > > >
> > > > On 16 Mar 2020, at 08:20, Dominik Holler <dholler@redhat.com> wrote:
> > > >
> > > > Hello Lucia,
> > > > I am unsure if the change queue is happy. Also the changes I merged
> > > > might be a problem, but looks like
> > > > 100_basic_ui_sanity.virtual_machines is still blocking in
> > > > https://jenkins.ovirt.org/job/ovirt-master_change-queue-tester/21208/
> > > >
> > > > Do you have an idea how to fix this?
> > > >
> > > >
> > > > manual is running just fine.
> > > > log doesn't tell which OST commit it is running so we can't tell Im
> > > > afraid…
> > > >
> > > >
> > > > Thanks
> > > > Dominik
> > > >
> > > >
> > > > On Fri, Mar 13, 2020 at 10:21 AM Lucia Jelinkova <ljelinko@redhat.com>
> > > > wrote:
> > > >
> > > > > Hello,
> > > > >
> > > > > the notification was not closed properly in the test. The fix was
> > > > > merged this morning. Please let me know if you see any other issues with
> > > > > OST UI tests.
> > > > >
> > > > I've experienced this again today while trying to run gating jobs for
> > > > my OST patches:
> > > >
> > > > https://jenkins.ovirt.org/job/ovirt-system-tests_gate/446
> > > >
> > > >
> > > > > Regards,
> > > > >
> > > > > Lucia
> > > > >
> > > > > On Fri, Mar 13, 2020 at 7:53 AM Dominik Holler <dholler@redhat.com>
> > > > > wrote:
> > > > >
> > > > > > Hello,
> > > > > > 100_basic_ui_sanity.virtual_machines seems to fail on current master.
> > > > > > Any ideas why?
> > > > > >
> > > > > >
> > > > > > Please fine more details in
> > > > > >
> > > > > > https://jenkins.ovirt.org/job/ovirt-master_change-queue-tester/21197/testReport/junit/(root)/100_basic_ui_sanity/virtual_machines/
> > > > > >
> > > > > >
> > > > > > _______________________________________________
> > > > > > Devel mailing list -- devel@ovirt.org
> > > > > > To unsubscribe send an email to devel-leave@ovirt.org
> > > > > > Privacy Statement: https://www.ovirt.org/privacy-policy.html
> > > > > > oVirt Code of Conduct:
> > > > > > https://www.ovirt.org/community/about/community-guidelines/
> > > > > > List Archives:
> > > > > > https://lists.ovirt.org/archives/list/devel@ovirt.org/message/FT475CDDOEPDK4KVOZLJXF6JW5YERKEN/
> > > > > >
> > > > > _______________________________________________
> > > > Devel mailing list -- devel@ovirt.org
> > > > To unsubscribe send an email to devel-leave@ovirt.org
> > > > Privacy Statement: https://www.ovirt.org/privacy-policy.html
> > > > oVirt Code of Conduct:
> > > > https://www.ovirt.org/community/about/community-guidelines/
> > > > List Archives:
> > > > https://lists.ovirt.org/archives/list/devel@ovirt.org/message/SSUP6XTRKOZB3AG62OJTT3QVUOGPTHNS/
> > > >
> > > >
> > > >
> > > > _______________________________________________
> > > > Devel mailing list -- devel@ovirt.org
> > > > To unsubscribe send an email to devel-leave@ovirt.org
> > > > Privacy Statement: https://www.ovirt.org/privacy-policy.html
> > > > oVirt Code of Conduct: \
> > > > https://www.ovirt.org/community/about/community-guidelines/ List Archives: \
> > > > https://lists.ovirt.org/archives/list/devel@ovirt.org/message/5HDJ2FPC4LW27A46VEQZUDOA6D5H6MRQ/
> > > >
> > > >
> > > >
> >
[Attachment #7 (text/html)]
<div dir="ltr"><div>Hi all, <br></div><div><br></div><div>the notifications handling \
is a bit tricky, but it is not possible for the test just to ignore them since they \
cover the action buttons and the test cannot click the buttons Yes, we can get rid of \
them by clicking "Do not disturb" or we can simply wait until they \
disappear and the action button is visible again. But I'd prefer the \
notifications to be part of the workflow because that is something a real user does \
so I'd give it a try. <br></div><div><br></div><div>Anyway, I believe that these \
problems with the notifications in the OST UI tests only reflect the problem the real \
users have - namely that the notifications cover the action buttons.The following \
patch by Radek should solve it - the notifications will be displayed at the bottom \
right corner so they would not cover the action buttons. \
<br></div><div><br></div><div><a \
href="https://gerrit.ovirt.org/#/c/107710/">https://gerrit.ovirt.org/#/c/107710/</a></div><div><br></div><div>Regards, \
<br></div><div><br></div><div>Lucia<br></div><div><br></div></div><br><div \
class="gmail_quote"><div dir="ltr" class="gmail_attr">On Mon, Mar 23, 2020 at 9:34 AM \
Radoslaw Szwajkowski <<a \
href="mailto:rszwajko@redhat.com">rszwajko@redhat.com</a>> \
wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px \
0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr"><div \
dir="ltr"><div>Hi guys,</div><div>if closing notification was proven to be unstable \
then I would rather remove it from the suite and concentrate on the happy \
path.</div><div>Of course I assume we care only about jenkins - if we want to make \
the tests run locally on every possible browser/hardware combination then we might \
need to remove even more features.</div><div><br></div><div>best \
regards,</div><div>Radek<br></div></div><br><div class="gmail_quote"><div dir="ltr" \
class="gmail_attr">On Sat, Mar 21, 2020 at 8:26 PM Michal Skrivanek <<a \
href="mailto:michal.skrivanek@redhat.com" \
target="_blank">michal.skrivanek@redhat.com</a>> wrote:<br></div><blockquote \
class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid \
rgb(204,204,204);padding-left:1ex"><div><br><div><br><blockquote type="cite"><div>On \
20 Mar 2020, at 10:13, Lucia Jelinkova <<a href="mailto:ljelinko@redhat.com" \
target="_blank">ljelinko@redhat.com</a>> wrote:</div><br><div><div \
dir="ltr"><div>Hi all, <br></div><div><br></div><div>the patch that should improve \
notifications handling in the UI test has been merged. If you see more issues, please \
let me know. <br></div></div></div></blockquote><div><br></div>Hi \
Lucia,</div><div>unfortunately I still see issues. It still doesn't close the \
notification properly and in my case fails to click on "Power Off" in \
chrome.</div><div>Test is clicking to 1222, 153. Maybe just move it 20 pixels to the \
left and that should do the \
job…</div><div><br></div><div>Thanks,</div><div>michal</div><div><img \
id="gmail-m_-4140728668908796466gmail-m_-3020585844462927222496C3F43-3EBE-406D-9EFE-DE5AA44FED1C" \
src="cid:171067c95bb17173eaa1"><br><blockquote type="cite"><div><div \
dir="ltr"><div><br></div><div>Regards,</div><div><br></div><div>Lucia<br></div></div><br><div \
class="gmail_quote"><div dir="ltr" class="gmail_attr">On Wed, Mar 18, 2020 at 2:38 PM \
Lucia Jelinkova <<a href="mailto:ljelinko@redhat.com" \
target="_blank">ljelinko@redhat.com</a>> wrote:<br></div><blockquote \
class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid \
rgb(204,204,204);padding-left:1ex"><div dir="ltr"><div>Thank you Marcin, \
<br></div><div><br></div><div>I'll post a patch for that. \
<br></div><div><br></div><div>Lucia<br></div></div><br><div class="gmail_quote"><div \
dir="ltr" class="gmail_attr">On Wed, Mar 18, 2020 at 2:24 PM Marcin Sobczyk <<a \
href="mailto:msobczyk@redhat.com" target="_blank">msobczyk@redhat.com</a>> \
wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px \
0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
<div>
Hi,<br>
<br>
<div>On 3/16/20 8:59 AM, Michal Skrivanek
wrote:<br>
</div>
<blockquote type="cite">
<br>
<div><br>
<blockquote type="cite">
<div>On 16 Mar 2020, at 08:20, Dominik Holler <<a \
href="mailto:dholler@redhat.com" target="_blank">dholler@redhat.com</a>> \
wrote:</div> <br>
<div>
<div dir="ltr">
<div dir="ltr">
<div>Hello Lucia,</div>
<div>I am unsure if the change queue is happy.
Also the changes I merged might be a problem, but
looks like</div>
<div>100_basic_ui_sanity.virtual_machines is
still blocking in<br>
</div>
<div><a \
href="https://jenkins.ovirt.org/job/ovirt-master_change-queue-tester/21208/" \
target="_blank">https://jenkins.ovirt.org/job/ovirt-master_change-queue-tester/21208/</a></div>
<div><br>
</div>
<div>Do you have an idea how to fix this?</div>
</div>
</div>
</div>
</blockquote>
<div><br>
</div>
manual is running just fine. </div>
<div>log doesn't tell which OST commit it is running so we can't
tell Im afraid…</div>
<div><br>
</div>
<div><br>
<blockquote type="cite">
<div>
<div dir="ltr">
<div dir="ltr">
<div>Thanks</div>
<div>Dominik<br>
</div>
<div><br>
</div>
</div>
<br>
<div class="gmail_quote">
<div dir="ltr" class="gmail_attr">On Fri, Mar 13, 2020
at 10:21 AM Lucia Jelinkova <<a \
href="mailto:ljelinko@redhat.com" target="_blank">ljelinko@redhat.com</a>> \
wrote:<br> </div>
<blockquote class="gmail_quote" style="margin:0px 0px 0px \
0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"> <div dir="ltr">
<div>Hello, <br>
</div>
<div><br>
</div>
<div>the notification was not closed
properly in the test. The fix was merged this
morning. Please let me know if you see any other
issues with OST UI tests. <br>
</div>
</div>
</blockquote>
</div>
</div>
</div>
</blockquote>
</div>
</blockquote>
I've experienced this again today while trying to run gating jobs
for my OST patches:<br>
<br>
<a href="https://jenkins.ovirt.org/job/ovirt-system-tests_gate/446" \
target="_blank">https://jenkins.ovirt.org/job/ovirt-system-tests_gate/446</a><br> \
<br> <blockquote type="cite">
<div>
<blockquote type="cite">
<div>
<div dir="ltr">
<div class="gmail_quote">
<blockquote class="gmail_quote" style="margin:0px 0px 0px \
0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"> <div dir="ltr">
<div><br>
</div>
<div>Regards, <br>
</div>
<div><br>
</div>
<div>Lucia<br>
</div>
</div>
<br>
<div class="gmail_quote">
<div dir="ltr" class="gmail_attr">On Fri, Mar 13,
2020 at 7:53 AM Dominik Holler <<a \
href="mailto:dholler@redhat.com" target="_blank">dholler@redhat.com</a>> \
wrote:<br> </div>
<blockquote class="gmail_quote" style="margin:0px 0px 0px \
0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"> <div dir="ltr">
<div>Hello,</div>
<div>100_basic_ui_sanity.virtual_machines
seems to fail on current master.</div>
<div>Any ideas why?</div>
<div><br>
</div>
<div><br>
</div>
<div>Please fine more details in</div>
<div><a \
href="https://jenkins.ovirt.org/job/ovirt-master_change-queue-tester/21197/testReport/junit/(root)/100_basic_ui_sanity/virtual_machines/" \
target="_blank">https://jenkins.ovirt.org/job/ovirt-master_change-queue-tester/21197/testReport/junit/(root)/100_basic_ui_sanity/virtual_machines/</a></div>
<div><br>
</div>
<div><br>
</div>
</div>
_______________________________________________<br>
Devel mailing list -- <a href="mailto:devel@ovirt.org" \
target="_blank">devel@ovirt.org</a><br>
To unsubscribe send an email to <a \
href="mailto:devel-leave@ovirt.org" target="_blank">devel-leave@ovirt.org</a><br> \
Privacy Statement: <a href="https://www.ovirt.org/privacy-policy.html" \
rel="noreferrer" target="_blank">https://www.ovirt.org/privacy-policy.html</a><br> \
oVirt Code of Conduct: <a \
href="https://www.ovirt.org/community/about/community-guidelines/" rel="noreferrer" \
target="_blank">https://www.ovirt.org/community/about/community-guidelines/</a><br> \
List Archives: <a href="https://lists.ovirt.org/archives/list/devel@ovirt.org/message/FT475CDDOEPDK4KVOZLJXF6JW5YERKEN/" \
rel="noreferrer" target="_blank">https://lists.ovirt.org/archives/list/devel@ovirt.org/message/FT475CDDOEPDK4KVOZLJXF6JW5YERKEN/</a><br>
</blockquote>
</div>
</blockquote>
</div>
</div>
_______________________________________________<br>
Devel mailing list -- <a href="mailto:devel@ovirt.org" \
target="_blank">devel@ovirt.org</a><br>
To unsubscribe send an email to <a href="mailto:devel-leave@ovirt.org" \
target="_blank">devel-leave@ovirt.org</a><br>
Privacy Statement: <a href="https://www.ovirt.org/privacy-policy.html" \
target="_blank">https://www.ovirt.org/privacy-policy.html</a><br> oVirt Code of \
Conduct: <a href="https://www.ovirt.org/community/about/community-guidelines/" \
target="_blank">https://www.ovirt.org/community/about/community-guidelines/</a><br> \
List Archives: <a href="https://lists.ovirt.org/archives/list/devel@ovirt.org/message/SSUP6XTRKOZB3AG62OJTT3QVUOGPTHNS/" \
target="_blank">https://lists.ovirt.org/archives/list/devel@ovirt.org/message/SSUP6XTRKOZB3AG62OJTT3QVUOGPTHNS/</a><br>
</div>
</blockquote>
</div>
<br>
<br>
<fieldset></fieldset>
<pre>_______________________________________________
Devel mailing list -- <a href="mailto:devel@ovirt.org" \
target="_blank">devel@ovirt.org</a> To unsubscribe send an email to <a \
href="mailto:devel-leave@ovirt.org" target="_blank">devel-leave@ovirt.org</a> Privacy \
Statement: <a href="https://www.ovirt.org/privacy-policy.html" \
target="_blank">https://www.ovirt.org/privacy-policy.html</a> oVirt Code of Conduct: \
<a href="https://www.ovirt.org/community/about/community-guidelines/" \
target="_blank">https://www.ovirt.org/community/about/community-guidelines/</a> List \
Archives: <a href="https://lists.ovirt.org/archives/list/devel@ovirt.org/message/5HDJ2FPC4LW27A46VEQZUDOA6D5H6MRQ/" \
target="_blank">https://lists.ovirt.org/archives/list/devel@ovirt.org/message/5HDJ2FPC4LW27A46VEQZUDOA6D5H6MRQ/</a>
</pre>
</blockquote>
<br>
</div>
</blockquote></div>
</blockquote></div>
</div></blockquote></div><br></div></blockquote></div></div>
</blockquote></div>
["20200321_201505_510426_chrome_vms-failed.png" (image/png)]
[Attachment #9 (text/plain)]
_______________________________________________
Devel mailing list -- devel@ovirt.org
To unsubscribe send an email to devel-leave@ovirt.org
Privacy Statement: https://www.ovirt.org/privacy-policy.html
oVirt Code of Conduct: https://www.ovirt.org/community/about/community-guidelines/
List Archives: https://lists.ovirt.org/archives/list/devel@ovirt.org/message/GZDSHGA6MSTROR4QBYMHRNPO6JFQNX2Y/
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic