[prev in list] [next in list] [prev in thread] [next in thread]
List: vdsm-devel
Subject: =?utf-8?q?=5Bovirt-devel=5D?= Re: Request for reviews vdsm-gluster
From: Kaustav Majumder <kmajumde () redhat ! com>
Date: 2019-11-27 10:54:06
Message-ID: CADQoG4tWwF0vepbe+D4Wae+h+4Z_DpVHmjAhrJiRL6ufWzK=Rw () mail ! gmail ! com
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
Hi,
Thanks for the reviews. I have verified all the patches that are essential
to be merged. Requesting vdsm-maintainers to review and merge.
On Mon, Nov 25, 2019 at 4:12 PM Michal Skrivanek <
michal.skrivanek@redhat.com> wrote:
>
>
> On 25 Nov 2019, at 07:41, Kaustav Majumder <kmajumde@redhat.com> wrote:
>
> Hi,
> I have some patches pending to be merged for vdsm-gluster python3
> compatibility.
> https://gerrit.ovirt.org/#/q/topic:py3-gluster+status:open .
>
> I have verified the patches on rhel8 with python 3.
> CI is also failing for some reason, I am not sure , would also require
> some help in that regard.
>
>
> I checked just two, but in both you have tox/flake8 issues you need to fix
> just look for stuff between vvvvvv ad ^^^^^ in the console log
>
> Thanks,
> michal
>
>
> --
> Thanks,
> Kaustav Majumder
> _______________________________________________
> Devel mailing list -- devel@ovirt.org
> To unsubscribe send an email to devel-leave@ovirt.org
> Privacy Statement: https://www.ovirt.org/site/privacy-policy/
> oVirt Code of Conduct:
> https://www.ovirt.org/community/about/community-guidelines/
> List Archives:
> https://lists.ovirt.org/archives/list/devel@ovirt.org/message/UD2GBGSIGJD3ISKXUL63UMW622DCVT2G/
>
>
>
--
Thanks,
Kaustav Majumder
[Attachment #5 (text/html)]
<div dir="ltr">Hi,<br>Thanks for the reviews. I have verified all the patches that \
are essential to be merged. Requesting vdsm-maintainers to review and \
merge.</div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Mon, \
Nov 25, 2019 at 4:12 PM Michal Skrivanek <<a \
href="mailto:michal.skrivanek@redhat.com">michal.skrivanek@redhat.com</a>> \
wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px \
0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div \
style="overflow-wrap: break-word;"><br><div><br><blockquote type="cite"><div>On 25 \
Nov 2019, at 07:41, Kaustav Majumder <<a href="mailto:kmajumde@redhat.com" \
target="_blank">kmajumde@redhat.com</a>> wrote:</div><br><div><div \
dir="ltr">Hi,<br>I have some patches pending to be merged for vdsm-gluster python3 \
compatibility.<br><a \
href="https://gerrit.ovirt.org/#/q/topic:py3-gluster+status:open" \
target="_blank">https://gerrit.ovirt.org/#/q/topic:py3-gluster+status:open</a> \
.<br><br>I have verified the patches on rhel8 with python 3.<br>CI is also failing \
for some reason, I am not sure , would also require some help in that regard.<br \
clear="all"></div></div></blockquote><div><br></div>I checked just two, but in both \
you have tox/flake8 issues you need to fix</div><div>just look for stuff between \
vvvvvv ad ^^^^^ in the console \
log</div><div><br></div><div>Thanks,</div><div>michal</div><div><br></div><div><blockquote \
type="cite"><div><div dir="ltr"><div><br></div>-- <br><div dir="ltr"><div \
dir="ltr"><div><div dir="ltr"><div dir="ltr"><div \
style="font-family:overpass,sans-serif;letter-spacing:normal;font-weight:bold;margin:0px;padding:0px;font-size:14px;text-transform:uppercase">Thanks,</div><div \
style="font-family:overpass,sans-serif;letter-spacing:normal;font-weight:bold;margin:0px;padding:0px;font-size:14px;text-transform:uppercase">Kaustav \
Majumder</div><div style="font-family:overpass,sans-serif;letter-spacing:normal;font-size:10px"></div><div \
style="font-family:overpass,sans-serif;letter-spacing:normal;font-size:10px"></div></div></div></div></div></div></div>
_______________________________________________<br>Devel mailing list -- <a \
href="mailto:devel@ovirt.org" target="_blank">devel@ovirt.org</a><br>To unsubscribe \
send an email to <a href="mailto:devel-leave@ovirt.org" \
target="_blank">devel-leave@ovirt.org</a><br>Privacy Statement: <a \
href="https://www.ovirt.org/site/privacy-policy/" \
target="_blank">https://www.ovirt.org/site/privacy-policy/</a><br>oVirt Code of \
Conduct: <a href="https://www.ovirt.org/community/about/community-guidelines/" \
target="_blank">https://www.ovirt.org/community/about/community-guidelines/</a><br>List \
Archives: <a href="https://lists.ovirt.org/archives/list/devel@ovirt.org/message/UD2GBGSIGJD3ISKXUL63UMW622DCVT2G/" \
target="_blank">https://lists.ovirt.org/archives/list/devel@ovirt.org/message/UD2GBGSI \
GJD3ISKXUL63UMW622DCVT2G/</a><br></div></blockquote></div><br></div></blockquote></div><br \
clear="all"><div><br></div>-- <br><div dir="ltr" class="gmail_signature"><div \
dir="ltr"><div><div dir="ltr"><div dir="ltr"><p \
style="color:rgb(0,0,0);font-family:overpass,sans-serif;letter-spacing:normal;font-wei \
ght:bold;margin:0px;padding:0px;font-size:14px;text-transform:uppercase">Thanks,</p><p \
style="color:rgb(0,0,0);font-family:overpass,sans-serif;letter-spacing:normal;font-weight:bold;margin:0px;padding:0px;font-size:14px;text-transform:uppercase">Kaustav \
Majumder</p><div style="color:rgb(0,0,0);font-family:overpass,sans-serif;letter-spacing:normal;font-size:10px"></div><div \
style="color:rgb(0,0,0);font-family:overpass,sans-serif;letter-spacing:normal;font-size:10px"></div></div></div></div></div></div>
[Attachment #6 (text/plain)]
_______________________________________________
Devel mailing list -- devel@ovirt.org
To unsubscribe send an email to devel-leave@ovirt.org
Privacy Statement: https://www.ovirt.org/site/privacy-policy/
oVirt Code of Conduct: https://www.ovirt.org/community/about/community-guidelines/
List Archives: https://lists.ovirt.org/archives/list/devel@ovirt.org/message/YAYGSCVLAUBBVWTMNR3D23LSWFSGW3XH/
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic